mtd: spi-nor: add support for is25lp032

Message ID 20170830193323.14478-1-sean.nyekjaer@prevas.dk
State Rejected
Delegated to: Cyrille Pitchen
Headers show
Series
  • mtd: spi-nor: add support for is25lp032
Related show

Commit Message

Sean Nyekjaer Aug. 30, 2017, 7:33 p.m.
Signed-off-by: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
---
 drivers/mtd/spi-nor/spi-nor.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Cyrille Pitchen Oct. 16, 2017, 9:58 p.m. | #1
Hi Sean,

Le 30/08/2017 à 21:33, Sean Nyekjaer a écrit :
> Signed-off-by: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
> ---
>  drivers/mtd/spi-nor/spi-nor.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index cf1d4a15e10a..a764fe67b59c 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1005,6 +1005,7 @@ static const struct flash_info spi_nor_ids[] = {
>  
>  	/* ISSI */
>  	{ "is25cd512", INFO(0x7f9d20, 0, 32 * 1024,   2, SECT_4K) },
> +	{ "is25lp032", INFO(0x9d4013, 0, 64 * 1024,  64, SECT_4K) },

I'm reading the IS25LP032 datasheet:
http://www.issi.com/WW/pdf/IS25LP032-064-128.pdf

Table 8.3 Product Identification states that the JEDEC ID should be
0x9d6016. Is the datasheet wrong or did you make a mistake on the memory
name ?

Best regards,

Cyrille


>  
>  	/* Macronix */
>  	{ "mx25l512e",   INFO(0xc22010, 0, 64 * 1024,   1, SECT_4K) },
>
Sean Nyekjaer Oct. 17, 2017, 6:40 a.m. | #2
Hi

On 2017-10-16 23:58, Cyrille Pitchen wrote:
> Hi Sean,
>
> Le 30/08/2017 à 21:33, Sean Nyekjaer a écrit :
>> Signed-off-by: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
>> ---
>>   drivers/mtd/spi-nor/spi-nor.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>> index cf1d4a15e10a..a764fe67b59c 100644
>> --- a/drivers/mtd/spi-nor/spi-nor.c
>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>> @@ -1005,6 +1005,7 @@ static const struct flash_info spi_nor_ids[] = {
>>   
>>   	/* ISSI */
>>   	{ "is25cd512", INFO(0x7f9d20, 0, 32 * 1024,   2, SECT_4K) },
>> +	{ "is25lp032", INFO(0x9d4013, 0, 64 * 1024,  64, SECT_4K) },
> I'm reading the IS25LP032 datasheet:
> http://www.issi.com/WW/pdf/IS25LP032-064-128.pdf
>
> Table 8.3 Product Identification states that the JEDEC ID should be
> 0x9d6016. Is the datasheet wrong or did you make a mistake on the memory
> name ?
>
> Best regards,
>
> Cyrille
I did a mistake in the memory name :-) The device with that ID is 
IS25LQ040B. I'll resubmit a patch with the correct name.

BR
/Sean
>
>
>>   
>>   	/* Macronix */
>>   	{ "mx25l512e",   INFO(0xc22010, 0, 64 * 1024,   1, SECT_4K) },
>>

Patch

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index cf1d4a15e10a..a764fe67b59c 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -1005,6 +1005,7 @@  static const struct flash_info spi_nor_ids[] = {
 
 	/* ISSI */
 	{ "is25cd512", INFO(0x7f9d20, 0, 32 * 1024,   2, SECT_4K) },
+	{ "is25lp032", INFO(0x9d4013, 0, 64 * 1024,  64, SECT_4K) },
 
 	/* Macronix */
 	{ "mx25l512e",   INFO(0xc22010, 0, 64 * 1024,   1, SECT_4K) },