From patchwork Wed Aug 30 14:50:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Murzin X-Patchwork-Id: 807664 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xj7jX53wKz9s9Y for ; Thu, 31 Aug 2017 00:50:56 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751375AbdH3Ouz (ORCPT ); Wed, 30 Aug 2017 10:50:55 -0400 Received: from foss.arm.com ([217.140.101.70]:45752 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372AbdH3Ouz (ORCPT ); Wed, 30 Aug 2017 10:50:55 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1C0D080D; Wed, 30 Aug 2017 07:50:55 -0700 (PDT) Received: from login2.euhpc.arm.com (login2.euhpc.arm.com [10.6.26.144]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 472963F483; Wed, 30 Aug 2017 07:50:54 -0700 (PDT) From: Vladimir Murzin To: linux-gpio@vger.kernel.org Cc: linus.walleij@linaro.org, grygorii.strashko@ti.com Subject: [PATCH] gpio: syscon: do not use raw "set" callback in syscon_gpio_dir_out Date: Wed, 30 Aug 2017 15:50:41 +0100 Message-Id: <1504104641-8369-1-git-send-email-vladimir.murzin@arm.com> X-Mailer: git-send-email 2.0.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org "set" callback is optional and can be NULL, instead use chip->set which always points at proper callback function. Fixes 2c341d62eb4b ("gpio: syscon: add soc specific callback to assign output value") Signed-off-by: Vladimir Murzin Acked-by: Alexander Shiyan --- drivers/gpio/gpio-syscon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c index 537cec7..cf88a0b 100644 --- a/drivers/gpio/gpio-syscon.c +++ b/drivers/gpio/gpio-syscon.c @@ -122,7 +122,7 @@ static int syscon_gpio_dir_out(struct gpio_chip *chip, unsigned offset, int val) BIT(offs % SYSCON_REG_BITS)); } - priv->data->set(chip, offset, val); + chip->set(chip, offset, val); return 0; }