| Message ID | 3cdaecc7c8080b0f2172d8788b96303528957b08.1504093495.git.arvind.yadav.cs@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | RDS: constify rhashtable_params | expand |
On 8/30/17 4:49 AM, Arvind Yadav wrote: > rhashtable_params are not supposed to change at runtime. All > Functions rhashtable_* working with const rhashtable_params > provided by <linux/rhashtable.h>. So mark the non-const structs > as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- This is already addressed in net-next by [1] Regards, Santosh [1] https://lkml.org/lkml/2017/8/25/482
diff --git a/net/rds/bind.c b/net/rds/bind.c index 3a915be..75d43dc 100644 --- a/net/rds/bind.c +++ b/net/rds/bind.c @@ -40,7 +40,7 @@ static struct rhashtable bind_hash_table; -static struct rhashtable_params ht_parms = { +static const struct rhashtable_params ht_parms = { .nelem_hint = 768, .key_len = sizeof(u64), .key_offset = offsetof(struct rds_sock, rs_bound_key),
rhashtable_params are not supposed to change at runtime. All Functions rhashtable_* working with const rhashtable_params provided by <linux/rhashtable.h>. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- net/rds/bind.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)