Patchwork __ext4_get_inode_loc: use s_inodes_per_block directly

login
register
mail settings
Submitter Coly Li
Date Jan. 27, 2011, 4:33 p.m.
Message ID <1296145986-4985-1-git-send-email-bosong.ly@taobao.com>
Download mbox | patch
Permalink /patch/80711/
State New
Headers show

Comments

Coly Li - Jan. 27, 2011, 4:33 p.m.
In __ext4_get_inode_loc(), inodes_per_block is calculated by
(EXT4_BLOCK_SIZE(sb) / EXT4_INODE_SIZE(sb)). This is unncessary, the
value can be found directly from s_inodes_per_block.

Signed-off-by: Coly Li <bosong.ly@taobao.com>
Cc: Theodore Tso <tytso@google.com>
---
 fs/ext4/inode.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 9f7f9e4..837c5a6 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -4668,7 +4668,7 @@  static int __ext4_get_inode_loc(struct inode *inode,
 	/*
 	 * Figure out the offset within the block group inode table
 	 */
-	inodes_per_block = (EXT4_BLOCK_SIZE(sb) / EXT4_INODE_SIZE(sb));
+	inodes_per_block = EXT4_SB(sb)->s_inodes_per_block;
 	inode_offset = ((inode->i_ino - 1) %
 			EXT4_INODES_PER_GROUP(sb));
 	block = ext4_inode_table(sb, gdp) + (inode_offset / inodes_per_block);