| Submitter | Kevin Wolf |
|---|---|
| Date | Jan. 27, 2011, 3:50 p.m. |
| Message ID | <1296143402-13274-1-git-send-email-kwolf@redhat.com> |
| Download | mbox | patch |
| Permalink | /patch/80707/ |
| State | New |
| Headers | show |
Comments
On Thu, Jan 27, 2011 at 3:50 PM, Kevin Wolf <kwolf@redhat.com> wrote: > For cache=unsafe we also need to set BDRV_O_CACHE_WB, otherwise we have some > strange unsafe writethrough mode. > > Signed-off-by: Kevin Wolf <kwolf@redhat.com> > --- > block/qcow2.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Patch
diff --git a/block/qcow2.c b/block/qcow2.c index dbe4fdd..a1773e4 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -975,7 +975,8 @@ static int qcow2_create2(const char *filename, int64_t total_size, */ BlockDriver* drv = bdrv_find_format("qcow2"); assert(drv != NULL); - ret = bdrv_open(bs, filename, BDRV_O_RDWR | BDRV_O_NO_FLUSH, drv); + ret = bdrv_open(bs, filename, + BDRV_O_RDWR | BDRV_O_CACHE_WB | BDRV_O_NO_FLUSH, drv); if (ret < 0) { goto out; }
For cache=unsafe we also need to set BDRV_O_CACHE_WB, otherwise we have some strange unsafe writethrough mode. Signed-off-by: Kevin Wolf <kwolf@redhat.com> --- block/qcow2.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)