diff mbox series

[net-next,v3,01/13] phy: add sgmii and 10gkr modes to the phy_mode enum

Message ID 20170828145725.2539-2-antoine.tenart@free-electrons.com
State Changes Requested, archived
Delegated to: David Miller
Headers show
Series net: mvpp2: comphy configuration | expand

Commit Message

Antoine Tenart Aug. 28, 2017, 2:57 p.m. UTC
This patch adds more generic PHY modes to the phy_mode enum, to
allow configuring generic PHYs to the SGMII and/or the 10GKR mode
by using the set_mode callback.

Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
---
 include/linux/phy/phy.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Kishon Vijay Abraham I Aug. 29, 2017, 10:38 a.m. UTC | #1
On Monday 28 August 2017 08:27 PM, Antoine Tenart wrote:
> This patch adds more generic PHY modes to the phy_mode enum, to
> allow configuring generic PHYs to the SGMII and/or the 10GKR mode
> by using the set_mode callback.
> 
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>

Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  include/linux/phy/phy.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
> index 78bb0d7f6b11..e694d4008c4a 100644
> --- a/include/linux/phy/phy.h
> +++ b/include/linux/phy/phy.h
> @@ -27,6 +27,8 @@ enum phy_mode {
>  	PHY_MODE_USB_HOST,
>  	PHY_MODE_USB_DEVICE,
>  	PHY_MODE_USB_OTG,
> +	PHY_MODE_SGMII,
> +	PHY_MODE_10GKR,
>  };
>  
>  /**
>
Antoine Tenart Aug. 29, 2017, 11:27 a.m. UTC | #2
Hi Kishon,

On Tue, Aug 29, 2017 at 04:08:29PM +0530, Kishon Vijay Abraham I wrote:
> On Monday 28 August 2017 08:27 PM, Antoine Tenart wrote:
> > This patch adds more generic PHY modes to the phy_mode enum, to
> > allow configuring generic PHYs to the SGMII and/or the 10GKR mode
> > by using the set_mode callback.
> > 
> > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> 
> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>

Does this means the generic PHY patches of this series can go through
the net-next tree (once all the comments are taken into account)?

Thanks!
Antoine
Kishon Vijay Abraham I Aug. 29, 2017, 12:21 p.m. UTC | #3
Hi,

On Tuesday 29 August 2017 04:57 PM, Antoine Tenart wrote:
> Hi Kishon,
> 
> On Tue, Aug 29, 2017 at 04:08:29PM +0530, Kishon Vijay Abraham I wrote:
>> On Monday 28 August 2017 08:27 PM, Antoine Tenart wrote:
>>> This patch adds more generic PHY modes to the phy_mode enum, to
>>> allow configuring generic PHYs to the SGMII and/or the 10GKR mode
>>> by using the set_mode callback.
>>>
>>> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
>>
>> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> 
> Does this means the generic PHY patches of this series can go through
> the net-next tree (once all the comments are taken into account)?

yeah.. I'm already done with my pull request for 4.14 to Greg KH. As long as it
doesn't cause any conflicts to Linus, it should be okay to merge it in net-next.

Thanks
Kishon
diff mbox series

Patch

diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
index 78bb0d7f6b11..e694d4008c4a 100644
--- a/include/linux/phy/phy.h
+++ b/include/linux/phy/phy.h
@@ -27,6 +27,8 @@  enum phy_mode {
 	PHY_MODE_USB_HOST,
 	PHY_MODE_USB_DEVICE,
 	PHY_MODE_USB_OTG,
+	PHY_MODE_SGMII,
+	PHY_MODE_10GKR,
 };
 
 /**