pinctrl: uniphier: fix members of rmii group for Pro4

Message ID 1503886886-30065-1-git-send-email-hayashi.kunihiko@socionext.com
State New
Headers show
Series
  • pinctrl: uniphier: fix members of rmii group for Pro4
Related show

Commit Message

Kunihiko Hayashi Aug. 28, 2017, 2:21 a.m.
The ether_rmii_groups should have "ether_rmii" and "ether_rmiib" as
members. This patch replaces to them.

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
 drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Masahiro Yamada Aug. 28, 2017, 2:28 a.m. | #1
2017-08-28 11:21 GMT+09:00 Kunihiko Hayashi <hayashi.kunihiko@socionext.com>:
> The ether_rmii_groups should have "ether_rmii" and "ether_rmiib" as
> members. This patch replaces to them.


Linus,
When you pick up this, please add

Fixes: 1e359ab1285e ("1e359ab1285eaa7")


> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>


Otherwise, looks good to me.

Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Masahiro Yamada Aug. 28, 2017, 3:16 a.m. | #2
2017-08-28 11:28 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> 2017-08-28 11:21 GMT+09:00 Kunihiko Hayashi <hayashi.kunihiko@socionext.com>:
>> The ether_rmii_groups should have "ether_rmii" and "ether_rmiib" as
>> members. This patch replaces to them.
>
>
> Linus,
> When you pick up this, please add
>
> Fixes: 1e359ab1285e ("1e359ab1285eaa7")

My mistake.  I mean,

Fixes: 1e359ab1285e ("pinctrl: uniphier: add Ethernet pin-mux settings")



>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>
>
> Otherwise, looks good to me.
>
> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
>
>
>
>
> --
> Best Regards
> Masahiro Yamada
Linus Walleij Aug. 31, 2017, 1:51 p.m. | #3
On Mon, Aug 28, 2017 at 4:21 AM, Kunihiko Hayashi
<hayashi.kunihiko@socionext.com> wrote:

> The ether_rmii_groups should have "ether_rmii" and "ether_rmiib" as
> members. This patch replaces to them.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>

Patch applied with Fixes: tag and ACKs.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c b/drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c
index a433a30..adc65ea 100644
--- a/drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c
+++ b/drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c
@@ -1462,7 +1462,7 @@  static const struct uniphier_pinctrl_group uniphier_pro4_groups[] = {
 static const char * const emmc_groups[] = {"emmc", "emmc_dat8"};
 static const char * const ether_mii_groups[] = {"ether_mii"};
 static const char * const ether_rgmii_groups[] = {"ether_rgmii"};
-static const char * const ether_rmii_groups[] = {"ether_rgmii", "ether_rgmiib"};
+static const char * const ether_rmii_groups[] = {"ether_rmii", "ether_rmiib"};
 static const char * const i2c0_groups[] = {"i2c0"};
 static const char * const i2c1_groups[] = {"i2c1"};
 static const char * const i2c2_groups[] = {"i2c2"};