| Message ID | 1503714458-20380-1-git-send-email-fukaige@huawei.com |
|---|---|
| State | Accepted |
| Headers | show |
On 08/25/2017 07:27 PM, fukaige wrote: > From: Kaige Fu <fukaige@huawei.com> > > Signed-off-by: Kaige Fu <fukaige@huawei.com> > --- > lib/dpif.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/lib/dpif.c b/lib/dpif.c > index 79b2e6c..a4471d5 100644 > --- a/lib/dpif.c > +++ b/lib/dpif.c > @@ -1547,11 +1547,11 @@ dpif_set_config(struct dpif *dpif, const struct smap *cfg) > return error; > } > > -/* Polls for an upcall from 'dpif' for an upcall handler. Since there > - * there can be multiple poll loops, 'handler_id' is needed as index to > - * identify the corresponding poll loop. If successful, stores the upcall > - * into '*upcall', using 'buf' for storage. Should only be called if > - * 'recv_set' has been used to enable receiving packets from 'dpif'. > +/* Polls for an upcall from 'dpif' for an upcall handler. Since there can > + * be multiple poll loops, 'handler_id' is needed as index to identify the > + * corresponding poll loop. If successful, stores the upcall into '*upcall', > + * using 'buf' for storage. Should only be called if 'recv_set' has been used > + * to enable receiving packets from 'dpif'. > * > * 'upcall->key' and 'upcall->userdata' point into data in the caller-provided > * 'buf', so their memory cannot be freed separately from 'buf'. > LGTM Reviewed-by: Greg Rose <gvrose8192@gmail.com>
On Tue, Aug 29, 2017 at 08:25:28AM -0700, Greg Rose wrote: > On 08/25/2017 07:27 PM, fukaige wrote: > >From: Kaige Fu <fukaige@huawei.com> > > > >Signed-off-by: Kaige Fu <fukaige@huawei.com> > >--- > > lib/dpif.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > >diff --git a/lib/dpif.c b/lib/dpif.c > >index 79b2e6c..a4471d5 100644 > >--- a/lib/dpif.c > >+++ b/lib/dpif.c > >@@ -1547,11 +1547,11 @@ dpif_set_config(struct dpif *dpif, const struct smap *cfg) > > return error; > > } > > > >-/* Polls for an upcall from 'dpif' for an upcall handler. Since there > >- * there can be multiple poll loops, 'handler_id' is needed as index to > >- * identify the corresponding poll loop. If successful, stores the upcall > >- * into '*upcall', using 'buf' for storage. Should only be called if > >- * 'recv_set' has been used to enable receiving packets from 'dpif'. > >+/* Polls for an upcall from 'dpif' for an upcall handler. Since there can > >+ * be multiple poll loops, 'handler_id' is needed as index to identify the > >+ * corresponding poll loop. If successful, stores the upcall into '*upcall', > >+ * using 'buf' for storage. Should only be called if 'recv_set' has been used > >+ * to enable receiving packets from 'dpif'. > > * > > * 'upcall->key' and 'upcall->userdata' point into data in the caller-provided > > * 'buf', so their memory cannot be freed separately from 'buf'. > > > LGTM > > Reviewed-by: Greg Rose <gvrose8192@gmail.com> Thanks fukaige and Greg, I applied this to master.
diff --git a/lib/dpif.c b/lib/dpif.c index 79b2e6c..a4471d5 100644 --- a/lib/dpif.c +++ b/lib/dpif.c @@ -1547,11 +1547,11 @@ dpif_set_config(struct dpif *dpif, const struct smap *cfg) return error; } -/* Polls for an upcall from 'dpif' for an upcall handler. Since there - * there can be multiple poll loops, 'handler_id' is needed as index to - * identify the corresponding poll loop. If successful, stores the upcall - * into '*upcall', using 'buf' for storage. Should only be called if - * 'recv_set' has been used to enable receiving packets from 'dpif'. +/* Polls for an upcall from 'dpif' for an upcall handler. Since there can + * be multiple poll loops, 'handler_id' is needed as index to identify the + * corresponding poll loop. If successful, stores the upcall into '*upcall', + * using 'buf' for storage. Should only be called if 'recv_set' has been used + * to enable receiving packets from 'dpif'. * * 'upcall->key' and 'upcall->userdata' point into data in the caller-provided * 'buf', so their memory cannot be freed separately from 'buf'.