| Message ID | 1503673364-3166-2-git-send-email-abalutoiu@cloudbasesolutions.com |
|---|---|
| State | Accepted |
| Headers | show |
Acked-by: Alin Gabriel Serdean <aserdean@ovn.org> > -----Original Message----- > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev- > bounces@openvswitch.org] On Behalf Of Alin Balutoiu > Sent: Friday, August 25, 2017 6:03 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH] windows,python: remove dead code in > send_wait > > Found while looking over the code. > > Signed-off-by: Alin Balutoiu <abalutoiu@cloudbasesolutions.com> > Suggested-by: Alin Gabriel Serdean <aserdean@ovn.org> > --- > python/ovs/stream.py | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/python/ovs/stream.py b/python/ovs/stream.py index > 717ea18..d4c1edb 100644 > --- a/python/ovs/stream.py > +++ b/python/ovs/stream.py > @@ -494,8 +494,6 @@ class Stream(object): > self.wait(poller, Stream.W_RECV) > > def send_wait(self, poller): > - if sys.platform == 'win32': > - poller.fd_wait(self.connect.hEvent, ovs.poller.POLLIN) > self.wait(poller, Stream.W_SEND) > > def __del__(self): > -- > 2.10.0.windows.1 > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Acked-by: Anand Kumar <kumaranand@vmware.com> On 8/29/17, 2:56 AM, "ovs-dev-bounces@openvswitch.org on behalf of aserdean@ovn.org" <ovs-dev-bounces@openvswitch.org on behalf of aserdean@ovn.org> wrote: Acked-by: Alin Gabriel Serdean <aserdean@ovn.org> > -----Original Message----- > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev- > bounces@openvswitch.org] On Behalf Of Alin Balutoiu > Sent: Friday, August 25, 2017 6:03 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH] windows,python: remove dead code in > send_wait > > Found while looking over the code. > > Signed-off-by: Alin Balutoiu <abalutoiu@cloudbasesolutions.com> > Suggested-by: Alin Gabriel Serdean <aserdean@ovn.org> > --- > python/ovs/stream.py | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/python/ovs/stream.py b/python/ovs/stream.py index > 717ea18..d4c1edb 100644 > --- a/python/ovs/stream.py > +++ b/python/ovs/stream.py > @@ -494,8 +494,6 @@ class Stream(object): > self.wait(poller, Stream.W_RECV) > > def send_wait(self, poller): > - if sys.platform == 'win32': > - poller.fd_wait(self.connect.hEvent, ovs.poller.POLLIN) > self.wait(poller, Stream.W_SEND) > > def __del__(self): > -- > 2.10.0.windows.1 > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=Q5z9tBe-nAOpE7LIHSPV8uy5-437agMXvkeHHMkR8Us&m=RTvArz65jNY07EptIqknYmWtMD_bKJfRu9oVpiCTO80&s=M4ly1NbfGwxO734HCFvsHWmglPutO7_aV7uZ8JWdQwo&e= _______________________________________________ dev mailing list dev@openvswitch.org https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=Q5z9tBe-nAOpE7LIHSPV8uy5-437agMXvkeHHMkR8Us&m=RTvArz65jNY07EptIqknYmWtMD_bKJfRu9oVpiCTO80&s=M4ly1NbfGwxO734HCFvsHWmglPutO7_aV7uZ8JWdQwo&e=
Thanks Anand and Alin! I applied on master, branch-2.8 and branch-2.7. Alin. > -----Original Message----- > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev- > bounces@openvswitch.org] On Behalf Of Anand Kumar > Sent: Thursday, September 7, 2017 11:08 PM > To: aserdean@ovn.org; Alin Balutoiu <abalutoiu@cloudbasesolutions.com>; > dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] windows, python: remove dead code in > send_wait > > Acked-by: Anand Kumar <kumaranand@vmware.com> > > On 8/29/17, 2:56 AM, "ovs-dev-bounces@openvswitch.org on behalf of > aserdean@ovn.org" <ovs-dev-bounces@openvswitch.org on behalf of > aserdean@ovn.org> wrote: > > Acked-by: Alin Gabriel Serdean <aserdean@ovn.org> > >
diff --git a/python/ovs/stream.py b/python/ovs/stream.py index 717ea18..d4c1edb 100644 --- a/python/ovs/stream.py +++ b/python/ovs/stream.py @@ -494,8 +494,6 @@ class Stream(object): self.wait(poller, Stream.W_RECV) def send_wait(self, poller): - if sys.platform == 'win32': - poller.fd_wait(self.connect.hEvent, ovs.poller.POLLIN) self.wait(poller, Stream.W_SEND) def __del__(self):
Found while looking over the code. Signed-off-by: Alin Balutoiu <abalutoiu@cloudbasesolutions.com> Suggested-by: Alin Gabriel Serdean <aserdean@ovn.org> --- python/ovs/stream.py | 2 -- 1 file changed, 2 deletions(-)