Patchwork pci: typo in pcibus_get_dev_path()

login
register
mail settings
Submitter Isaku Yamahata
Date Jan. 27, 2011, 3:49 a.m.
Message ID <852fa434bfd6eab6c97c2dcf58bd5773afb0d905.1296100102.git.yamahata@valinux.co.jp>
Download mbox | patch
Permalink /patch/80579/
State New
Headers show

Comments

Isaku Yamahata - Jan. 27, 2011, 3:49 a.m.
This patch fixes typo in pcibus_get_dev_path().
Without this patch, the result of pcibus_get_dev_path() isn't unique.

Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
 hw/pci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Michael S. Tsirkin - Jan. 27, 2011, 4:54 a.m.
On Thu, Jan 27, 2011 at 12:49:04PM +0900, Isaku Yamahata wrote:
> This patch fixes typo in pcibus_get_dev_path().
> Without this patch, the result of pcibus_get_dev_path() isn't unique.
> 
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

Good catch, applied, thanks.

> ---
>  hw/pci.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/pci.c b/hw/pci.c
> index d2a0cee..b3d8ba5 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -2191,7 +2191,7 @@ static char *pcibus_get_dev_path(DeviceState *dev)
>      for (t = d; t; t = t->bus->parent_dev) {
>          p -= slot_len;
>          s = snprintf(slot, sizeof slot, ":%02x.%x",
> -                     PCI_SLOT(t->devfn), PCI_FUNC(d->devfn));
> +                     PCI_SLOT(t->devfn), PCI_FUNC(t->devfn));
>          assert(s == slot_len);
>          memcpy(p, slot, slot_len);
>      }
> -- 
> 1.7.1.1

Patch

diff --git a/hw/pci.c b/hw/pci.c
index d2a0cee..b3d8ba5 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -2191,7 +2191,7 @@  static char *pcibus_get_dev_path(DeviceState *dev)
     for (t = d; t; t = t->bus->parent_dev) {
         p -= slot_len;
         s = snprintf(slot, sizeof slot, ":%02x.%x",
-                     PCI_SLOT(t->devfn), PCI_FUNC(d->devfn));
+                     PCI_SLOT(t->devfn), PCI_FUNC(t->devfn));
         assert(s == slot_len);
         memcpy(p, slot, slot_len);
     }