| Message ID | 1503592220-8960-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Delegated to: | Marek Vasut |
| Headers | show |
On 08/24/2017 06:30 PM, Masahiro Yamada wrote: > We see the choice of USB_DWC3_HOST / _GADGET in drivers/usb/dwc3/Kconfig, > but we can not choose USB_DWC3_HOST unless USB_GADGET is defined. > This is strange. > > Loosen the "depends on" and also move "select USB_GADGET_DUALSPEED" to > the correct place. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Applied, thanks > --- > > drivers/usb/dwc3/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig > index e93398fe7c1c..7f2f400c09ce 100644 > --- a/drivers/usb/dwc3/Kconfig > +++ b/drivers/usb/dwc3/Kconfig > @@ -1,7 +1,6 @@ > config USB_DWC3 > bool "DesignWare USB3 DRD Core Support" > - depends on (USB && USB_GADGET) > - select USB_GADGET_DUALSPEED > + depends on (USB_HOST || USB_GADGET) > help > Say Y here if your system has a Dual Role SuperSpeed > USB controller based on the DesignWare USB3 IP Core. > @@ -21,6 +20,7 @@ config USB_DWC3_HOST > config USB_DWC3_GADGET > bool "Gadget only mode" > depends on USB_GADGET > + select USB_GADGET_DUALSPEED > help > Select this when you want to use DWC3 in gadget mode only, > thereby the host feature will be regressed. >
2017-08-25 6:57 GMT+09:00 Marek Vasut <marex@denx.de>: > On 08/24/2017 06:30 PM, Masahiro Yamada wrote: >> We see the choice of USB_DWC3_HOST / _GADGET in drivers/usb/dwc3/Kconfig, >> but we can not choose USB_DWC3_HOST unless USB_GADGET is defined. >> This is strange. >> >> Loosen the "depends on" and also move "select USB_GADGET_DUALSPEED" to >> the correct place. >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > Applied, thanks > >> --- >> >> drivers/usb/dwc3/Kconfig | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig >> index e93398fe7c1c..7f2f400c09ce 100644 >> --- a/drivers/usb/dwc3/Kconfig >> +++ b/drivers/usb/dwc3/Kconfig >> @@ -1,7 +1,6 @@ >> config USB_DWC3 >> bool "DesignWare USB3 DRD Core Support" >> - depends on (USB && USB_GADGET) >> - select USB_GADGET_DUALSPEED >> + depends on (USB_HOST || USB_GADGET) >> help >> Say Y here if your system has a Dual Role SuperSpeed >> USB controller based on the DesignWare USB3 IP Core. >> @@ -21,6 +20,7 @@ config USB_DWC3_HOST >> config USB_DWC3_GADGET >> bool "Gadget only mode" >> depends on USB_GADGET >> + select USB_GADGET_DUALSPEED >> help >> Select this when you want to use DWC3 in gadget mode only, >> thereby the host feature will be regressed. >> > Marek, I noticed redundant parentheses for depends on. Could you fix it up locally like follows? depends on (USB_HOST || USB_GADGET) -> depends on USB_HOST || USB_GADGET Thanks.
On 08/25/2017 05:56 AM, Masahiro Yamada wrote: > 2017-08-25 6:57 GMT+09:00 Marek Vasut <marex@denx.de>: >> On 08/24/2017 06:30 PM, Masahiro Yamada wrote: >>> We see the choice of USB_DWC3_HOST / _GADGET in drivers/usb/dwc3/Kconfig, >>> but we can not choose USB_DWC3_HOST unless USB_GADGET is defined. >>> This is strange. >>> >>> Loosen the "depends on" and also move "select USB_GADGET_DUALSPEED" to >>> the correct place. >>> >>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> >> >> Applied, thanks >> >>> --- >>> >>> drivers/usb/dwc3/Kconfig | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig >>> index e93398fe7c1c..7f2f400c09ce 100644 >>> --- a/drivers/usb/dwc3/Kconfig >>> +++ b/drivers/usb/dwc3/Kconfig >>> @@ -1,7 +1,6 @@ >>> config USB_DWC3 >>> bool "DesignWare USB3 DRD Core Support" >>> - depends on (USB && USB_GADGET) >>> - select USB_GADGET_DUALSPEED >>> + depends on (USB_HOST || USB_GADGET) >>> help >>> Say Y here if your system has a Dual Role SuperSpeed >>> USB controller based on the DesignWare USB3 IP Core. >>> @@ -21,6 +20,7 @@ config USB_DWC3_HOST >>> config USB_DWC3_GADGET >>> bool "Gadget only mode" >>> depends on USB_GADGET >>> + select USB_GADGET_DUALSPEED >>> help >>> Select this when you want to use DWC3 in gadget mode only, >>> thereby the host feature will be regressed. >>> >> > > Marek, > > I noticed redundant parentheses for depends on. > Could you fix it up locally like follows? > > > depends on (USB_HOST || USB_GADGET) > > -> > > depends on USB_HOST || USB_GADGET Hrmm, fixed.
diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig index e93398fe7c1c..7f2f400c09ce 100644 --- a/drivers/usb/dwc3/Kconfig +++ b/drivers/usb/dwc3/Kconfig @@ -1,7 +1,6 @@ config USB_DWC3 bool "DesignWare USB3 DRD Core Support" - depends on (USB && USB_GADGET) - select USB_GADGET_DUALSPEED + depends on (USB_HOST || USB_GADGET) help Say Y here if your system has a Dual Role SuperSpeed USB controller based on the DesignWare USB3 IP Core. @@ -21,6 +20,7 @@ config USB_DWC3_HOST config USB_DWC3_GADGET bool "Gadget only mode" depends on USB_GADGET + select USB_GADGET_DUALSPEED help Select this when you want to use DWC3 in gadget mode only, thereby the host feature will be regressed.
We see the choice of USB_DWC3_HOST / _GADGET in drivers/usb/dwc3/Kconfig, but we can not choose USB_DWC3_HOST unless USB_GADGET is defined. This is strange. Loosen the "depends on" and also move "select USB_GADGET_DUALSPEED" to the correct place. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/usb/dwc3/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)