From patchwork Wed Jan 26 18:18:25 2011
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Ian Bolton <ian.bolton@arm.com>
X-Patchwork-Id: 80537
Return-Path: 
 <gcc-patches-return-283874-incoming=patchwork.ozlabs.org@gcc.gnu.org>
X-Original-To: incoming@patchwork.ozlabs.org
Delivered-To: patchwork-incoming@bilbo.ozlabs.org
Received: from sourceware.org (server1.sourceware.org [209.132.180.131])
	by ozlabs.org (Postfix) with SMTP id 4F384B70EE
	for <incoming@patchwork.ozlabs.org>;
	Thu, 27 Jan 2011 05:18:45 +1100 (EST)
Received: (qmail 18811 invoked by alias); 26 Jan 2011 18:18:43 -0000
Received: (qmail 18798 invoked by uid 22791); 26 Jan 2011 18:18:41 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL, BAYES_00,
	MSGID_MULTIPLE_AT, RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from service87.mimecast.com (HELO service87.mimecast.com)
	(94.185.240.25) by sourceware.org (qpsmtpd/0.43rc1) with SMTP;
	Wed, 26 Jan 2011 18:18:35 +0000
Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com
	[217.140.96.21])	by service87.mimecast.com;
	Wed, 26 Jan 2011 18:18:31 +0000
Received: from E102352 ([10.1.255.212]) by cam-owa1.Emea.Arm.com with
	Microsoft SMTPSVC(6.0.3790.0); Wed, 26 Jan 2011 18:18:29 +0000
From: "Ian Bolton" <ian.bolton@arm.com>
To: "'Joseph Myers'" <joseph@codesourcery.com>
Cc: <gcc-patches@gcc.gnu.org>
References: <000001cbb3f8$8351ab60$89f50220$@bolton@arm.com>
	<Pine.LNX.4.64.1101141723290.18651@digraph.polyomino.org.uk>
	<000201cbb6f4$9474f740$bd5ee5c0$@bolton@arm.com>
	<Pine.LNX.4.64.1101252258190.1203@digraph.polyomino.org.uk>
In-Reply-To: <Pine.LNX.4.64.1101252258190.1203@digraph.polyomino.org.uk>
Subject: RE: [patch,
	testsuite] Fix another short-enums testsuite error for ARM
Date: Wed, 26 Jan 2011 18:18:25 -0000
Message-ID: <000001cbbd85$6c6ec590$454c50b0$@bolton@arm.com>
MIME-Version: 1.0
X-MC-Unique: 111012618183102301
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Unsubscribe: 
 <mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Delivered-To: mailing list gcc-patches@gcc.gnu.org

> From: Joseph Myers [mailto:joseph@codesourcery.com]
> On Tue, 18 Jan 2011, Ian Bolton wrote:
> 
> > > The normal approach for the warning would be to pass
> > > -Wl,--no-enum-size-warning on ARM eabi targets (or at least, that's
> the
> > > approach for tests passing -fshort-enums explicitly).
> > >
> >
> > Thanks for the input, Joseph.
> >
> > I've updated the test to reflect this.  Assuming that other targets
> can
> > handle that linker option too, it should be good to go.  If not, I
> will
> > probably need to limit this patch to ARM eabi targets only.
> 
> This option is specific to ARM EABI targets.
> 

Thanks for the clarification.

In that case, I am just going to fix up ARM.

Is the following patch OK for trunk?


2011-01-26  Ian Bolton  <ian.bolton@arm.com>

	* testsuite/gcc.dg/20100906-1.c: Use -fno-short-enums
	option for "target arm_eabi".


    subst_low_luid in try_combine.  */

Index: gcc/testsuite/gcc.dg/20100906-1.c
===================================================================
--- gcc/testsuite/gcc.dg/20100906-1.c   (revision 168543)
+++ gcc/testsuite/gcc.dg/20100906-1.c   (working copy)
@@ -1,5 +1,6 @@
 /* { dg-do run } */
 /* { dg-options "-O2" } */
+/* { dg-options "-O2 -fno-short-enums -Wl,--no-enum-size-warning" {target
arm_eabi} } */
 
 /* This testcase got misoptimized by combine due to a wrong setting of