Patchwork [testsuite] Fix another short-enums testsuite error for ARM

login
register
mail settings
Submitter Ian Bolton
Date Jan. 26, 2011, 6:18 p.m.
Message ID <000001cbbd85$6c6ec590$454c50b0$@bolton@arm.com>
Download mbox | patch
Permalink /patch/80537/
State New
Headers show

Comments

Ian Bolton - Jan. 26, 2011, 6:18 p.m.
> From: Joseph Myers [mailto:joseph@codesourcery.com]
> On Tue, 18 Jan 2011, Ian Bolton wrote:
> 
> > > The normal approach for the warning would be to pass
> > > -Wl,--no-enum-size-warning on ARM eabi targets (or at least, that's
> the
> > > approach for tests passing -fshort-enums explicitly).
> > >
> >
> > Thanks for the input, Joseph.
> >
> > I've updated the test to reflect this.  Assuming that other targets
> can
> > handle that linker option too, it should be good to go.  If not, I
> will
> > probably need to limit this patch to ARM eabi targets only.
> 
> This option is specific to ARM EABI targets.
> 

Thanks for the clarification.

In that case, I am just going to fix up ARM.

Is the following patch OK for trunk?


2011-01-26  Ian Bolton  <ian.bolton@arm.com>

	* testsuite/gcc.dg/20100906-1.c: Use -fno-short-enums
	option for "target arm_eabi".


    subst_low_luid in try_combine.  */
Ian Bolton - Feb. 18, 2011, 10:56 a.m.
> Is the following patch OK for trunk?
> 
> 
> 2011-01-26  Ian Bolton  <ian.bolton@arm.com>
> 
> 	* testsuite/gcc.dg/20100906-1.c: Use -fno-short-enums
> 	option for "target arm_eabi".
> 
> 
> Index: gcc/testsuite/gcc.dg/20100906-1.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/20100906-1.c   (revision 168543)
> +++ gcc/testsuite/gcc.dg/20100906-1.c   (working copy)
> @@ -1,5 +1,6 @@
>  /* { dg-do run } */
>  /* { dg-options "-O2" } */
> +/* { dg-options "-O2 -fno-short-enums -Wl,--no-enum-size-warning"
> {target
> arm_eabi} } */
> 
>  /* This testcase got misoptimized by combine due to a wrong setting of
>     subst_low_luid in try_combine.  */

PING.
Richard Earnshaw - March 30, 2011, 3:03 p.m.
On Fri, 2011-02-18 at 10:56 +0000, Ian Bolton wrote:
> > Is the following patch OK for trunk?
> > 
> > 
> > 2011-01-26  Ian Bolton  <ian.bolton@arm.com>
> > 
> > 	* testsuite/gcc.dg/20100906-1.c: Use -fno-short-enums
> > 	option for "target arm_eabi".
> > 
> > 
> > Index: gcc/testsuite/gcc.dg/20100906-1.c
> > ===================================================================
> > --- gcc/testsuite/gcc.dg/20100906-1.c   (revision 168543)
> > +++ gcc/testsuite/gcc.dg/20100906-1.c   (working copy)
> > @@ -1,5 +1,6 @@
> >  /* { dg-do run } */
> >  /* { dg-options "-O2" } */
> > +/* { dg-options "-O2 -fno-short-enums -Wl,--no-enum-size-warning"
> > {target
> > arm_eabi} } */
> > 
> >  /* This testcase got misoptimized by combine due to a wrong setting of
> >     subst_low_luid in try_combine.  */
> 
> PING.
> 
> 

OK.

R.

Patch

Index: gcc/testsuite/gcc.dg/20100906-1.c
===================================================================
--- gcc/testsuite/gcc.dg/20100906-1.c   (revision 168543)
+++ gcc/testsuite/gcc.dg/20100906-1.c   (working copy)
@@ -1,5 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-options "-O2" } */
+/* { dg-options "-O2 -fno-short-enums -Wl,--no-enum-size-warning" {target
arm_eabi} } */
 
 /* This testcase got misoptimized by combine due to a wrong setting of