| Message ID | 20170823234414.3326-1-andrew.smirnov@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
Hello, On Wed, 23 Aug 2017 16:44:14 -0700, Andrey Smirnov wrote: > Do not mark .service and .socket files executable, otherwise systemd > will give us a warning about it. > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > --- > package/rpcbind/rpcbind.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to master, thanks. However, we have a few other packages also installing .service as 755: package/minidlna/minidlna.mk: $(INSTALL) -D -m 0755 package/minidlna/minidlnad.service \ package/nss-pam-ldapd/nss-pam-ldapd.mk: $(INSTALL) -m 755 -D package/nss-pam-ldapd/nslcd.service \ package/transmission/transmission.mk: $(INSTALL) -D -m 0755 $(@D)/daemon/transmission-daemon.service \ Perhaps we want to fix those as well ? Thanks! Thomas
On Thu, Aug 24, 2017 at 2:13 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Hello, > > On Wed, 23 Aug 2017 16:44:14 -0700, Andrey Smirnov wrote: >> Do not mark .service and .socket files executable, otherwise systemd >> will give us a warning about it. >> >> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> >> --- >> package/rpcbind/rpcbind.mk | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > Applied to master, thanks. However, we have a few other packages also > installing .service as 755: > > package/minidlna/minidlna.mk: $(INSTALL) -D -m 0755 package/minidlna/minidlnad.service \ > package/nss-pam-ldapd/nss-pam-ldapd.mk: $(INSTALL) -m 755 -D package/nss-pam-ldapd/nslcd.service \ > package/transmission/transmission.mk: $(INSTALL) -D -m 0755 $(@D)/daemon/transmission-daemon.service \ > > Perhaps we want to fix those as well ? Yeah, makes sense. I wasn't using any of those packages so I missed them. I'll send follow up patches shortly. Thanks, Andrey Smirnov
diff --git a/package/rpcbind/rpcbind.mk b/package/rpcbind/rpcbind.mk index cf2e81dbbf..5c216afc93 100644 --- a/package/rpcbind/rpcbind.mk +++ b/package/rpcbind/rpcbind.mk @@ -22,9 +22,9 @@ RPCBIND_CONF_OPTS += --with-systemdsystemunitdir=no endif define RPCBIND_INSTALL_INIT_SYSTEMD - $(INSTALL) -m 0755 -D package/rpcbind/rpcbind.service \ + $(INSTALL) -m 0644 -D package/rpcbind/rpcbind.service \ $(TARGET_DIR)/usr/lib/systemd/system/rpcbind.service - $(INSTALL) -m 0755 -D package/rpcbind/rpcbind.socket \ + $(INSTALL) -m 0644 -D package/rpcbind/rpcbind.socket \ $(TARGET_DIR)/usr/lib/systemd/system/rpcbind.socket mkdir -p $(TARGET_DIR)/etc/systemd/system/sockets.target.wants ln -fs ../../../../usr/lib/systemd/system/rpcbind.socket \
Do not mark .service and .socket files executable, otherwise systemd will give us a warning about it. Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> --- package/rpcbind/rpcbind.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)