From patchwork Wed Jan 26 16:27:43 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Gordeev X-Patchwork-Id: 80520 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from bilbo.ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id E4BC91008CB for ; Thu, 27 Jan 2011 03:28:06 +1100 (EST) Received: from mail.lvk.cs.msu.su (gate.lvk.cs.msu.su [158.250.17.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mail.lvk.cs.msu.su", Issuer "CA" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 97C0DB7140 for ; Thu, 27 Jan 2011 03:27:55 +1100 (EST) Received: from mail.lvk.cs.msu.su (localhost [127.0.0.1]) by mail.lvk.cs.msu.su (Postfix) with ESMTP id 552E432A0; Wed, 26 Jan 2011 19:27:49 +0300 (MSK) X-Spam-ASN: X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on mailsrv.lvknet X-Spam-Level: X-Spam-Status: No, score=-4.4 required=7.0 tests=ALL_TRUSTED=-1.8, BAYES_00=-2.599 autolearn=ham version=3.2.5 Received: from desktopvm.lvknet (desktopvm.lvknet [192.168.132.1]) by mail.lvk.cs.msu.su (Postfix) with ESMTPSA id 4567D29EF; Wed, 26 Jan 2011 19:27:49 +0300 (MSK) Date: Wed, 26 Jan 2011 19:27:43 +0300 From: Alexander Gordeev To: tmarri@apm.com Subject: Re: [PATCH V8 04/10] USB/ppc4xx: Add Synopsys DWC OTG HCD function Message-ID: <20110126192743.646af6d2@desktopvm.lvknet> In-Reply-To: <1295477855-14775-1-git-send-email-tmarri@apm.com> References: <1295477855-14775-1-git-send-email-tmarri@apm.com> Organization: LVK X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; i486-pc-linux-gnu) Mime-Version: 1.0 X-AV-Checked: ClamAV using ClamSMTP Cc: greg@kroah.com, linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Fushen Chen , Mark Miesfeld X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Hi, Please consider squashing this little patch into yours. The driver currently prints 0x00000000 as the register base. This patch will fix that. commit 2f850fe637101be287f116a37282b6b1a09e6a98 Author: Alexander Gordeev Date: Mon Nov 29 15:15:25 2010 +0300 dwc_otg: set usb hcd resource address and length Signed-off-by: Alexander Gordeev diff --git a/drivers/usb/dwc_otg/dwc_otg_hcd.c b/drivers/usb/dwc_otg/dwc_otg_hcd.c index 240ab0b..e420a8d 100644 --- a/drivers/usb/dwc_otg/dwc_otg_hcd.c +++ b/drivers/usb/dwc_otg/dwc_otg_hcd.c @@ -1269,6 +1269,8 @@ int __devinit dwc_otg_hcd_init(struct device *_dev, } dev_set_drvdata(_dev, dwc_otg_device); hcd->regs = otg_dev->base; + hcd->rsrc_start = otg_dev->phys_addr; + hcd->rsrc_len = otg_dev->base_len; hcd->self.otg_port = 1; /* Initialize the DWC OTG HCD. */