| Message ID | 20170823205906.20933-6-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Accepted |
| Commit | bb939d7a6da499dce7fa44aac60a2055f47698a4 |
| Delegated to: | Tom Rini |
| Headers | show |
On Wed, Aug 23, 2017 at 10:59:03PM +0200, Thomas Petazzoni wrote: > CONFIG_SYS_MAXARGS contains the maximum number of arguments accepted > by U-Boot commands. Since the vast majority of the platforms define it > to 16, it makes sense to have a default definition to 16, which will > allow to remove this definition from a significant number of > platforms. > > It will allow to remove the default definition from 216 platform .h > files, leaving only 56 platforms with non-default values (15, 24, 32, > 48, 64, 96, 128 or 256). > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Reviewed-by: Tom Rini <trini@konsulko.com>
On Wed, Aug 23, 2017 at 10:59:03PM +0200, Thomas Petazzoni wrote: > CONFIG_SYS_MAXARGS contains the maximum number of arguments accepted > by U-Boot commands. Since the vast majority of the platforms define it > to 16, it makes sense to have a default definition to 16, which will > allow to remove this definition from a significant number of > platforms. > > It will allow to remove the default definition from 216 platform .h > files, leaving only 56 platforms with non-default values (15, 24, 32, > 48, 64, 96, 128 or 256). > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Reviewed-by: Tom Rini <trini@konsulko.com> Applied to u-boot/master, thanks!
diff --git a/include/config_fallbacks.h b/include/config_fallbacks.h index 09fcee4..85725bd 100644 --- a/include/config_fallbacks.h +++ b/include/config_fallbacks.h @@ -84,6 +84,10 @@ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16) #endif +#ifndef CONFIG_SYS_MAXARGS +#define CONFIG_SYS_MAXARGS 16 +#endif + #ifndef CONFIG_FIT_SIGNATURE #define CONFIG_IMAGE_FORMAT_LEGACY #endif
CONFIG_SYS_MAXARGS contains the maximum number of arguments accepted by U-Boot commands. Since the vast majority of the platforms define it to 16, it makes sense to have a default definition to 16, which will allow to remove this definition from a significant number of platforms. It will allow to remove the default definition from 216 platform .h files, leaving only 56 platforms with non-default values (15, 24, 32, 48, 64, 96, 128 or 256). Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- include/config_fallbacks.h | 4 ++++ 1 file changed, 4 insertions(+)