Patchwork [v3] New trace-event backend: stderr

login
register
mail settings
Submitter Fabien Chouteau
Date Jan. 26, 2011, 1:37 p.m.
Message ID <3fbb9d0a1ef25990d8914170cf04e5851424565a.1296048919.git.chouteau@adacore.com>
Download mbox | patch
Permalink /patch/80505/
State New
Headers show

Comments

Fabien Chouteau - Jan. 26, 2011, 1:37 p.m.
This backend sends trace events to standard error output during the emulation.

Also add a "--list-backends" option to tracetool, so configure script can
display the list of available backends.

Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
---
 configure         |    3 +-
 docs/tracing.txt  |    5 ++++
 scripts/tracetool |   61 ++++++++++++++++++++++++++++++++++++++++++++++++++--
 3 files changed, 65 insertions(+), 4 deletions(-)
Stefan Hajnoczi - Jan. 26, 2011, 2:18 p.m.
On Wed, Jan 26, 2011 at 1:37 PM, Fabien Chouteau <chouteau@adacore.com> wrote:
> This backend sends trace events to standard error output during the emulation.
>
> Also add a "--list-backends" option to tracetool, so configure script can
> display the list of available backends.
>
> Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
> ---
>  configure         |    3 +-
>  docs/tracing.txt  |    5 ++++
>  scripts/tracetool |   61 ++++++++++++++++++++++++++++++++++++++++++++++++++--
>  3 files changed, 65 insertions(+), 4 deletions(-)

Acked-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Peter Maydell - Jan. 26, 2011, 3:02 p.m.
On 26 January 2011 13:37, Fabien Chouteau <chouteau@adacore.com> wrote:

> +echo "                           Available backends:" $($source_path/scripts/tracetool --list-backends)

Not enough quoting -- this will break if $source_path has a space in it.
Try:

echo "                           Available backends:
$("$source_path"/scripts/tracetool --list-backends)"

-- PMM

Patch

diff --git a/configure b/configure
index 210670c..06d824a 100755
--- a/configure
+++ b/configure
@@ -907,7 +907,8 @@  echo "  --enable-docs            enable documentation build"
 echo "  --disable-docs           disable documentation build"
 echo "  --disable-vhost-net      disable vhost-net acceleration support"
 echo "  --enable-vhost-net       enable vhost-net acceleration support"
-echo "  --enable-trace-backend=B Trace backend nop simple ust dtrace"
+echo "  --enable-trace-backend=B Set trace backend"
+echo "                           Available backends:" $($source_path/scripts/tracetool --list-backends)
 echo "  --with-trace-file=NAME   Full PATH,NAME of file to store traces"
 echo "                           Default:trace-<pid>"
 echo "  --disable-spice          disable spice"
diff --git a/docs/tracing.txt b/docs/tracing.txt
index 963c504..21183f9 100644
--- a/docs/tracing.txt
+++ b/docs/tracing.txt
@@ -133,6 +133,11 @@  source tree.  It may not be as powerful as platform-specific or third-party
 trace backends but it is portable.  This is the recommended trace backend
 unless you have specific needs for more advanced backends.
 
+=== Stderr ===
+
+The "stderr" backend sends trace events directly to standard error output
+during emulation.
+
 ==== Monitor commands ====
 
 * info trace
diff --git a/scripts/tracetool b/scripts/tracetool
index fce491c..a80de70 100755
--- a/scripts/tracetool
+++ b/scripts/tracetool
@@ -13,12 +13,13 @@  set -f
 usage()
 {
     cat >&2 <<EOF
-usage: $0 [--nop | --simple | --ust] [-h | -c]
+usage: $0 [--nop | --simple | --stderr | --ust | --dtrace] [-h | -c]
 Generate tracing code for a file on stdin.
 
 Backends:
   --nop     Tracing disabled
   --simple  Simple built-in backend
+  --stderr  Stderr built-in backend
   --ust     LTTng User Space Tracing backend
   --dtrace  DTrace/SystemTAP backend
 
@@ -236,6 +237,56 @@  linetoc_end_simple()
 EOF
 }
 
+#STDERR
+linetoh_begin_stderr()
+{
+    cat <<EOF
+#include <stdio.h>
+EOF
+}
+
+linetoh_stderr()
+{
+    local name args argnames argc fmt
+    name=$(get_name "$1")
+    args=$(get_args "$1")
+    argnames=$(get_argnames "$1" ",")
+    argc=$(get_argc "$1")
+    fmt=$(get_fmt "$1")
+
+    if [ "$argc" -gt 0 ]; then
+        argnames=", $argnames"
+    fi
+
+    cat <<EOF
+static inline void trace_$name($args)
+{
+    fprintf(stderr, "$name $fmt\n" $argnames);
+}
+EOF
+}
+
+linetoh_end_stderr()
+{
+return
+}
+
+linetoc_begin_stderr()
+{
+return
+}
+
+linetoc_stderr()
+{
+return
+}
+
+linetoc_end_stderr()
+{
+return
+}
+#END OF STDERR
+
 # Clean up after UST headers which pollute the namespace
 ust_clean_namespace() {
     cat <<EOF
@@ -542,11 +593,10 @@  binary=
 targettype=
 targetarch=
 
-
 until [ -z "$1" ]
 do
   case "$1" in
-    "--nop" | "--simple" | "--ust" | "--dtrace") backend="${1#--}" ;;
+    "--nop" | "--simple" | "--stderr" | "--ust" | "--dtrace") backend="${1#--}" ;;
 
     "--binary") shift ; binary="$1" ;;
     "--target-arch") shift ; targetarch="$1" ;;
@@ -557,6 +607,11 @@  do
 
     "--check-backend") exit 0 ;; # used by ./configure to test for backend
 
+    "--list-backends") # used by ./configure to list available backends
+          echo "nop simple stderr ust dtrace"
+          exit 0
+          ;;
+
     *)
       usage;;
   esac