From patchwork Tue Aug 22 22:24:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 804672 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="T3r1l50n"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xcQ9N1JHYz9s9Y for ; Wed, 23 Aug 2017 08:25:12 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752845AbdHVWY7 (ORCPT ); Tue, 22 Aug 2017 18:24:59 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:33101 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752815AbdHVWYz (ORCPT ); Tue, 22 Aug 2017 18:24:55 -0400 Received: by mail-qk0-f193.google.com with SMTP id s79so77852qki.0; Tue, 22 Aug 2017 15:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=AiQsp+sf9AvrdxjyuSIIh13Hn6ZK2m2pe/6A2ofrfP0=; b=T3r1l50noRLfbjst2hA39Ln2Q/ydx26OQ5SEcUSLtOUSkHNFXLoDLJN97+15eArWVP u26ocNZzQy4jZ5XMQ0v1kbj1TY40gluaJbsT/UNXpBUFlRnwyYwLSiV9CS15XL/zqQh/ jg8C0SNhdOonf028PLgUWD3tGkyBVqeQnIlnJpJgV4nWEYAyLg2yyu1VARfZnu9DDWyS pmbfSbKP7HaI1LgIZ+EN651LnmapSZkREPL3h+io0HgTM8ahHzfRoyFpve9NPPW+cXlI V3XHmBVqnzW98+5NLu+E+c7W23FzOygr47h/5xse5eZgGlki5pdHknjRKUOYxoYwz0sU OphQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=AiQsp+sf9AvrdxjyuSIIh13Hn6ZK2m2pe/6A2ofrfP0=; b=FZUko8ayvpOnjjU7l5LnPhCSrNlZMFpworfUb7B/398C219jVGfdjZJVfO5oqUG0BN pGNsSIK/OH68e5d1tTSP7wd1C+wXTo52u1wcn/NeAV5iI9/bBKuN2m6LqURhXgH5Fj9E sGNltmp78yIdJR1i02mvPVJdqXZG4ngUwQbpm60esQy62dRYik9XLDw9nNej+/3S9K3A vCyBCFNYgm+Qh0NLc0shkz5q1KAO1Lnfk5K+6YH0A8+jTsUhpcQJxR9Ee8pxeXGIKpbj IrYR14YHFDcLNbQIFcqq96VKVwhMfUHCbxUtpZvsg9U7ktTmVvmtZfcexphywZbcgz7p 1TOA== X-Gm-Message-State: AHYfb5iv3QmPmLrvrH9CpATbSi2B16WMSp4a14bcEainC+ycdvrSTrRY hXeayE/guL4S4Ab4Rhg= X-Received: by 10.55.23.8 with SMTP id i8mr929207qkh.279.1503440694746; Tue, 22 Aug 2017 15:24:54 -0700 (PDT) Received: from fainelli-desktop.broadcom.com ([192.19.255.250]) by smtp.gmail.com with ESMTPSA id g57sm23411qtc.84.2017.08.22.15.24.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Aug 2017 15:24:53 -0700 (PDT) From: Florian Fainelli To: netdev@vger.kernel.org Cc: junote@outlook.com, madalin.bucur@nxp.com, Florian Fainelli , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net] fsl/man: Inherit parent device and of_node Date: Tue, 22 Aug 2017 15:24:47 -0700 Message-Id: <20170822222447.16754-1-f.fainelli@gmail.com> X-Mailer: git-send-email 2.9.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Junote Cai reported that he was not able to get a DSA setup involving the Freescale DPAA/FMAN driver to work and narrowed it down to of_find_net_device_by_node(). This function requires the network device's device reference to be correctly set which is the case here, though we have lost any device_node association there. The problem is that dpaa_eth_add_device() allocates a "dpaa-ethernet" platform device, and later on dpaa_eth_probe() is called but SET_NETDEV_DEV() won't be propagating &pdev->dev.of_node properly. Fix this by inherenting both the parent device and the of_node when dpaa_eth_add_device() creates the platform device. Fixes: 3933961682a3 ("fsl/fman: Add FMan MAC driver") Signed-off-by: Florian Fainelli --- drivers/net/ethernet/freescale/fman/mac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c index 6e67d22fd0d5..1c7da16ad0ff 100644 --- a/drivers/net/ethernet/freescale/fman/mac.c +++ b/drivers/net/ethernet/freescale/fman/mac.c @@ -623,6 +623,8 @@ static struct platform_device *dpaa_eth_add_device(int fman_id, goto no_mem; } + pdev->dev.of_node = node; + pdev->dev.parent = priv->dev; set_dma_ops(&pdev->dev, get_dma_ops(priv->dev)); ret = platform_device_add_data(pdev, &data, sizeof(data));