Message ID | 1296033518.2899.41.camel@edumazet-laptop |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Wed, 26 Jan 2011 10:18:38 +0100 > [PATCH] net: add kmemcheck annotation in __alloc_skb() > > pskb_expand_head() triggers a kmemcheck warning when copy of > skb_shared_info is done in pskb_expand_head() > > This is because destructor_arg field is not necessarily initialized at > this point. Add kmemcheck_annotate_variable() call in __alloc_skb() to > instruct kmemcheck this is a normal situation. > > Resolves bugzilla.kernel.org 27212 > > Reference: https://bugzilla.kernel.org/show_bug.cgi?id=27212 > Reported-by: Christian Casteyde <casteyde.christian@free.fr> > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> > CC: Andrew Morton <akpm@linux-foundation.org> Applied, thanks Eric. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/skbuff.c b/net/core/skbuff.c index d31bb36..1762e97 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -210,6 +210,7 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t gfp_mask, shinfo = skb_shinfo(skb); memset(shinfo, 0, offsetof(struct skb_shared_info, dataref)); atomic_set(&shinfo->dataref, 1); + kmemcheck_annotate_variable(shinfo->destructor_arg); if (fclone) { struct sk_buff *child = skb + 1;