diff mbox

[U-Boot,04/14] nvme: Fix endianness assignment to prp2 in nvme_identify()

Message ID 1503414919-30820-5-git-send-email-bmeng.cn@gmail.com
State Accepted
Commit 3e18562961933c7772b7e91ba6fc1e908b453d93
Delegated to: Tom Rini
Headers show

Commit Message

Bin Meng Aug. 22, 2017, 3:15 p.m. UTC
So far this is not causing any issue due to NVMe and x86 are using
the same endianness, but for correctness, it should be fixed.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 drivers/nvme/nvme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini Aug. 29, 2017, 2:55 a.m. UTC | #1
On Tue, Aug 22, 2017 at 08:15:09AM -0700, Bin Meng wrote:

> So far this is not causing any issue due to NVMe and x86 are using
> the same endianness, but for correctness, it should be fixed.
> 
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c
index 5d39cab..2ae947c 100644
--- a/drivers/nvme/nvme.c
+++ b/drivers/nvme/nvme.c
@@ -431,7 +431,7 @@  int nvme_identify(struct nvme_dev *dev, unsigned nsid,
 		c.identify.prp2 = 0;
 	} else {
 		dma_addr += (page_size - offset);
-		c.identify.prp2 = dma_addr;
+		c.identify.prp2 = cpu_to_le64(dma_addr);
 	}
 
 	c.identify.cns = cpu_to_le32(cns);