Patchwork [U-Boot,2/5] powerpc/85xx: Remove unnecessary polling loop from DDR init

login
register
mail settings
Submitter Kumar Gala
Date Jan. 26, 2011, 6:22 a.m.
Message ID <1296022938-19899-2-git-send-email-galak@kernel.crashing.org>
Download mbox | patch
Permalink /patch/80449/
State Accepted
Commit e1df0de4932e7296896709282feda2da3bd68a5e
Delegated to: Kumar Gala
Headers show

Comments

Kumar Gala - Jan. 26, 2011, 6:22 a.m.
From: York Sun <yorksun@freescale.com>

This polling loop is not required normally, unless specifically stated in
workaround.

Signed-off-by: York Sun <yorksun@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
 arch/powerpc/cpu/mpc85xx/ddr-gen3.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Kumar Gala - Feb. 1, 2011, 4:39 a.m.
On Jan 26, 2011, at 12:22 AM, Kumar Gala wrote:

> From: York Sun <yorksun@freescale.com>
> 
> This polling loop is not required normally, unless specifically stated in
> workaround.
> 
> Signed-off-by: York Sun <yorksun@freescale.com>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> arch/powerpc/cpu/mpc85xx/ddr-gen3.c |    2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)

applied to 85xx

- k

Patch

diff --git a/arch/powerpc/cpu/mpc85xx/ddr-gen3.c b/arch/powerpc/cpu/mpc85xx/ddr-gen3.c
index fa7e09f..b9502f7 100644
--- a/arch/powerpc/cpu/mpc85xx/ddr-gen3.c
+++ b/arch/powerpc/cpu/mpc85xx/ddr-gen3.c
@@ -199,8 +199,6 @@  void fsl_ddr_set_memctl_regs(const fsl_ddr_cfg_regs_t *regs,
 	temp_sdram_cfg = in_be32(&ddr->sdram_cfg) & ~SDRAM_CFG_BI;
 	out_be32(&ddr->sdram_cfg, temp_sdram_cfg | SDRAM_CFG_MEM_EN);
 	asm volatile("sync;isync");
-	while (!(in_be32(&ddr->debug[1]) & 0x2))
-		;
 
 	/* Poll DDR_SDRAM_CFG_2[D_INIT] bit until auto-data init is done.  */
 	while (in_be32(&ddr->sdram_cfg_2) & 0x10) {