Patchwork [U-Boot,1/1] lcd: align fb writing address for horizontal display offset

login
register
mail settings
Submitter Liu Ying-B17645
Date Jan. 26, 2011, 1:52 a.m.
Message ID <D62B998DB8EFB547B4D75C9E57658A7F0BED86@039-SN1MPN1-006.039d.mgd.msft.net>
Download mbox | patch
Permalink /patch/80438/
State Not Applicable
Headers show

Comments

Liu Ying-B17645 - Jan. 26, 2011, 1:52 a.m.
Hello,

I sent the following patch for view about 2 weeks ago and haven't got any comment till now.
Could anyone help to give comments? Thanks.


Best Regards,
Liu Ying
-----Original Message-----
From: Liu Ying-B17645 
Sent: Tuesday, January 11, 2011 3:30 PM
To: u-boot@lists.denx.de
Cc: Liu Ying-B17645
Subject: [U-Boot][PATCH 1/1] lcd: align fb writing address for horizontal display offset

CONFIG_SPLASH_SCREEN_ALIGN makes uboot support display offset for splashimage. The framebuffer writing address should be calculated according to different kinds of framebuffer pixel format, i.e., bits per pixel value.

Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
---
 common/lcd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

--
1.6.3.3
Wolfgang Denk - Jan. 26, 2011, 7:40 a.m.
Dear Liu Ying-B17645,

In message <D62B998DB8EFB547B4D75C9E57658A7F0BED86@039-SN1MPN1-006.039d.mgd.msft.net> you wrote:
> Hello,
> 
> I sent the following patch for view about 2 weeks ago and haven't got any c=
> omment till now.
> Could anyone help to give comments? Thanks.

It would definitely help if you put the responsible custodian on Cc:

[Done now.]

Best regards,

Wolfgang Denk
Anatolij Gustschin - Jan. 26, 2011, 10:04 p.m.
Hello,

On Wed, 26 Jan 2011 01:52:33 +0000
Liu Ying-B17645 <B17645@freescale.com> wrote:

> Hello,
> 
> I sent the following patch for view about 2 weeks ago and haven't got any comment till now.
> Could anyone help to give comments? Thanks.

Thanks! Your patch is delegated to me and is currently under review,
please see [1]. Sorry it takes so long, I'm quite busy now, but I'll
have a look at it soon. Please put me on Cc: next time when
submitting video related patches, it should help.

Best regards,
Anatolij

[1] http://patchwork.ozlabs.org/patch/78285/

Patch

diff --git a/common/lcd.c b/common/lcd.c index d854c21..0555ab4 100644
--- a/common/lcd.c
+++ b/common/lcd.c
@@ -731,7 +731,7 @@  int lcd_display_bitmap(ulong bmp_image, int x, int y)
 
 	bmap = (uchar *)bmp + le32_to_cpu (bmp->header.data_offset);
 	fb   = (uchar *) (lcd_base +
-		(y + height - 1) * lcd_line_length + x);
+		(y + height - 1) * lcd_line_length + x * bpix / 8);
 
 	switch (bmp_bpix) {
 	case 1: /* pass through */