From patchwork Tue Aug 22 04:04:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Mendoza-Jonas X-Patchwork-Id: 804247 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xbxlW488Jz9t2S for ; Tue, 22 Aug 2017 14:04:39 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="JIrB2y/s"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="gUXRI8QQ"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3xbxlV6KqDzDqh9 for ; Tue, 22 Aug 2017 14:04:38 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="JIrB2y/s"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="gUXRI8QQ"; dkim-atps=neutral X-Original-To: petitboot@lists.ozlabs.org Delivered-To: petitboot@lists.ozlabs.org Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3xbxlM08WKzDqXp for ; Tue, 22 Aug 2017 14:04:30 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="JIrB2y/s"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="gUXRI8QQ"; dkim-atps=neutral Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id C7E7620D43; Tue, 22 Aug 2017 00:04:27 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute2.internal (MEProxy); Tue, 22 Aug 2017 00:04:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= mendozajonas.com; h=cc:date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=odau73 K14YLVQGxneScd6LE57jR5QvKtx6xh4grWUI4=; b=JIrB2y/sbPbN6oqr6weIxQ f6yKA2iBPi3n9jsNkeDAwZcFj3hGY7A4HZPpLHwfCbtu9gsw8V6N811uJwsNNkmv XZepm1fYhWN/WEm0c47A6N46fHqJvrrvoqspVBKRkj+mWljKcOUcA2ODBa1pgliT cdrRW1wqF7dnC/mewjx6VM7bEsivLWhO+uCA2JBNXipUpMeUxjoH9Ds7H6BNQ8Us F24zrYGZ336TrOht16noDPVcXOGj4Cvr0fEWsr4viia3I+bHg+uMu2m9udhMlpXS HULZTNl/AstfuobGGO1JWmpbId2MrfBJRkq7rLDqjT6QdUuJRe92dv07WPazTFnQ == DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=odau73 K14YLVQGxneScd6LE57jR5QvKtx6xh4grWUI4=; b=gUXRI8QQzG//cuEU5eurIE 0lNuX2tL6fgxoXRSiZ5O3bJMM4yOyMqGQCTG6wEFSBYsivFGzSlj270Nwl2+KiCY Q6LoyN4eNb3l21wCpoW4ZJIA/qfaNIRh/A0SpJjTOLAczi/WP7zV4/QKuGOFRcvj M7swcgIdWffcmpyBqne4VA1rP6vOcGyFb1If30wEdMd7lHXTEM5/JS5LM9hQgmz/ iH6hyNHpqi6L0cKj7iKB4IeCkaYniWDwuJPuUXCxl+Gu2xkbCSeqIE4QIcgXuqpr /rpp8yrR/bvEETnNzXzYZ6cC6oM5aseKs3nQp1FV11HaQB9KHt8h3v9RUn+QJJ0g == X-ME-Sender: X-Sasl-enc: xy+3LOTslxYXT60t5LakOFyaV3BPPByzF0UJiBDL1dC2 1503374667 Received: from v4.ozlabs.ibm.com (unknown [122.99.82.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 9DB89249CD; Tue, 22 Aug 2017 00:04:26 -0400 (EDT) From: Samuel Mendoza-Jonas To: petitboot@lists.ozlabs.org Subject: [PATCH 1/2] discover/ipmi: Open devnode with O_CLOEXEC Date: Tue, 22 Aug 2017 14:04:13 +1000 Message-Id: <20170822040414.11485-1-sam@mendozajonas.com> X-Mailer: git-send-email 2.14.0 X-BeenThere: petitboot@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Petitboot bootloader development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samuel Mendoza-Jonas MIME-Version: 1.0 Errors-To: petitboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Petitboot" The IPMI device node is kept open for the life of the platform - include the O_CLOEXEC flag so it is not kept open for child processes. Signed-off-by: Samuel Mendoza-Jonas --- discover/ipmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/discover/ipmi.c b/discover/ipmi.c index 2aaf114..d652e9f 100644 --- a/discover/ipmi.c +++ b/discover/ipmi.c @@ -201,7 +201,7 @@ struct ipmi *ipmi_open(void *ctx) struct ipmi *ipmi; int fd; - fd = open(ipmi_devnode, O_RDWR); + fd = open(ipmi_devnode, O_RDWR | O_CLOEXEC); if (fd < 0) { pb_log("IPMI: can't open IPMI device %s: %m\n", ipmi_devnode); return NULL;