From patchwork Tue Jan 25 17:18:08 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 80391 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id D3C821007D1 for ; Wed, 26 Jan 2011 04:20:17 +1100 (EST) Received: from localhost ([127.0.0.1]:42104 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PhmYw-0003SO-Fr for incoming@patchwork.ozlabs.org; Tue, 25 Jan 2011 12:20:14 -0500 Received: from [140.186.70.92] (port=42509 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PhmXM-0002pi-Ll for qemu-devel@nongnu.org; Tue, 25 Jan 2011 12:18:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PhmXL-0005D7-Fs for qemu-devel@nongnu.org; Tue, 25 Jan 2011 12:18:36 -0500 Received: from eu1sys200aog104.obsmtp.com ([207.126.144.117]:46365) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PhmXL-0005CL-8L for qemu-devel@nongnu.org; Tue, 25 Jan 2011 12:18:35 -0500 Received: from source ([167.4.1.35]) (using TLSv1) by eu1sys200aob104.postini.com ([207.126.147.11]) with SMTP ID DSNKTT8F5+qQ5+hyu7q/Ffxyswm5zQe2wNBG@postini.com; Tue, 25 Jan 2011 17:18:35 UTC Received: from zeta.dmz-us.st.com (ns4.st.com [167.4.16.71]) by beta.dmz-us.st.com (STMicroelectronics) with ESMTP id BA65511C for ; Tue, 25 Jan 2011 17:18:30 +0000 (GMT) Received: from Webmail-eu.st.com (safex1hubcas5.st.com [10.75.90.71]) by zeta.dmz-us.st.com (STMicroelectronics) with ESMTP id 11D092AF for ; Tue, 25 Jan 2011 17:18:30 +0000 (GMT) Received: from [164.129.122.40] (164.129.122.40) by webmail-eu.st.com (10.75.90.13) with Microsoft SMTP Server (TLS) id 8.2.234.1; Tue, 25 Jan 2011 18:18:08 +0100 Message-ID: <4D3F05D0.9070906@st.com> Date: Tue, 25 Jan 2011 18:18:08 +0100 From: Christophe Lyon User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.13) Gecko/20101207 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: "qemu-devel@nongnu.org" X-Enigmail-Version: 1.1.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: [Qemu-devel] [PATCH] target-arm: Fix Neon vsra instructions. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This patch fixes the errors reported by my tests in VSRA. Signed-off-by: Christophe Lyon Reviewed-by: Peter Maydell --- target-arm/translate.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 7cb48c0..4cf2ecd 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -4697,7 +4697,7 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn) } if (op == 1 || op == 3) { /* Accumulate. */ - neon_load_reg64(cpu_V0, rd + pass); + neon_load_reg64(cpu_V1, rd + pass); tcg_gen_add_i64(cpu_V0, cpu_V0, cpu_V1); } else if (op == 4 || (op == 5 && u)) { /* Insert */ @@ -4761,7 +4761,7 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn) if (op == 1 || op == 3) { /* Accumulate. */ tmp2 = neon_load_reg(rd, pass); - gen_neon_add(size, tmp2, tmp); + gen_neon_add(size, tmp, tmp2); dead_tmp(tmp2); } else if (op == 4 || (op == 5 && u)) { /* Insert */