Patchwork [Cygwin] Enable BID routines in libgcc

login
register
mail settings
Submitter JonY
Date Jan. 25, 2011, 4:16 p.m.
Message ID <4D3EF76F.7090408@users.sourceforge.net>
Download mbox | patch
Permalink /patch/80386/
State New
Headers show

Comments

JonY - Jan. 25, 2011, 4:16 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I noticed cygwin has dfp enabled in dfp.m4, but no such associated
symbols in libgcc. t-dfprules seems to be missing in the makefile fragments.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (MingW32)

iEYEARECAAYFAk0+924ACgkQp56AKe10wHejegCfSjgzUEj7N3Qx4GzRmMmo4oqO
RM0AnRuMe8gfyALPImsGtdwR/ClrCL4W
=onKp
-----END PGP SIGNATURE-----
JonY - Jan. 26, 2011, 1:20 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 1/26/2011 09:44, Dave Korn wrote:
> On 25/01/2011 16:16, JonY wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Hi,
>>
>> I noticed cygwin has dfp enabled in dfp.m4, but no such associated
>> symbols in libgcc. t-dfprules seems to be missing in the makefile fragments.
> 
>   Yeah, I wasn't going to add that until it was clearer when the next Cygwin
> release is due out.  If we check this in straight away, nobody will be able to
> build GCC without having to go to a CVS or snapshot release of cygwin, because
> they won't have fenv.h installed.
> 
>   Last time I checked(*), the plan was for 1.7.8 in January.  Both January and
> the time available for getting this in before 4.6 branches are ticking away
> quickly.  Could you perhaps ping the cygwin list for us and check that a
> release is indeed imminent?  If confirmed, this is OK.
> 
>     cheers,
>       DaveK

Hi,

I didn't know fenv.h was required, as I've only noticed the BID routines
missing when actually using the dfp features. Looks like there was more
to this.

Hey cygwin-devel, any plans for fenv.h release in 1.7.8?

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (MingW32)

iEYEARECAAYFAk0/duIACgkQp56AKe10wHetBQCfS93PACthLACiJNoA240m7Jtv
xJwAmgK8tVXmi2AbjB390CjmRNB+xQ4h
=BBk2
-----END PGP SIGNATURE-----
Dave Korn - Jan. 26, 2011, 1:44 a.m.
On 25/01/2011 16:16, JonY wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi,
> 
> I noticed cygwin has dfp enabled in dfp.m4, but no such associated
> symbols in libgcc. t-dfprules seems to be missing in the makefile fragments.

  Yeah, I wasn't going to add that until it was clearer when the next Cygwin
release is due out.  If we check this in straight away, nobody will be able to
build GCC without having to go to a CVS or snapshot release of cygwin, because
they won't have fenv.h installed.

  Last time I checked(*), the plan was for 1.7.8 in January.  Both January and
the time available for getting this in before 4.6 branches are ticking away
quickly.  Could you perhaps ping the cygwin list for us and check that a
release is indeed imminent?  If confirmed, this is OK.

    cheers,
      DaveK
Dave Korn - Jan. 26, 2011, 3:45 a.m.
On 26/01/2011 01:20, JonY wrote:
> On 1/26/2011 09:44, Dave Korn wrote:
>> On 25/01/2011 16:16, JonY wrote:

>>> I noticed cygwin has dfp enabled in dfp.m4, but no such associated
>>> symbols in libgcc. t-dfprules seems to be missing in the makefile fragments.
>>   Yeah, I wasn't going to add that until it was clearer when the next Cygwin
>> release is due out.  If we check this in straight away, nobody will be able to
>> build GCC without having to go to a CVS or snapshot release of cygwin, because
>> they won't have fenv.h installed.
>>
>>   Last time I checked(*), the plan was for 1.7.8 in January.  Both January and
>> the time available for getting this in before 4.6 branches are ticking away
>> quickly.  Could you perhaps ping the cygwin list for us and check that a
>> release is indeed imminent?  If confirmed, this is OK.
>>
> I didn't know fenv.h was required, as I've only noticed the BID routines
> missing when actually using the dfp features. Looks like there was more
> to this.
> 
> Hey cygwin-devel, any plans for fenv.h release in 1.7.8?

  We already have fenv.h in CVS, so it will be in 1.7.8 automatically.  That
means this isn't really a -devel thing, so redirecting:

  Hey, main list!  Are we still expecting 1.7.8 by the end of this month?

    cheers,
      DaveK
Dave Korn - Jan. 30, 2011, 8:37 p.m.
On 26/01/2011 01:20, JonY wrote:
> On 1/26/2011 09:44, Dave Korn wrote:

>> release is indeed imminent?  If confirmed, this is OK.

> Hey cygwin-devel, any plans for fenv.h release in 1.7.8?

  Following the discussions on the other lists, I have committed the patch for
you, with the following changelog:

gcc/ChangeLog:

2011-01-30  Jonathan Yong <jon_y@...

	* config.gcc (i[34567]86-*-pe | i[34567]86-*-cygwin*): Add t-dfprules
	to tmake_file.

  Committed revision 169418, after rerunning the dfp tests.

    cheers,
      DaveK
JonY - Jan. 31, 2011, 2:03 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 1/31/2011 04:37, Dave Korn wrote:
> On 26/01/2011 01:20, JonY wrote:
>> On 1/26/2011 09:44, Dave Korn wrote:
> 
>>> release is indeed imminent?  If confirmed, this is OK.
> 
>> Hey cygwin-devel, any plans for fenv.h release in 1.7.8?
> 
>   Following the discussions on the other lists, I have committed the patch for
> you, with the following changelog:
> 
> gcc/ChangeLog:
> 
> 2011-01-30  Jonathan Yong <jon_y@...
> 
> 	* config.gcc (i[34567]86-*-pe | i[34567]86-*-cygwin*): Add t-dfprules
> 	to tmake_file.
> 
>   Committed revision 169418, after rerunning the dfp tests.
> 
>     cheers,
>       DaveK
> 

Thanks.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (MingW32)

iEYEARECAAYFAk1GGFUACgkQp56AKe10wHe8ogCgkmCnwH/L0YDnS8xdjeevul0B
C+8AoIAMEcQq+aoM6jmQwLXbMYZTsf5F
=//rW
-----END PGP SIGNATURE-----

Patch

Index: gcc/config.gcc
===================================================================
--- gcc/config.gcc	(revision 169143)
+++ gcc/config.gcc	(working copy)
@@ -1424,7 +1424,7 @@ 
 	else
 		tmake_eh_file="i386/t-sjlj-eh"
 	fi
-	tmake_file="${tmake_file} ${tmake_eh_file} i386/t-cygming i386/t-cygwin"
+	tmake_file="${tmake_file} ${tmake_eh_file} i386/t-cygming i386/t-cygwin t-dfprules"
 	target_gtfiles="\$(srcdir)/config/i386/winnt.c"
 	extra_options="${extra_options} i386/cygming.opt"
 	extra_objs="winnt.o winnt-stubs.o"