diff mbox

[U-Boot,1/2] net: nfs: Drop CONFIG_NFS_READ_SIZE

Message ID 1503283202-11909-1-git-send-email-trini@konsulko.com
State Accepted
Commit 0b1e58067202316680423a6aafa73a9828ee07cc
Delegated to: Joe Hershberger
Headers show

Commit Message

Tom Rini Aug. 21, 2017, 2:40 a.m. UTC 
In the general case, CONFIG_NFS_READ_SIZE is unchanged from the default
of 1024.  There are in fact no in-tree users that increase this size.
Adjust the comment to reflect what could be done in the future in
conjunction with CONFIG_IP_DEFRAG.

Cc: Joe Hershberger <joe.hershberger@ni.com>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
 net/nfs.h | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

Comments

Joe Hershberger Aug. 22, 2017, 7:01 p.m. UTC | #1 
On Sun, Aug 20, 2017 at 9:40 PM, Tom Rini <trini@konsulko.com> wrote:
> In the general case, CONFIG_NFS_READ_SIZE is unchanged from the default
> of 1024.  There are in fact no in-tree users that increase this size.
> Adjust the comment to reflect what could be done in the future in
> conjunction with CONFIG_IP_DEFRAG.
>
> Cc: Joe Hershberger <joe.hershberger@ni.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Joe Hershberger Sept. 7, 2017, 6:32 p.m. UTC | #2 
Hi Tom,

https://patchwork.ozlabs.org/patch/803831/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git

Thanks!
-Joe
diff mbox

Patch

diff --git a/net/nfs.h b/net/nfs.h
index 70a1a6d554be..1aa06e8fb90f 100644
--- a/net/nfs.h
+++ b/net/nfs.h
@@ -36,16 +36,13 @@ 
 #define NFSERR_ISDIR    21
 #define NFSERR_INVAL    22
 
-/* Block size used for NFS read accesses.  A RPC reply packet (including  all
+/*
+ * Block size used for NFS read accesses.  A RPC reply packet (including  all
  * headers) must fit within a single Ethernet frame to avoid fragmentation.
- * However, if CONFIG_IP_DEFRAG is set, the config file may want to use a
- * bigger value. In any case, most NFS servers are optimized for a power of 2.
+ * However, if CONFIG_IP_DEFRAG is set, a bigger value could be used.  In any
+ * case, most NFS servers are optimized for a power of 2.
  */
-#ifdef CONFIG_NFS_READ_SIZE
-#define NFS_READ_SIZE CONFIG_NFS_READ_SIZE
-#else
-#define NFS_READ_SIZE 1024 /* biggest power of two that fits Ether frame */
-#endif
+#define NFS_READ_SIZE	1024	/* biggest power of two that fits Ether frame */
 
 /* Values for Accept State flag on RPC answers (See: rfc1831) */
 enum rpc_accept_stat {