diff mbox

tools lib bpf: improve warning

Message ID 20170820194814.13785-1-eric@regit.org
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Eric Leblond Aug. 20, 2017, 7:48 p.m. UTC 
Signed-off-by: Eric Leblond <eric@regit.org>
---
 tools/lib/bpf/libbpf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Daniel Borkmann Aug. 20, 2017, 9:45 p.m. UTC | #1 
On 08/20/2017 09:48 PM, Eric Leblond wrote:
> Signed-off-by: Eric Leblond <eric@regit.org>

Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Alexei Starovoitov Aug. 21, 2017, 12:44 a.m. UTC | #2 
On Sun, Aug 20, 2017 at 09:48:14PM +0200, Eric Leblond wrote:
> Signed-off-by: Eric Leblond <eric@regit.org>
> ---
>  tools/lib/bpf/libbpf.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 1cc3ea0ffdc3..35f6dfcdc565 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -879,7 +879,8 @@ bpf_object__create_maps(struct bpf_object *obj)
>  			size_t j;
>  			int err = *pfd;
>  
> -			pr_warning("failed to create map: %s\n",
> +			pr_warning("failed to create map (name: '%s'): %s\n",
> +				   obj->maps[i].name,
>  				   strerror(errno));

makes sense.
Acked-by: Alexei Starovoitov <ast@kernel.org>
Please cc Wang for future libbpf patches.
David Miller Aug. 21, 2017, 2:50 a.m. UTC | #3 
From: Eric Leblond <eric@regit.org>
Date: Sun, 20 Aug 2017 21:48:14 +0200

> Signed-off-by: Eric Leblond <eric@regit.org>

Applied, thanks.
diff mbox

Patch

diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index 1cc3ea0ffdc3..35f6dfcdc565 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -879,7 +879,8 @@  bpf_object__create_maps(struct bpf_object *obj)
 			size_t j;
 			int err = *pfd;
 
-			pr_warning("failed to create map: %s\n",
+			pr_warning("failed to create map (name: '%s'): %s\n",
+				   obj->maps[i].name,
 				   strerror(errno));
 			for (j = 0; j < i; j++)
 				zclose(obj->maps[j].fd);