Message ID | c1941b22-bdab-fccf-06e2-2f9fc50daec1@users.sourceforge.net |
---|---|
State | Accepted, archived |
Headers | show |
On 8/19/17 6:48 AM, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sat, 19 Aug 2017 13:14:26 +0200 > > Replace the specification of data structures by pointer dereferences > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Looks good, Reviewed-by: Eric Sandeen <sandeen@redhat.com> > --- > fs/ext4/dir.c | 2 +- > fs/ext4/mmp.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c > index e8b365000d73..b04e882179c6 100644 > --- a/fs/ext4/dir.c > +++ b/fs/ext4/dir.c > @@ -411,7 +411,7 @@ static struct dir_private_info *ext4_htree_create_dir_info(struct file *filp, > { > struct dir_private_info *p; > > - p = kzalloc(sizeof(struct dir_private_info), GFP_KERNEL); > + p = kzalloc(sizeof(*p), GFP_KERNEL); > if (!p) > return NULL; > p->curr_hash = pos2maj_hash(filp, pos); > diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c > index 1ce00453f612..3fa5df9f5573 100644 > --- a/fs/ext4/mmp.c > +++ b/fs/ext4/mmp.c > @@ -367,5 +367,5 @@ int ext4_multi_mount_protect(struct super_block *sb, > goto failed; > } > > - mmpd_data = kmalloc(sizeof(struct mmpd_data), GFP_KERNEL); > + mmpd_data = kmalloc(sizeof(*mmpd_data), GFP_KERNEL); > if (!mmpd_data) >
On Sat, Aug 19, 2017 at 08:49:20PM -0500, Eric Sandeen wrote: > On 8/19/17 6:48 AM, SF Markus Elfring wrote: > > From: Markus Elfring <elfring@users.sourceforge.net> > > Date: Sat, 19 Aug 2017 13:14:26 +0200 > > > > Replace the specification of data structures by pointer dereferences > > as the parameter for the operator "sizeof" to make the corresponding size > > determination a bit safer according to the Linux coding style convention. > > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > > Looks good, > > Reviewed-by: Eric Sandeen <sandeen@redhat.com> Thanks, applied. - Ted
diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c index e8b365000d73..b04e882179c6 100644 --- a/fs/ext4/dir.c +++ b/fs/ext4/dir.c @@ -411,7 +411,7 @@ static struct dir_private_info *ext4_htree_create_dir_info(struct file *filp, { struct dir_private_info *p; - p = kzalloc(sizeof(struct dir_private_info), GFP_KERNEL); + p = kzalloc(sizeof(*p), GFP_KERNEL); if (!p) return NULL; p->curr_hash = pos2maj_hash(filp, pos); diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c index 1ce00453f612..3fa5df9f5573 100644 --- a/fs/ext4/mmp.c +++ b/fs/ext4/mmp.c @@ -367,5 +367,5 @@ int ext4_multi_mount_protect(struct super_block *sb, goto failed; } - mmpd_data = kmalloc(sizeof(struct mmpd_data), GFP_KERNEL); + mmpd_data = kmalloc(sizeof(*mmpd_data), GFP_KERNEL); if (!mmpd_data)