| Message ID | 1295943748-9699-1-git-send-email-yong.zhang0@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Tue, Jan 25, 2011 at 04:22:28PM +0800, Yong Zhang wrote: >With CONFIGFS_FS=m && NETCONSOLE_DYNAMIC=y, build error: > >drivers/built-in.o: In function `netconsole_target_put': >build/drivers/net/netconsole.c:133: undefined reference to `config_item_put' >drivers/built-in.o: In function `netconsole_target_get': >build/drivers/net/netconsole.c:127: undefined reference to `config_item_get' >build/drivers/net/netconsole.c:127: undefined reference to `config_item_get' >drivers/built-in.o: In function `netconsole_target_put': >build/drivers/net/netconsole.c:133: undefined reference to `config_item_put' >drivers/built-in.o: In function `drop_netconsole_target': >build/drivers/net/netconsole.c:634: undefined reference to `config_item_put' >drivers/built-in.o: In function `make_netconsole_target': >build/drivers/net/netconsole.c:607: undefined reference to `config_item_init_type_name' >drivers/built-in.o: In function `dynamic_netconsole_init': >build/drivers/net/netconsole.c:109: undefined reference to `config_group_init' >build/drivers/net/netconsole.c:111: undefined reference to `configfs_register_subsystem' >drivers/built-in.o: In function `dynamic_netconsole_exit': >build/drivers/net/netconsole.c:116: undefined reference to `configfs_unregister_subsystem' > Yeah, this was reported, another way to fix this is "select CONFIGFS_FS". Using "select" makes you configure NETCONSOLE_DYNAMIC without caring about if you have configured CONFIGFS_FS=y, which seems better. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 25, 2011 at 4:39 PM, Américo Wang <xiyou.wangcong@gmail.com> wrote: > On Tue, Jan 25, 2011 at 04:22:28PM +0800, Yong Zhang wrote: >>With CONFIGFS_FS=m && NETCONSOLE_DYNAMIC=y, build error: >> >>drivers/built-in.o: In function `netconsole_target_put': >>build/drivers/net/netconsole.c:133: undefined reference to `config_item_put' >>drivers/built-in.o: In function `netconsole_target_get': >>build/drivers/net/netconsole.c:127: undefined reference to `config_item_get' >>build/drivers/net/netconsole.c:127: undefined reference to `config_item_get' >>drivers/built-in.o: In function `netconsole_target_put': >>build/drivers/net/netconsole.c:133: undefined reference to `config_item_put' >>drivers/built-in.o: In function `drop_netconsole_target': >>build/drivers/net/netconsole.c:634: undefined reference to `config_item_put' >>drivers/built-in.o: In function `make_netconsole_target': >>build/drivers/net/netconsole.c:607: undefined reference to `config_item_init_type_name' >>drivers/built-in.o: In function `dynamic_netconsole_init': >>build/drivers/net/netconsole.c:109: undefined reference to `config_group_init' >>build/drivers/net/netconsole.c:111: undefined reference to `configfs_register_subsystem' >>drivers/built-in.o: In function `dynamic_netconsole_exit': >>build/drivers/net/netconsole.c:116: undefined reference to `configfs_unregister_subsystem' >> > > Yeah, this was reported, another way to fix this is "select CONFIGFS_FS". > Using "select" makes you configure NETCONSOLE_DYNAMIC without caring > about if you have configured CONFIGFS_FS=y, which seems better. You mean commit d9f9ab51e55e36379773752ffeaac677b080d469? Thanks, Yong
On Tue, Jan 25, 2011 at 4:42 PM, Yong Zhang <yong.zhang0@gmail.com> wrote: > On Tue, Jan 25, 2011 at 4:39 PM, Américo Wang <xiyou.wangcong@gmail.com> wrote: >> On Tue, Jan 25, 2011 at 04:22:28PM +0800, Yong Zhang wrote: >>>With CONFIGFS_FS=m && NETCONSOLE_DYNAMIC=y, build error: >>> >>>drivers/built-in.o: In function `netconsole_target_put': >>>build/drivers/net/netconsole.c:133: undefined reference to `config_item_put' >>>drivers/built-in.o: In function `netconsole_target_get': >>>build/drivers/net/netconsole.c:127: undefined reference to `config_item_get' >>>build/drivers/net/netconsole.c:127: undefined reference to `config_item_get' >>>drivers/built-in.o: In function `netconsole_target_put': >>>build/drivers/net/netconsole.c:133: undefined reference to `config_item_put' >>>drivers/built-in.o: In function `drop_netconsole_target': >>>build/drivers/net/netconsole.c:634: undefined reference to `config_item_put' >>>drivers/built-in.o: In function `make_netconsole_target': >>>build/drivers/net/netconsole.c:607: undefined reference to `config_item_init_type_name' >>>drivers/built-in.o: In function `dynamic_netconsole_init': >>>build/drivers/net/netconsole.c:109: undefined reference to `config_group_init' >>>build/drivers/net/netconsole.c:111: undefined reference to `configfs_register_subsystem' >>>drivers/built-in.o: In function `dynamic_netconsole_exit': >>>build/drivers/net/netconsole.c:116: undefined reference to `configfs_unregister_subsystem' >>> >> >> Yeah, this was reported, another way to fix this is "select CONFIGFS_FS". >> Using "select" makes you configure NETCONSOLE_DYNAMIC without caring >> about if you have configured CONFIGFS_FS=y, which seems better. > > You mean commit d9f9ab51e55e36379773752ffeaac677b080d469? That commit show "select CONFIGFS_FS" is the wrong way :( > > Thanks, > Yong > > -- > Only stand for myself >
On Tue, Jan 25, 2011 at 4:39 PM, Américo Wang <xiyou.wangcong@gmail.com> wrote: > On Tue, Jan 25, 2011 at 04:22:28PM +0800, Yong Zhang wrote: >>With CONFIGFS_FS=m && NETCONSOLE_DYNAMIC=y, build error: >> >>drivers/built-in.o: In function `netconsole_target_put': >>build/drivers/net/netconsole.c:133: undefined reference to `config_item_put' >>drivers/built-in.o: In function `netconsole_target_get': >>build/drivers/net/netconsole.c:127: undefined reference to `config_item_get' >>build/drivers/net/netconsole.c:127: undefined reference to `config_item_get' >>drivers/built-in.o: In function `netconsole_target_put': >>build/drivers/net/netconsole.c:133: undefined reference to `config_item_put' >>drivers/built-in.o: In function `drop_netconsole_target': >>build/drivers/net/netconsole.c:634: undefined reference to `config_item_put' >>drivers/built-in.o: In function `make_netconsole_target': >>build/drivers/net/netconsole.c:607: undefined reference to `config_item_init_type_name' >>drivers/built-in.o: In function `dynamic_netconsole_init': >>build/drivers/net/netconsole.c:109: undefined reference to `config_group_init' >>build/drivers/net/netconsole.c:111: undefined reference to `configfs_register_subsystem' >>drivers/built-in.o: In function `dynamic_netconsole_exit': >>build/drivers/net/netconsole.c:116: undefined reference to `configfs_unregister_subsystem' >> > > Yeah, this was reported, another way to fix this is "select CONFIGFS_FS". > Using "select" makes you configure NETCONSOLE_DYNAMIC without caring > about if you have configured CONFIGFS_FS=y, which seems better. OK. Find the original reporting. Sorry for the noise.
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 0382332..2b12c0d 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -3389,7 +3389,7 @@ config NETCONSOLE config NETCONSOLE_DYNAMIC bool "Dynamic reconfiguration of logging targets" - depends on NETCONSOLE && SYSFS && CONFIGFS_FS + depends on NETCONSOLE && SYSFS && CONFIGFS_FS=y help This option enables the ability to dynamically reconfigure target parameters (interface, IP addresses, port numbers, MAC addresses)
With CONFIGFS_FS=m && NETCONSOLE_DYNAMIC=y, build error: drivers/built-in.o: In function `netconsole_target_put': build/drivers/net/netconsole.c:133: undefined reference to `config_item_put' drivers/built-in.o: In function `netconsole_target_get': build/drivers/net/netconsole.c:127: undefined reference to `config_item_get' build/drivers/net/netconsole.c:127: undefined reference to `config_item_get' drivers/built-in.o: In function `netconsole_target_put': build/drivers/net/netconsole.c:133: undefined reference to `config_item_put' drivers/built-in.o: In function `drop_netconsole_target': build/drivers/net/netconsole.c:634: undefined reference to `config_item_put' drivers/built-in.o: In function `make_netconsole_target': build/drivers/net/netconsole.c:607: undefined reference to `config_item_init_type_name' drivers/built-in.o: In function `dynamic_netconsole_init': build/drivers/net/netconsole.c:109: undefined reference to `config_group_init' build/drivers/net/netconsole.c:111: undefined reference to `configfs_register_subsystem' drivers/built-in.o: In function `dynamic_netconsole_exit': build/drivers/net/netconsole.c:116: undefined reference to `configfs_unregister_subsystem' Signed-off-by: Yong Zhang <yong.zhang0@gmail.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Kevin Hilman <khilman@deeprootsystems.com> --- drivers/net/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)