| Message ID | 20170818142613.32394-4-ldoktor@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 08/18/2017 10:26 AM, Lukáš Doktor wrote: > Let's avoid creating an in-memory list of keys and query for each value > and use `iteritems` which is an iterator of key-value pairs. > > Signed-off-by: Lukáš Doktor <ldoktor@redhat.com> > Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > scripts/qemu.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/scripts/qemu.py b/scripts/qemu.py > index 5d09de4..db21407 100644 > --- a/scripts/qemu.py > +++ b/scripts/qemu.py > @@ -186,11 +186,11 @@ class QEMUMachine(object): > def qmp(self, cmd, conv_keys=True, **args): > '''Invoke a QMP command and return the response dict''' > qmp_args = dict() > - for key in args.keys(): > + for key, value in args.iteritems(): > if conv_keys: > - qmp_args[key.translate(self.underscore_to_dash)] = args[key] > + qmp_args[key.translate(self.underscore_to_dash)] = value > else: > - qmp_args[key] = args[key] > + qmp_args[key] = value > > return self._qmp.cmd(cmd, args=qmp_args) > > Yep, I could tell this was coming while reading patch 01. Reviewed-by: Cleber Rosa <crosa@redhat.com>
diff --git a/scripts/qemu.py b/scripts/qemu.py index 5d09de4..db21407 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -186,11 +186,11 @@ class QEMUMachine(object): def qmp(self, cmd, conv_keys=True, **args): '''Invoke a QMP command and return the response dict''' qmp_args = dict() - for key in args.keys(): + for key, value in args.iteritems(): if conv_keys: - qmp_args[key.translate(self.underscore_to_dash)] = args[key] + qmp_args[key.translate(self.underscore_to_dash)] = value else: - qmp_args[key] = args[key] + qmp_args[key] = value return self._qmp.cmd(cmd, args=qmp_args)