| Message ID | 20170818103248.ddguatdt5jhm5zx7@mwanda |
|---|---|
| State | New |
| Headers | show |
On Fri, Aug 18, 2017 at 12:32 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > The rza1_pctl->ports[] array has RZA1_NPORTS (12) elements. The > here > should be >= to prevent an out of bounds access. > > Fixes: 5a49b644b307 ("pinctrl: Renesas RZ/A1 pin and gpio controller") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/pinctrl/pinctrl-rza1.c b/drivers/pinctrl/pinctrl-rza1.c > index 7e30134b3d18..464dbf2f0816 100644 > --- a/drivers/pinctrl/pinctrl-rza1.c > +++ b/drivers/pinctrl/pinctrl-rza1.c > @@ -1088,7 +1088,7 @@ static int rza1_parse_gpiochip(struct rza1_pinctrl *rza1_pctl, > */ > pinctrl_base = of_args.args[1]; > gpioport = RZA1_PIN_ID_TO_PORT(pinctrl_base); > - if (gpioport > RZA1_NPORTS) { > + if (gpioport >= RZA1_NPORTS) { > dev_err(rza1_pctl->dev, > "Invalid values in property %s\n", list_name); > return -EINVAL; Geert/Jacopo, can any of you ACK this? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Aug 18, 2017 at 12:32 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > The rza1_pctl->ports[] array has RZA1_NPORTS (12) elements. The > here > should be >= to prevent an out of bounds access. > > Fixes: 5a49b644b307 ("pinctrl: Renesas RZ/A1 pin and gpio controller") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Linus, sorry for being late. With Geert's approval I guess my ack is not that necessary, but... On Wed, Aug 23, 2017 at 09:35:42AM +0200, Geert Uytterhoeven wrote: > On Fri, Aug 18, 2017 at 12:32 PM, Dan Carpenter > <dan.carpenter@oracle.com> wrote: > > The rza1_pctl->ports[] array has RZA1_NPORTS (12) elements. The > here > > should be >= to prevent an out of bounds access. > > > > Fixes: 5a49b644b307 ("pinctrl: Renesas RZ/A1 pin and gpio controller") > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Jacopo Mondi <jacopo@jmondi.org> > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Aug 18, 2017 at 12:32 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > The rza1_pctl->ports[] array has RZA1_NPORTS (12) elements. The > here > should be >= to prevent an out of bounds access. > > Fixes: 5a49b644b307 ("pinctrl: Renesas RZ/A1 pin and gpio controller") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Patch applied with the ACKs. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/pinctrl-rza1.c b/drivers/pinctrl/pinctrl-rza1.c index 7e30134b3d18..464dbf2f0816 100644 --- a/drivers/pinctrl/pinctrl-rza1.c +++ b/drivers/pinctrl/pinctrl-rza1.c @@ -1088,7 +1088,7 @@ static int rza1_parse_gpiochip(struct rza1_pinctrl *rza1_pctl, */ pinctrl_base = of_args.args[1]; gpioport = RZA1_PIN_ID_TO_PORT(pinctrl_base); - if (gpioport > RZA1_NPORTS) { + if (gpioport >= RZA1_NPORTS) { dev_err(rza1_pctl->dev, "Invalid values in property %s\n", list_name); return -EINVAL;
The rza1_pctl->ports[] array has RZA1_NPORTS (12) elements. The > here should be >= to prevent an out of bounds access. Fixes: 5a49b644b307 ("pinctrl: Renesas RZ/A1 pin and gpio controller") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html