diff mbox

[U-Boot,1/1] board/ls2081ardb: Update display information during boot

Message ID 1503049833-6943-3-git-send-email-santan.kumar@nxp.com
State Changes Requested
Delegated to: York Sun
Headers show

Commit Message

Santan Kumar Aug. 18, 2017, 9:50 a.m. UTC 
This patch modifies checkboard() for below changes:
-Remove Board Arch print
	Arch contains Qixis architecture version
	This field is more relevant for QDS boards.
	For RDB boards it is always constant as '1'.
-Correct the QMAP information.
	QMAP controls hows QSPI_A chip-selects are connected to
	various peripherals. And this information are saved in
	rightmost three bits. Hence, need to use only these three bits.
-Add print to display FPGA information.

Signed-off-by: Santan Kumar <santan.kumar@nxp.com>
Signed-off-by: Priyanka Jain <priyanka.jain@nxp.com>
---
This patch is split version of another patch
 https://patchwork.ozlabs.org/patch/779931/

 board/freescale/ls2080ardb/ls2080ardb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Prabhakar Kushwaha Aug. 18, 2017, 10:21 a.m. UTC | #1 
> -----Original Message-----

> From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Santan

> Kumar

> Sent: Friday, August 18, 2017 3:21 PM

> To: u-boot@lists.denx.de; York Sun <york.sun@nxp.com>

> Cc: Priyanka Jain <priyanka.jain@nxp.com>

> Subject: [U-Boot] [PATCH 1/1] board/ls2081ardb: Update display information

> during boot


Can we add more precise subject. It looks to be vague


> 

> This patch modifies checkboard() for below changes:

> -Remove Board Arch print

> 	Arch contains Qixis architecture version

> 	This field is more relevant for QDS boards.

> 	For RDB boards it is always constant as '1'.

> -Correct the QMAP information.

> 	QMAP controls hows QSPI_A chip-selects are connected to

> 	various peripherals. And this information are saved in

> 	rightmost three bits. Hence, need to use only these three bits.

> -Add print to display FPGA information.

> 


Please avoid using bulleted description in patch.  Try to use sentences. 

-prabhakar
York Sun Sept. 14, 2017, 8:17 p.m. UTC | #2 
On 08/18/2017 03:21 AM, Prabhakar Kushwaha wrote:
> 
>> -----Original Message-----
>> From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Santan
>> Kumar
>> Sent: Friday, August 18, 2017 3:21 PM
>> To: u-boot@lists.denx.de; York Sun <york.sun@nxp.com>
>> Cc: Priyanka Jain <priyanka.jain@nxp.com>
>> Subject: [U-Boot] [PATCH 1/1] board/ls2081ardb: Update display information
>> during boot
> 
> Can we add more precise subject. It looks to be vague
> 
> 
>>
>> This patch modifies checkboard() for below changes:
>> -Remove Board Arch print
>> 	Arch contains Qixis architecture version
>> 	This field is more relevant for QDS boards.
>> 	For RDB boards it is always constant as '1'.
>> -Correct the QMAP information.
>> 	QMAP controls hows QSPI_A chip-selects are connected to
>> 	various peripherals. And this information are saved in
>> 	rightmost three bits. Hence, need to use only these three bits.
>> -Add print to display FPGA information.
>>
> 
> Please avoid using bulleted description in patch.  Try to use sentences.
> 

Santa,

Please update this patch as discussed.

York
diff mbox

Patch

diff --git a/board/freescale/ls2080ardb/ls2080ardb.c b/board/freescale/ls2080ardb/ls2080ardb.c
index 0017f60..bae4b6f 100644
--- a/board/freescale/ls2080ardb/ls2080ardb.c
+++ b/board/freescale/ls2080ardb/ls2080ardb.c
@@ -71,11 +71,10 @@  int checkboard(void)
 #ifdef CONFIG_TARGET_LS2081ARDB
 #ifdef CONFIG_FSL_QIXIS
 	sw = QIXIS_READ(arch);
-	printf("Board Arch: V%d, ", sw >> 4);
 	printf("Board version: %c, ", (sw & 0xf) + 'A');
 
 	sw = QIXIS_READ(brdcfg[0]);
-	sw = (sw & QIXIS_QMAP_MASK) >> QIXIS_QMAP_SHIFT;
+	sw = ((sw >> QIXIS_QMAP_SHIFT) & QIXIS_QMAP_MASK);
 	switch (sw) {
 	case 0:
 		puts("boot from QSPI DEV#0\n");
@@ -101,6 +100,7 @@  int checkboard(void)
 		printf("invalid setting of SW%u\n", sw);
 		break;
 	}
+	printf("FPGA: v%d.%d\n", QIXIS_READ(scver), QIXIS_READ(tagdata));
 #endif
 	puts("SERDES1 Reference : ");
 	printf("Clock1 = 100MHz ");