diff mbox

[3/3] fwts-test: sync up PCCT tests with ACPI 6.2 changes

Message ID 1502995192-21160-3-git-send-email-alex.hung@canonical.com
State Accepted
Headers show

Commit Message

Alex Hung Aug. 17, 2017, 6:39 p.m. UTC 
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 fwts-test/pcct-0001/acpidump-0001.log |  30 +++++-
 fwts-test/pcct-0001/acpidump-0002.log |  34 +++++--
 fwts-test/pcct-0001/pcct-0001.log     | 116 +++++++++++++++++++++--
 fwts-test/pcct-0001/pcct-0002.log     | 169 ++++++++++++++++++++++++++++++----
 4 files changed, 313 insertions(+), 36 deletions(-)

Comments

Colin Ian King Aug. 22, 2017, 3:25 p.m. UTC | #1 
On 17/08/17 19:39, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  fwts-test/pcct-0001/acpidump-0001.log |  30 +++++-
>  fwts-test/pcct-0001/acpidump-0002.log |  34 +++++--
>  fwts-test/pcct-0001/pcct-0001.log     | 116 +++++++++++++++++++++--
>  fwts-test/pcct-0001/pcct-0002.log     | 169 ++++++++++++++++++++++++++++++----
>  4 files changed, 313 insertions(+), 36 deletions(-)
> 
> diff --git a/fwts-test/pcct-0001/acpidump-0001.log b/fwts-test/pcct-0001/acpidump-0001.log
> index 8aff607..9c92c2f 100644
> --- a/fwts-test/pcct-0001/acpidump-0001.log
> +++ b/fwts-test/pcct-0001/acpidump-0001.log
> @@ -24,9 +24,9 @@ FACP @ 0x00000000
>    00f0: 00 00 00 00                                      ....
>  
>  PCCT @ 0x00000000                                               
> -  0000: 50 43 43 54 06 01 00 00 01 60 49 4e 54 45 4c 20  PCCT.....`INTEL 
> -  0010: 54 45 4d 50 4c 41 54 45 01 00 00 00 49 4e 54 4c  TEMPLATE....INTL
> -  0020: 27 05 16 20 01 00 00 00 00 00 00 00 00 00 00 00  '.. ............
> +  0000: 50 43 43 54 4e 02 00 00 01 b2 49 4e 54 45 4c 20  PCCTN.....INTEL 
> +  0010: 54 65 6d 70 6c 61 74 65 01 00 00 00 49 4e 54 4c  Template....INTL
> +  0020: 28 07 17 20 01 00 00 00 00 00 00 00 00 00 00 00  (.. ............
>    0030: 00 3e 00 00 00 00 00 00 11 11 11 11 11 11 11 11  .>..............
>    0040: 22 22 22 22 22 22 22 22 01 32 00 03 33 33 33 33  """""""".2..3333
>    0050: 33 33 33 33 44 44 44 44 44 44 44 44 55 55 55 55  3333DDDDDDDDUUUU
> @@ -35,10 +35,30 @@ PCCT @ 0x00000000
>    0080: 55 55 55 55 55 55 01 32 00 03 44 44 44 44 44 44  UUUUUU.2..DDDDDD
>    0090: 44 44 44 44 44 44 44 44 44 44 55 55 55 55 55 55  DDDDDDDDDDUUUUUU
>    00a0: 55 55 66 66 66 66 77 77 77 77 88 88 02 5a 01 00  UUffffwwww...Z..
> -  00b0: 00 00 03 00 00 00 00 00 00 00 00 00 99 99 99 99  ................
> +  00b0: 00 00 01 00 00 00 00 00 00 00 00 00 99 99 99 99  ................
>    00c0: 99 99 99 99 01 32 00 03 44 44 44 44 44 44 44 44  .....2..DDDDDDDD
>    00d0: 44 44 44 44 44 44 44 44 55 55 55 55 55 55 55 55  DDDDDDDDUUUUUUUU
>    00e0: 66 66 66 66 77 77 77 77 88 88 01 32 00 03 33 33  ffffwwww...2..33
>    00f0: 33 33 33 33 33 33 44 44 44 44 44 44 44 44 55 55  333333DDDDDDDDUU
> -  0100: 55 55 55 55 55 55                                UUUUUU
> +  0100: 55 55 55 55 55 55 03 a4 01 00 00 00 01 00 00 00  UUUUUU..........
> +  0110: 00 00 00 00 00 00 77 77 77 77 01 32 00 03 33 33  ......wwww.2..33
> +  0120: 33 33 33 33 33 33 44 44 44 44 44 44 44 44 55 55  333333DDDDDDDDUU
> +  0130: 55 55 55 55 55 55 66 66 66 66 77 77 77 77 88 88  UUUUUUffffwwww..
> +  0140: 88 88 01 32 00 03 33 33 33 33 33 33 33 33 99 99  ...2..33333333..
> +  0150: 99 99 99 99 99 99 00 00 00 00 00 00 00 00 00 00  ................
> +  0160: 00 00 00 00 00 00 01 32 00 03 33 33 33 33 33 33  .......2..333333
> +  0170: 33 33 22 22 22 22 22 22 22 22 01 32 00 03 33 33  33"""""""".2..33
> +  0180: 33 33 33 33 33 33 33 33 33 33 33 33 33 33 44 44  33333333333333DD
> +  0190: 44 44 44 44 44 44 01 32 00 03 33 33 33 33 33 33  DDDDDD.2..333333
> +  01a0: 33 33 55 55 55 55 55 55 55 55 04 a4 01 00 00 00  33UUUUUUUU......
> +  01b0: 01 00 00 00 00 00 00 00 00 00 88 88 88 88 01 32  ...............2
> +  01c0: 00 03 33 33 33 33 33 33 33 33 44 44 44 44 44 44  ..33333333DDDDDD
> +  01d0: 44 44 55 55 55 55 55 55 55 55 66 66 66 66 77 77  DDUUUUUUUUffffww
> +  01e0: 77 77 88 88 88 88 01 32 00 03 33 33 33 33 33 33  ww.....2..333333
> +  01f0: 33 33 99 99 99 99 99 99 99 99 00 00 00 00 00 00  33..............
> +  0200: 00 00 00 00 00 00 00 00 00 00 01 32 00 03 33 33  ...........2..33
> +  0210: 33 33 33 33 33 33 22 22 22 22 22 22 22 22 01 32  333333"""""""".2
> +  0220: 00 03 33 33 33 33 33 33 33 33 33 33 33 33 33 33  ..33333333333333
> +  0230: 33 33 44 44 44 44 44 44 44 44 01 32 00 03 33 33  33DDDDDDDD.2..33
> +  0240: 33 33 33 33 33 33 55 55 55 55 55 55 55 55        333333UUUUUUUU
>  
> diff --git a/fwts-test/pcct-0001/acpidump-0002.log b/fwts-test/pcct-0001/acpidump-0002.log
> index d98f96d..2a29dc5 100644
> --- a/fwts-test/pcct-0001/acpidump-0002.log
> +++ b/fwts-test/pcct-0001/acpidump-0002.log
> @@ -24,9 +24,9 @@ FACP @ 0x00000000
>    00f0: 00 00 00 00                                      ....
>  
>  PCCT @ 0x00000000
> -  0000: 50 43 43 54 06 01 00 00 01 57 49 4e 54 45 4c 20  PCCT.....WINTEL 
> -  0010: 54 45 4d 50 4c 41 54 45 01 00 00 00 49 4e 54 4c  TEMPLATE....INTL
> -  0020: 27 05 16 20 01 00 00 00 00 00 00 00 00 00 00 00  '.. ............
> +  0000: 50 43 43 54 4e 02 00 00 01 85 49 4e 54 45 4c 20  PCCTN.....INTEL 
> +  0010: 54 65 6d 70 6c 61 74 65 01 00 00 00 49 4e 54 4c  Template....INTL
> +  0020: 28 07 17 20 00 00 00 00 00 00 00 00 00 00 00 00  (.. ............
>    0030: 00 3e 00 00 00 00 00 00 11 11 11 11 11 11 11 11  .>..............
>    0040: 22 22 22 22 22 22 22 22 02 32 00 03 33 33 33 33  """""""".2..3333
>    0050: 33 33 33 33 44 44 44 44 44 44 44 44 55 55 55 55  3333DDDDDDDDUUUU
> @@ -35,10 +35,30 @@ PCCT @ 0x00000000
>    0080: 55 55 55 55 55 55 04 32 00 03 44 44 44 44 44 44  UUUUUU.2..DDDDDD
>    0090: 44 44 44 44 44 44 44 44 44 44 55 55 55 55 55 55  DDDDDDDDDDUUUUUU
>    00a0: 55 55 66 66 66 66 77 77 77 77 88 88 02 5a 01 00  UUffffwwww...Z..
> -  00b0: 00 00 03 00 00 00 00 00 00 00 00 00 99 99 99 99  ................
> +  00b0: 00 00 01 00 00 00 00 00 00 00 00 00 99 99 99 99  ................
>    00c0: 99 99 99 99 03 32 00 03 44 44 44 44 44 44 44 44  .....2..DDDDDDDD
>    00d0: 44 44 44 44 44 44 44 44 55 55 55 55 55 55 55 55  DDDDDDDDUUUUUUUU
> -  00e0: 66 66 66 66 77 77 77 77 88 88 04 32 00 03 33 33  ffffwwww...2..33
> +  00e0: 66 66 66 66 77 77 77 77 88 88 03 32 00 03 33 33  ffffwwww...2..33
>    00f0: 33 33 33 33 33 33 44 44 44 44 44 44 44 44 55 55  333333DDDDDDDDUU
> -  0100: 55 55 55 55 55 55                                UUUUUU
> -                        
> +  0100: 55 55 55 55 55 55 03 a4 01 00 00 00 01 00 00 00  UUUUUU..........
> +  0110: 00 00 00 00 00 00 77 77 77 77 05 32 00 03 33 33  ......wwww.2..33
> +  0120: 33 33 33 33 33 33 44 44 44 44 44 44 44 44 55 55  333333DDDDDDDDUU
> +  0130: 55 55 55 55 55 55 66 66 66 66 77 77 77 77 88 88  UUUUUUffffwwww..
> +  0140: 88 88 05 32 00 03 33 33 33 33 33 33 33 33 99 99  ...2..33333333..
> +  0150: 99 99 99 99 99 99 00 00 00 00 00 00 00 00 00 00  ................
> +  0160: 00 00 00 00 00 00 05 32 00 03 33 33 33 33 33 33  .......2..333333
> +  0170: 33 33 22 22 22 22 22 22 22 22 05 32 00 03 33 33  33"""""""".2..33
> +  0180: 33 33 33 33 33 33 33 33 33 33 33 33 33 33 44 44  33333333333333DD
> +  0190: 44 44 44 44 44 44 05 32 00 03 33 33 33 33 33 33  DDDDDD.2..333333
> +  01a0: 33 33 55 55 55 55 55 55 55 55 04 a4 01 00 00 00  33UUUUUUUU......
> +  01b0: 01 00 00 00 00 00 00 00 00 00 88 88 88 88 05 32  ...............2
> +  01c0: 00 03 33 33 33 33 33 33 33 33 44 44 44 44 44 44  ..33333333DDDDDD
> +  01d0: 44 44 55 55 55 55 55 55 55 55 66 66 66 66 77 77  DDUUUUUUUUffffww
> +  01e0: 77 77 88 88 88 88 05 32 00 03 33 33 33 33 33 33  ww.....2..333333
> +  01f0: 33 33 99 99 99 99 99 99 99 99 00 00 00 00 00 00  33..............
> +  0200: 00 00 00 00 00 00 00 00 00 00 05 32 00 03 33 33  ...........2..33
> +  0210: 33 33 33 33 33 33 22 22 22 22 22 22 22 22 04 32  333333"""""""".2
> +  0220: 00 03 33 33 33 33 33 33 33 33 33 33 33 33 33 33  ..33333333333333
> +  0230: 33 33 44 44 44 44 44 44 44 44 04 32 00 03 33 33  33DDDDDDDD.2..33
> +  0240: 33 33 33 33 33 33 55 55 55 55 55 55 55 55        333333UUUUUUUU
> +
> diff --git a/fwts-test/pcct-0001/pcct-0001.log b/fwts-test/pcct-0001/pcct-0001.log
> index d82a6bd..8703a98 100644
> --- a/fwts-test/pcct-0001/pcct-0001.log
> +++ b/fwts-test/pcct-0001/pcct-0001.log
> @@ -26,8 +26,8 @@ pcct
>  pcct              PCC Subspace Structure:
>  pcct                Type:                        0x01
>  pcct                Length:                      0x3e
> -pcct                Doorbell Interrupt:          0x00000001
> -pcct                Doorbell Interrupt Flags:    0x01
> +pcct                Platform Interrupt:          0x00000001
> +pcct                Platform Interrupt Flags:    0x01
>  pcct                Reserved:                    0x00
>  pcct                Base Address:                0x0000000000000000
>  pcct                Length:                      0x5555555555555555
> @@ -46,8 +46,8 @@ pcct
>  pcct              PCC Subspace Structure:
>  pcct                Type:                        0x02
>  pcct                Length:                      0x5a
> -pcct                Doorbell Interrupt:          0x00000001
> -pcct                Doorbell Interrupt Flags:    0x03
> +pcct                Platform Interrupt:          0x00000001
> +pcct                Platform Interrupt Flags:    0x01
>  pcct                Reserved:                    0x00
>  pcct                Base Address:                0x0000000000000000
>  pcct                Length:                      0x9999999999999999
> @@ -62,14 +62,116 @@ pcct                Doorbell Write:              0x5555555555555555
>  pcct                Nominal Latency:             0x66666666
>  pcct                Max Periodic Access Rate:    0x77777777
>  pcct                Min Request Turnaround Time: 0x00008888
> -pcct                Doorbell Ack Register:
> +pcct                Platform Interrupt Ack Register:
>  pcct                  Address Space ID           0x01
>  pcct                  Register Bit Width         0x32
>  pcct                  Register Bit Offset        0x00
>  pcct                  Access Size                0x03
>  pcct                  Address                    0x3333333333333333
> -pcct                Doorbell Ack Preserve:       0x4444444444444444
> -pcct                Doorbell Ack Write:          0x5555555555555555
> +pcct                Platform Ack Preserve:       0x4444444444444444
> +pcct                Platform Ack Write:          0x5555555555555555
> +pcct            
> +pcct              PCC Subspace Structure:
> +pcct                Type:                        0x03
> +pcct                Length:                      0xa4
> +pcct                Platform Interrupt:          0x00000001
> +pcct                Platform Interrupt Flags:    0x01
> +pcct                Reserved:                    0x00
> +pcct                Base Address:                0x0000000000000000
> +pcct                Length:                      0x77777777
> +pcct                Doorbell Register:
> +pcct                  Address Space ID           0x01
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct                Doorbell Preserve:           0x4444444444444444
> +pcct                Doorbell Write:              0x5555555555555555
> +pcct                Nominal Latency:             0x66666666
> +pcct                Max Periodic Access Rate:    0x77777777
> +pcct                Min Request Turnaround Time: 0x88888888
> +pcct                Command Complete Check Register:
> +pcct                  Address Space ID           0x01
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct                Doorbell Ack Preserve:       0x9999999999999999
> +pcct                Doorbell Ack Write:          0x0000000000000000
> +pcct                Reserved:                    0x0000000000000000
> +pcct                Cmd Complete Check Register:
> +pcct                  Address Space ID           0x01
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct                Cmd Complete Check Mask:     0x2222222222222222
> +pcct                Cmd Complete Update Register:
> +pcct                  Address Space ID           0x01
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct                Cmd Complete Update Mask:    0x3333333333333333
> +pcct                Cmd Complete Set Mask:       0x3333333333333333
> +pcct                Error Status Register:
> +pcct                  Address Space ID           0x01
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct                Error Status Mask:           0x5555555555555555
> +pcct            
> +pcct              PCC Subspace Structure:
> +pcct                Type:                        0x04
> +pcct                Length:                      0xa4
> +pcct                Platform Interrupt:          0x00000001
> +pcct                Platform Interrupt Flags:    0x01
> +pcct                Reserved:                    0x00
> +pcct                Base Address:                0x0000000000000000
> +pcct                Length:                      0x88888888
> +pcct                Doorbell Register:
> +pcct                  Address Space ID           0x01
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct                Doorbell Preserve:           0x4444444444444444
> +pcct                Doorbell Write:              0x5555555555555555
> +pcct                Nominal Latency:             0x66666666
> +pcct                Max Periodic Access Rate:    0x77777777
> +pcct                Min Request Turnaround Time: 0x88888888
> +pcct                Command Complete Check Register:
> +pcct                  Address Space ID           0x01
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct                Doorbell Ack Preserve:       0x9999999999999999
> +pcct                Doorbell Ack Write:          0x0000000000000000
> +pcct                Reserved:                    0x0000000000000000
> +pcct                Cmd Complete Check Register:
> +pcct                  Address Space ID           0x01
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct                Cmd Complete Check Mask:     0x2222222222222222
> +pcct                Cmd Complete Update Register:
> +pcct                  Address Space ID           0x01
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct                Cmd Complete Update Mask:    0x3333333333333333
> +pcct                Cmd Complete Set Mask:       0x3333333333333333
> +pcct                Error Status Register:
> +pcct                  Address Space ID           0x01
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct                Error Status Mask:           0x5555555555555555
>  pcct            
>  pcct            PASSED: Test 1, No issues found in PCC table.
>  pcct            
> diff --git a/fwts-test/pcct-0001/pcct-0002.log b/fwts-test/pcct-0001/pcct-0002.log
> index 5c80230..c2dd70f 100644
> --- a/fwts-test/pcct-0001/pcct-0002.log
> +++ b/fwts-test/pcct-0001/pcct-0002.log
> @@ -2,7 +2,7 @@ pcct            pcct: PCCT Platform Communications Channel test.
>  pcct            ----------------------------------------------------------
>  pcct            Test 1 of 1: Validate PCC table.
>  pcct            PCC Table:
> -pcct              Flags:     0x00000001
> +pcct              Flags:     0x00000000
>  pcct              Reserved:  0x0000000000000000
>  pcct            
>  pcct              PCC Subspace Structure:
> @@ -24,13 +24,13 @@ pcct                Max Periodic Access Rate:    0x77777777
>  pcct                Min Request Turnaround Time: 0x00008888
>  pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
>  pcct            Subspace Type 0 has space ID = 0x02 which is not System I
> -pcct            /O Space or System Memory Space
> +pcct            /O or Memory
>  pcct            
>  pcct              PCC Subspace Structure:
>  pcct                Type:                        0x01
>  pcct                Length:                      0x3e
> -pcct                Doorbell Interrupt:          0x00000001
> -pcct                Doorbell Interrupt Flags:    0x01
> +pcct                Platform Interrupt:          0x00000001
> +pcct                Platform Interrupt Flags:    0x01
>  pcct                Reserved:                    0x00
>  pcct                Base Address:                0x0000000000000000
>  pcct                Length:                      0x5555555555555555
> @@ -40,20 +40,20 @@ pcct                  Register Bit Width         0x32
>  pcct                  Register Bit Offset        0x00
>  pcct                  Access Size                0x03
>  pcct                  Address                    0x4444444444444444
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 1 has space ID = 4 which is not System I/O,
> +pcct            Memory or FFH
>  pcct                Doorbell Preserve:           0x4444444444444444
>  pcct                Doorbell Write:              0x5555555555555555
>  pcct                Nominal Latency:             0x66666666
>  pcct                Max Periodic Access Rate:    0x77777777
>  pcct                Min Request Turnaround Time: 0x00008888
> -pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> -pcct            Subspace Type 1 has space ID = 0x04 which is not System I
> -pcct            /O Space or System Memory Space
>  pcct            
>  pcct              PCC Subspace Structure:
>  pcct                Type:                        0x02
>  pcct                Length:                      0x5a
> -pcct                Doorbell Interrupt:          0x00000001
> -pcct                Doorbell Interrupt Flags:    0x03
> +pcct                Platform Interrupt:          0x00000001
> +pcct                Platform Interrupt Flags:    0x01
>  pcct                Reserved:                    0x00
>  pcct                Base Address:                0x0000000000000000
>  pcct                Length:                      0x9999999999999999
> @@ -63,28 +63,163 @@ pcct                  Register Bit Width         0x32
>  pcct                  Register Bit Offset        0x00
>  pcct                  Access Size                0x03
>  pcct                  Address                    0x4444444444444444
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 2 has space ID = 3 which is not System I/O,
> +pcct            Memory or FFH
>  pcct                Doorbell Preserve:           0x4444444444444444
>  pcct                Doorbell Write:              0x5555555555555555
>  pcct                Nominal Latency:             0x66666666
>  pcct                Max Periodic Access Rate:    0x77777777
>  pcct                Min Request Turnaround Time: 0x00008888
> -pcct                Doorbell Ack Register:
> +pcct                Platform Interrupt Ack Register:
> +pcct                  Address Space ID           0x03
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 2 has space ID = 3 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Platform Ack Preserve:       0x4444444444444444
> +pcct                Platform Ack Write:          0x5555555555555555
> +pcct            
> +pcct              PCC Subspace Structure:
> +pcct                Type:                        0x03
> +pcct                Length:                      0xa4
> +pcct                Platform Interrupt:          0x00000001
> +pcct                Platform Interrupt Flags:    0x01
> +pcct                Reserved:                    0x00
> +pcct                Base Address:                0x0000000000000000
> +pcct                Length:                      0x77777777
> +pcct                Doorbell Register:
> +pcct                  Address Space ID           0x05
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 3 has space ID = 5 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Doorbell Preserve:           0x4444444444444444
> +pcct                Doorbell Write:              0x5555555555555555
> +pcct                Nominal Latency:             0x66666666
> +pcct                Max Periodic Access Rate:    0x77777777
> +pcct                Min Request Turnaround Time: 0x88888888
> +pcct                Command Complete Check Register:
> +pcct                  Address Space ID           0x05
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 3 has space ID = 5 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Doorbell Ack Preserve:       0x9999999999999999
> +pcct                Doorbell Ack Write:          0x0000000000000000
> +pcct                Reserved:                    0x0000000000000000
> +pcct                Cmd Complete Check Register:
> +pcct                  Address Space ID           0x05
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 3 has space ID = 5 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Cmd Complete Check Mask:     0x2222222222222222
> +pcct                Cmd Complete Update Register:
> +pcct                  Address Space ID           0x05
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 3 has space ID = 5 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Cmd Complete Update Mask:    0x3333333333333333
> +pcct                Cmd Complete Set Mask:       0x3333333333333333
> +pcct                Error Status Register:
> +pcct                  Address Space ID           0x05
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 3 has space ID = 5 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Error Status Mask:           0x5555555555555555
> +pcct            
> +pcct              PCC Subspace Structure:
> +pcct                Type:                        0x04
> +pcct                Length:                      0xa4
> +pcct            FAILED [HIGH] PCCTBadFlags: Test 1, PCCT Plaform Interrupt
> +pcct            in flags must be set when subspace type 4 is present, got
> +pcct            0x00000000 instead
> +pcct                Platform Interrupt:          0x00000001
> +pcct                Platform Interrupt Flags:    0x01
> +pcct                Reserved:                    0x00
> +pcct                Base Address:                0x0000000000000000
> +pcct                Length:                      0x88888888
> +pcct                Doorbell Register:
> +pcct                  Address Space ID           0x05
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 4 has space ID = 5 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Doorbell Preserve:           0x4444444444444444
> +pcct                Doorbell Write:              0x5555555555555555
> +pcct                Nominal Latency:             0x66666666
> +pcct                Max Periodic Access Rate:    0x77777777
> +pcct                Min Request Turnaround Time: 0x88888888
> +pcct                Command Complete Check Register:
> +pcct                  Address Space ID           0x05
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 4 has space ID = 5 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Doorbell Ack Preserve:       0x9999999999999999
> +pcct                Doorbell Ack Write:          0x0000000000000000
> +pcct                Reserved:                    0x0000000000000000
> +pcct                Cmd Complete Check Register:
> +pcct                  Address Space ID           0x05
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 4 has space ID = 5 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Cmd Complete Check Mask:     0x2222222222222222
> +pcct                Cmd Complete Update Register:
>  pcct                  Address Space ID           0x04
>  pcct                  Register Bit Width         0x32
>  pcct                  Register Bit Offset        0x00
>  pcct                  Access Size                0x03
>  pcct                  Address                    0x3333333333333333
> -pcct                Doorbell Ack Preserve:       0x4444444444444444
> -pcct                Doorbell Ack Write:          0x5555555555555555
>  pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> -pcct            Subspace Type 2 has space ID = 0x03 which is not System I
> -pcct            /O Space or System Memory Space
> +pcct            Subspace Type 4 has space ID = 4 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Cmd Complete Update Mask:    0x3333333333333333
> +pcct                Cmd Complete Set Mask:       0x3333333333333333
> +pcct                Error Status Register:
> +pcct                  Address Space ID           0x04
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
>  pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> -pcct            Subspace Type 2 has space ID = 0x03 which is not System I
> -pcct            /O Space or System Memory Space
> +pcct            Subspace Type 4 has space ID = 4 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Error Status Mask:           0x5555555555555555
>  pcct            
>  pcct            
>  pcct            ==========================================================
> -pcct            0 passed, 4 failed, 0 warning, 0 aborted, 0 skipped, 0
> +pcct            0 passed, 15 failed, 0 warning, 0 aborted, 0 skipped, 0
>  pcct            info only.
>  pcct            ==========================================================
> 
Acked-by: Colin Ian King <colin.king@canonical.com>
Ivan Hu Aug. 23, 2017, 7:02 a.m. UTC | #2 
On 08/18/2017 02:39 AM, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>   fwts-test/pcct-0001/acpidump-0001.log |  30 +++++-
>   fwts-test/pcct-0001/acpidump-0002.log |  34 +++++--
>   fwts-test/pcct-0001/pcct-0001.log     | 116 +++++++++++++++++++++--
>   fwts-test/pcct-0001/pcct-0002.log     | 169 ++++++++++++++++++++++++++++++----
>   4 files changed, 313 insertions(+), 36 deletions(-)
> 
> diff --git a/fwts-test/pcct-0001/acpidump-0001.log b/fwts-test/pcct-0001/acpidump-0001.log
> index 8aff607..9c92c2f 100644
> --- a/fwts-test/pcct-0001/acpidump-0001.log
> +++ b/fwts-test/pcct-0001/acpidump-0001.log
> @@ -24,9 +24,9 @@ FACP @ 0x00000000
>     00f0: 00 00 00 00                                      ....
>   
>   PCCT @ 0x00000000
> -  0000: 50 43 43 54 06 01 00 00 01 60 49 4e 54 45 4c 20  PCCT.....`INTEL
> -  0010: 54 45 4d 50 4c 41 54 45 01 00 00 00 49 4e 54 4c  TEMPLATE....INTL
> -  0020: 27 05 16 20 01 00 00 00 00 00 00 00 00 00 00 00  '.. ............
> +  0000: 50 43 43 54 4e 02 00 00 01 b2 49 4e 54 45 4c 20  PCCTN.....INTEL
> +  0010: 54 65 6d 70 6c 61 74 65 01 00 00 00 49 4e 54 4c  Template....INTL
> +  0020: 28 07 17 20 01 00 00 00 00 00 00 00 00 00 00 00  (.. ............
>     0030: 00 3e 00 00 00 00 00 00 11 11 11 11 11 11 11 11  .>..............
>     0040: 22 22 22 22 22 22 22 22 01 32 00 03 33 33 33 33  """""""".2..3333
>     0050: 33 33 33 33 44 44 44 44 44 44 44 44 55 55 55 55  3333DDDDDDDDUUUU
> @@ -35,10 +35,30 @@ PCCT @ 0x00000000
>     0080: 55 55 55 55 55 55 01 32 00 03 44 44 44 44 44 44  UUUUUU.2..DDDDDD
>     0090: 44 44 44 44 44 44 44 44 44 44 55 55 55 55 55 55  DDDDDDDDDDUUUUUU
>     00a0: 55 55 66 66 66 66 77 77 77 77 88 88 02 5a 01 00  UUffffwwww...Z..
> -  00b0: 00 00 03 00 00 00 00 00 00 00 00 00 99 99 99 99  ................
> +  00b0: 00 00 01 00 00 00 00 00 00 00 00 00 99 99 99 99  ................
>     00c0: 99 99 99 99 01 32 00 03 44 44 44 44 44 44 44 44  .....2..DDDDDDDD
>     00d0: 44 44 44 44 44 44 44 44 55 55 55 55 55 55 55 55  DDDDDDDDUUUUUUUU
>     00e0: 66 66 66 66 77 77 77 77 88 88 01 32 00 03 33 33  ffffwwww...2..33
>     00f0: 33 33 33 33 33 33 44 44 44 44 44 44 44 44 55 55  333333DDDDDDDDUU
> -  0100: 55 55 55 55 55 55                                UUUUUU
> +  0100: 55 55 55 55 55 55 03 a4 01 00 00 00 01 00 00 00  UUUUUU..........
> +  0110: 00 00 00 00 00 00 77 77 77 77 01 32 00 03 33 33  ......wwww.2..33
> +  0120: 33 33 33 33 33 33 44 44 44 44 44 44 44 44 55 55  333333DDDDDDDDUU
> +  0130: 55 55 55 55 55 55 66 66 66 66 77 77 77 77 88 88  UUUUUUffffwwww..
> +  0140: 88 88 01 32 00 03 33 33 33 33 33 33 33 33 99 99  ...2..33333333..
> +  0150: 99 99 99 99 99 99 00 00 00 00 00 00 00 00 00 00  ................
> +  0160: 00 00 00 00 00 00 01 32 00 03 33 33 33 33 33 33  .......2..333333
> +  0170: 33 33 22 22 22 22 22 22 22 22 01 32 00 03 33 33  33"""""""".2..33
> +  0180: 33 33 33 33 33 33 33 33 33 33 33 33 33 33 44 44  33333333333333DD
> +  0190: 44 44 44 44 44 44 01 32 00 03 33 33 33 33 33 33  DDDDDD.2..333333
> +  01a0: 33 33 55 55 55 55 55 55 55 55 04 a4 01 00 00 00  33UUUUUUUU......
> +  01b0: 01 00 00 00 00 00 00 00 00 00 88 88 88 88 01 32  ...............2
> +  01c0: 00 03 33 33 33 33 33 33 33 33 44 44 44 44 44 44  ..33333333DDDDDD
> +  01d0: 44 44 55 55 55 55 55 55 55 55 66 66 66 66 77 77  DDUUUUUUUUffffww
> +  01e0: 77 77 88 88 88 88 01 32 00 03 33 33 33 33 33 33  ww.....2..333333
> +  01f0: 33 33 99 99 99 99 99 99 99 99 00 00 00 00 00 00  33..............
> +  0200: 00 00 00 00 00 00 00 00 00 00 01 32 00 03 33 33  ...........2..33
> +  0210: 33 33 33 33 33 33 22 22 22 22 22 22 22 22 01 32  333333"""""""".2
> +  0220: 00 03 33 33 33 33 33 33 33 33 33 33 33 33 33 33  ..33333333333333
> +  0230: 33 33 44 44 44 44 44 44 44 44 01 32 00 03 33 33  33DDDDDDDD.2..33
> +  0240: 33 33 33 33 33 33 55 55 55 55 55 55 55 55        333333UUUUUUUU
>   
> diff --git a/fwts-test/pcct-0001/acpidump-0002.log b/fwts-test/pcct-0001/acpidump-0002.log
> index d98f96d..2a29dc5 100644
> --- a/fwts-test/pcct-0001/acpidump-0002.log
> +++ b/fwts-test/pcct-0001/acpidump-0002.log
> @@ -24,9 +24,9 @@ FACP @ 0x00000000
>     00f0: 00 00 00 00                                      ....
>   
>   PCCT @ 0x00000000
> -  0000: 50 43 43 54 06 01 00 00 01 57 49 4e 54 45 4c 20  PCCT.....WINTEL
> -  0010: 54 45 4d 50 4c 41 54 45 01 00 00 00 49 4e 54 4c  TEMPLATE....INTL
> -  0020: 27 05 16 20 01 00 00 00 00 00 00 00 00 00 00 00  '.. ............
> +  0000: 50 43 43 54 4e 02 00 00 01 85 49 4e 54 45 4c 20  PCCTN.....INTEL
> +  0010: 54 65 6d 70 6c 61 74 65 01 00 00 00 49 4e 54 4c  Template....INTL
> +  0020: 28 07 17 20 00 00 00 00 00 00 00 00 00 00 00 00  (.. ............
>     0030: 00 3e 00 00 00 00 00 00 11 11 11 11 11 11 11 11  .>..............
>     0040: 22 22 22 22 22 22 22 22 02 32 00 03 33 33 33 33  """""""".2..3333
>     0050: 33 33 33 33 44 44 44 44 44 44 44 44 55 55 55 55  3333DDDDDDDDUUUU
> @@ -35,10 +35,30 @@ PCCT @ 0x00000000
>     0080: 55 55 55 55 55 55 04 32 00 03 44 44 44 44 44 44  UUUUUU.2..DDDDDD
>     0090: 44 44 44 44 44 44 44 44 44 44 55 55 55 55 55 55  DDDDDDDDDDUUUUUU
>     00a0: 55 55 66 66 66 66 77 77 77 77 88 88 02 5a 01 00  UUffffwwww...Z..
> -  00b0: 00 00 03 00 00 00 00 00 00 00 00 00 99 99 99 99  ................
> +  00b0: 00 00 01 00 00 00 00 00 00 00 00 00 99 99 99 99  ................
>     00c0: 99 99 99 99 03 32 00 03 44 44 44 44 44 44 44 44  .....2..DDDDDDDD
>     00d0: 44 44 44 44 44 44 44 44 55 55 55 55 55 55 55 55  DDDDDDDDUUUUUUUU
> -  00e0: 66 66 66 66 77 77 77 77 88 88 04 32 00 03 33 33  ffffwwww...2..33
> +  00e0: 66 66 66 66 77 77 77 77 88 88 03 32 00 03 33 33  ffffwwww...2..33
>     00f0: 33 33 33 33 33 33 44 44 44 44 44 44 44 44 55 55  333333DDDDDDDDUU
> -  0100: 55 55 55 55 55 55                                UUUUUU
> -
> +  0100: 55 55 55 55 55 55 03 a4 01 00 00 00 01 00 00 00  UUUUUU..........
> +  0110: 00 00 00 00 00 00 77 77 77 77 05 32 00 03 33 33  ......wwww.2..33
> +  0120: 33 33 33 33 33 33 44 44 44 44 44 44 44 44 55 55  333333DDDDDDDDUU
> +  0130: 55 55 55 55 55 55 66 66 66 66 77 77 77 77 88 88  UUUUUUffffwwww..
> +  0140: 88 88 05 32 00 03 33 33 33 33 33 33 33 33 99 99  ...2..33333333..
> +  0150: 99 99 99 99 99 99 00 00 00 00 00 00 00 00 00 00  ................
> +  0160: 00 00 00 00 00 00 05 32 00 03 33 33 33 33 33 33  .......2..333333
> +  0170: 33 33 22 22 22 22 22 22 22 22 05 32 00 03 33 33  33"""""""".2..33
> +  0180: 33 33 33 33 33 33 33 33 33 33 33 33 33 33 44 44  33333333333333DD
> +  0190: 44 44 44 44 44 44 05 32 00 03 33 33 33 33 33 33  DDDDDD.2..333333
> +  01a0: 33 33 55 55 55 55 55 55 55 55 04 a4 01 00 00 00  33UUUUUUUU......
> +  01b0: 01 00 00 00 00 00 00 00 00 00 88 88 88 88 05 32  ...............2
> +  01c0: 00 03 33 33 33 33 33 33 33 33 44 44 44 44 44 44  ..33333333DDDDDD
> +  01d0: 44 44 55 55 55 55 55 55 55 55 66 66 66 66 77 77  DDUUUUUUUUffffww
> +  01e0: 77 77 88 88 88 88 05 32 00 03 33 33 33 33 33 33  ww.....2..333333
> +  01f0: 33 33 99 99 99 99 99 99 99 99 00 00 00 00 00 00  33..............
> +  0200: 00 00 00 00 00 00 00 00 00 00 05 32 00 03 33 33  ...........2..33
> +  0210: 33 33 33 33 33 33 22 22 22 22 22 22 22 22 04 32  333333"""""""".2
> +  0220: 00 03 33 33 33 33 33 33 33 33 33 33 33 33 33 33  ..33333333333333
> +  0230: 33 33 44 44 44 44 44 44 44 44 04 32 00 03 33 33  33DDDDDDDD.2..33
> +  0240: 33 33 33 33 33 33 55 55 55 55 55 55 55 55        333333UUUUUUUU
> +
> diff --git a/fwts-test/pcct-0001/pcct-0001.log b/fwts-test/pcct-0001/pcct-0001.log
> index d82a6bd..8703a98 100644
> --- a/fwts-test/pcct-0001/pcct-0001.log
> +++ b/fwts-test/pcct-0001/pcct-0001.log
> @@ -26,8 +26,8 @@ pcct
>   pcct              PCC Subspace Structure:
>   pcct                Type:                        0x01
>   pcct                Length:                      0x3e
> -pcct                Doorbell Interrupt:          0x00000001
> -pcct                Doorbell Interrupt Flags:    0x01
> +pcct                Platform Interrupt:          0x00000001
> +pcct                Platform Interrupt Flags:    0x01
>   pcct                Reserved:                    0x00
>   pcct                Base Address:                0x0000000000000000
>   pcct                Length:                      0x5555555555555555
> @@ -46,8 +46,8 @@ pcct
>   pcct              PCC Subspace Structure:
>   pcct                Type:                        0x02
>   pcct                Length:                      0x5a
> -pcct                Doorbell Interrupt:          0x00000001
> -pcct                Doorbell Interrupt Flags:    0x03
> +pcct                Platform Interrupt:          0x00000001
> +pcct                Platform Interrupt Flags:    0x01
>   pcct                Reserved:                    0x00
>   pcct                Base Address:                0x0000000000000000
>   pcct                Length:                      0x9999999999999999
> @@ -62,14 +62,116 @@ pcct                Doorbell Write:              0x5555555555555555
>   pcct                Nominal Latency:             0x66666666
>   pcct                Max Periodic Access Rate:    0x77777777
>   pcct                Min Request Turnaround Time: 0x00008888
> -pcct                Doorbell Ack Register:
> +pcct                Platform Interrupt Ack Register:
>   pcct                  Address Space ID           0x01
>   pcct                  Register Bit Width         0x32
>   pcct                  Register Bit Offset        0x00
>   pcct                  Access Size                0x03
>   pcct                  Address                    0x3333333333333333
> -pcct                Doorbell Ack Preserve:       0x4444444444444444
> -pcct                Doorbell Ack Write:          0x5555555555555555
> +pcct                Platform Ack Preserve:       0x4444444444444444
> +pcct                Platform Ack Write:          0x5555555555555555
> +pcct
> +pcct              PCC Subspace Structure:
> +pcct                Type:                        0x03
> +pcct                Length:                      0xa4
> +pcct                Platform Interrupt:          0x00000001
> +pcct                Platform Interrupt Flags:    0x01
> +pcct                Reserved:                    0x00
> +pcct                Base Address:                0x0000000000000000
> +pcct                Length:                      0x77777777
> +pcct                Doorbell Register:
> +pcct                  Address Space ID           0x01
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct                Doorbell Preserve:           0x4444444444444444
> +pcct                Doorbell Write:              0x5555555555555555
> +pcct                Nominal Latency:             0x66666666
> +pcct                Max Periodic Access Rate:    0x77777777
> +pcct                Min Request Turnaround Time: 0x88888888
> +pcct                Command Complete Check Register:
> +pcct                  Address Space ID           0x01
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct                Doorbell Ack Preserve:       0x9999999999999999
> +pcct                Doorbell Ack Write:          0x0000000000000000
> +pcct                Reserved:                    0x0000000000000000
> +pcct                Cmd Complete Check Register:
> +pcct                  Address Space ID           0x01
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct                Cmd Complete Check Mask:     0x2222222222222222
> +pcct                Cmd Complete Update Register:
> +pcct                  Address Space ID           0x01
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct                Cmd Complete Update Mask:    0x3333333333333333
> +pcct                Cmd Complete Set Mask:       0x3333333333333333
> +pcct                Error Status Register:
> +pcct                  Address Space ID           0x01
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct                Error Status Mask:           0x5555555555555555
> +pcct
> +pcct              PCC Subspace Structure:
> +pcct                Type:                        0x04
> +pcct                Length:                      0xa4
> +pcct                Platform Interrupt:          0x00000001
> +pcct                Platform Interrupt Flags:    0x01
> +pcct                Reserved:                    0x00
> +pcct                Base Address:                0x0000000000000000
> +pcct                Length:                      0x88888888
> +pcct                Doorbell Register:
> +pcct                  Address Space ID           0x01
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct                Doorbell Preserve:           0x4444444444444444
> +pcct                Doorbell Write:              0x5555555555555555
> +pcct                Nominal Latency:             0x66666666
> +pcct                Max Periodic Access Rate:    0x77777777
> +pcct                Min Request Turnaround Time: 0x88888888
> +pcct                Command Complete Check Register:
> +pcct                  Address Space ID           0x01
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct                Doorbell Ack Preserve:       0x9999999999999999
> +pcct                Doorbell Ack Write:          0x0000000000000000
> +pcct                Reserved:                    0x0000000000000000
> +pcct                Cmd Complete Check Register:
> +pcct                  Address Space ID           0x01
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct                Cmd Complete Check Mask:     0x2222222222222222
> +pcct                Cmd Complete Update Register:
> +pcct                  Address Space ID           0x01
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct                Cmd Complete Update Mask:    0x3333333333333333
> +pcct                Cmd Complete Set Mask:       0x3333333333333333
> +pcct                Error Status Register:
> +pcct                  Address Space ID           0x01
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct                Error Status Mask:           0x5555555555555555
>   pcct
>   pcct            PASSED: Test 1, No issues found in PCC table.
>   pcct
> diff --git a/fwts-test/pcct-0001/pcct-0002.log b/fwts-test/pcct-0001/pcct-0002.log
> index 5c80230..c2dd70f 100644
> --- a/fwts-test/pcct-0001/pcct-0002.log
> +++ b/fwts-test/pcct-0001/pcct-0002.log
> @@ -2,7 +2,7 @@ pcct            pcct: PCCT Platform Communications Channel test.
>   pcct            ----------------------------------------------------------
>   pcct            Test 1 of 1: Validate PCC table.
>   pcct            PCC Table:
> -pcct              Flags:     0x00000001
> +pcct              Flags:     0x00000000
>   pcct              Reserved:  0x0000000000000000
>   pcct
>   pcct              PCC Subspace Structure:
> @@ -24,13 +24,13 @@ pcct                Max Periodic Access Rate:    0x77777777
>   pcct                Min Request Turnaround Time: 0x00008888
>   pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
>   pcct            Subspace Type 0 has space ID = 0x02 which is not System I
> -pcct            /O Space or System Memory Space
> +pcct            /O or Memory
>   pcct
>   pcct              PCC Subspace Structure:
>   pcct                Type:                        0x01
>   pcct                Length:                      0x3e
> -pcct                Doorbell Interrupt:          0x00000001
> -pcct                Doorbell Interrupt Flags:    0x01
> +pcct                Platform Interrupt:          0x00000001
> +pcct                Platform Interrupt Flags:    0x01
>   pcct                Reserved:                    0x00
>   pcct                Base Address:                0x0000000000000000
>   pcct                Length:                      0x5555555555555555
> @@ -40,20 +40,20 @@ pcct                  Register Bit Width         0x32
>   pcct                  Register Bit Offset        0x00
>   pcct                  Access Size                0x03
>   pcct                  Address                    0x4444444444444444
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 1 has space ID = 4 which is not System I/O,
> +pcct            Memory or FFH
>   pcct                Doorbell Preserve:           0x4444444444444444
>   pcct                Doorbell Write:              0x5555555555555555
>   pcct                Nominal Latency:             0x66666666
>   pcct                Max Periodic Access Rate:    0x77777777
>   pcct                Min Request Turnaround Time: 0x00008888
> -pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> -pcct            Subspace Type 1 has space ID = 0x04 which is not System I
> -pcct            /O Space or System Memory Space
>   pcct
>   pcct              PCC Subspace Structure:
>   pcct                Type:                        0x02
>   pcct                Length:                      0x5a
> -pcct                Doorbell Interrupt:          0x00000001
> -pcct                Doorbell Interrupt Flags:    0x03
> +pcct                Platform Interrupt:          0x00000001
> +pcct                Platform Interrupt Flags:    0x01
>   pcct                Reserved:                    0x00
>   pcct                Base Address:                0x0000000000000000
>   pcct                Length:                      0x9999999999999999
> @@ -63,28 +63,163 @@ pcct                  Register Bit Width         0x32
>   pcct                  Register Bit Offset        0x00
>   pcct                  Access Size                0x03
>   pcct                  Address                    0x4444444444444444
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 2 has space ID = 3 which is not System I/O,
> +pcct            Memory or FFH
>   pcct                Doorbell Preserve:           0x4444444444444444
>   pcct                Doorbell Write:              0x5555555555555555
>   pcct                Nominal Latency:             0x66666666
>   pcct                Max Periodic Access Rate:    0x77777777
>   pcct                Min Request Turnaround Time: 0x00008888
> -pcct                Doorbell Ack Register:
> +pcct                Platform Interrupt Ack Register:
> +pcct                  Address Space ID           0x03
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 2 has space ID = 3 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Platform Ack Preserve:       0x4444444444444444
> +pcct                Platform Ack Write:          0x5555555555555555
> +pcct
> +pcct              PCC Subspace Structure:
> +pcct                Type:                        0x03
> +pcct                Length:                      0xa4
> +pcct                Platform Interrupt:          0x00000001
> +pcct                Platform Interrupt Flags:    0x01
> +pcct                Reserved:                    0x00
> +pcct                Base Address:                0x0000000000000000
> +pcct                Length:                      0x77777777
> +pcct                Doorbell Register:
> +pcct                  Address Space ID           0x05
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 3 has space ID = 5 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Doorbell Preserve:           0x4444444444444444
> +pcct                Doorbell Write:              0x5555555555555555
> +pcct                Nominal Latency:             0x66666666
> +pcct                Max Periodic Access Rate:    0x77777777
> +pcct                Min Request Turnaround Time: 0x88888888
> +pcct                Command Complete Check Register:
> +pcct                  Address Space ID           0x05
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 3 has space ID = 5 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Doorbell Ack Preserve:       0x9999999999999999
> +pcct                Doorbell Ack Write:          0x0000000000000000
> +pcct                Reserved:                    0x0000000000000000
> +pcct                Cmd Complete Check Register:
> +pcct                  Address Space ID           0x05
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 3 has space ID = 5 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Cmd Complete Check Mask:     0x2222222222222222
> +pcct                Cmd Complete Update Register:
> +pcct                  Address Space ID           0x05
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 3 has space ID = 5 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Cmd Complete Update Mask:    0x3333333333333333
> +pcct                Cmd Complete Set Mask:       0x3333333333333333
> +pcct                Error Status Register:
> +pcct                  Address Space ID           0x05
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 3 has space ID = 5 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Error Status Mask:           0x5555555555555555
> +pcct
> +pcct              PCC Subspace Structure:
> +pcct                Type:                        0x04
> +pcct                Length:                      0xa4
> +pcct            FAILED [HIGH] PCCTBadFlags: Test 1, PCCT Plaform Interrupt
> +pcct            in flags must be set when subspace type 4 is present, got
> +pcct            0x00000000 instead
> +pcct                Platform Interrupt:          0x00000001
> +pcct                Platform Interrupt Flags:    0x01
> +pcct                Reserved:                    0x00
> +pcct                Base Address:                0x0000000000000000
> +pcct                Length:                      0x88888888
> +pcct                Doorbell Register:
> +pcct                  Address Space ID           0x05
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 4 has space ID = 5 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Doorbell Preserve:           0x4444444444444444
> +pcct                Doorbell Write:              0x5555555555555555
> +pcct                Nominal Latency:             0x66666666
> +pcct                Max Periodic Access Rate:    0x77777777
> +pcct                Min Request Turnaround Time: 0x88888888
> +pcct                Command Complete Check Register:
> +pcct                  Address Space ID           0x05
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 4 has space ID = 5 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Doorbell Ack Preserve:       0x9999999999999999
> +pcct                Doorbell Ack Write:          0x0000000000000000
> +pcct                Reserved:                    0x0000000000000000
> +pcct                Cmd Complete Check Register:
> +pcct                  Address Space ID           0x05
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
> +pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> +pcct            Subspace Type 4 has space ID = 5 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Cmd Complete Check Mask:     0x2222222222222222
> +pcct                Cmd Complete Update Register:
>   pcct                  Address Space ID           0x04
>   pcct                  Register Bit Width         0x32
>   pcct                  Register Bit Offset        0x00
>   pcct                  Access Size                0x03
>   pcct                  Address                    0x3333333333333333
> -pcct                Doorbell Ack Preserve:       0x4444444444444444
> -pcct                Doorbell Ack Write:          0x5555555555555555
>   pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> -pcct            Subspace Type 2 has space ID = 0x03 which is not System I
> -pcct            /O Space or System Memory Space
> +pcct            Subspace Type 4 has space ID = 4 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Cmd Complete Update Mask:    0x3333333333333333
> +pcct                Cmd Complete Set Mask:       0x3333333333333333
> +pcct                Error Status Register:
> +pcct                  Address Space ID           0x04
> +pcct                  Register Bit Width         0x32
> +pcct                  Register Bit Offset        0x00
> +pcct                  Access Size                0x03
> +pcct                  Address                    0x3333333333333333
>   pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
> -pcct            Subspace Type 2 has space ID = 0x03 which is not System I
> -pcct            /O Space or System Memory Space
> +pcct            Subspace Type 4 has space ID = 4 which is not System I/O,
> +pcct            Memory or FFH
> +pcct                Error Status Mask:           0x5555555555555555
>   pcct
>   pcct
>   pcct            ==========================================================
> -pcct            0 passed, 4 failed, 0 warning, 0 aborted, 0 skipped, 0
> +pcct            0 passed, 15 failed, 0 warning, 0 aborted, 0 skipped, 0
>   pcct            info only.
>   pcct            ==========================================================
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox

Patch

diff --git a/fwts-test/pcct-0001/acpidump-0001.log b/fwts-test/pcct-0001/acpidump-0001.log
index 8aff607..9c92c2f 100644
--- a/fwts-test/pcct-0001/acpidump-0001.log
+++ b/fwts-test/pcct-0001/acpidump-0001.log
@@ -24,9 +24,9 @@  FACP @ 0x00000000
   00f0: 00 00 00 00                                      ....
 
 PCCT @ 0x00000000                                               
-  0000: 50 43 43 54 06 01 00 00 01 60 49 4e 54 45 4c 20  PCCT.....`INTEL 
-  0010: 54 45 4d 50 4c 41 54 45 01 00 00 00 49 4e 54 4c  TEMPLATE....INTL
-  0020: 27 05 16 20 01 00 00 00 00 00 00 00 00 00 00 00  '.. ............
+  0000: 50 43 43 54 4e 02 00 00 01 b2 49 4e 54 45 4c 20  PCCTN.....INTEL 
+  0010: 54 65 6d 70 6c 61 74 65 01 00 00 00 49 4e 54 4c  Template....INTL
+  0020: 28 07 17 20 01 00 00 00 00 00 00 00 00 00 00 00  (.. ............
   0030: 00 3e 00 00 00 00 00 00 11 11 11 11 11 11 11 11  .>..............
   0040: 22 22 22 22 22 22 22 22 01 32 00 03 33 33 33 33  """""""".2..3333
   0050: 33 33 33 33 44 44 44 44 44 44 44 44 55 55 55 55  3333DDDDDDDDUUUU
@@ -35,10 +35,30 @@  PCCT @ 0x00000000
   0080: 55 55 55 55 55 55 01 32 00 03 44 44 44 44 44 44  UUUUUU.2..DDDDDD
   0090: 44 44 44 44 44 44 44 44 44 44 55 55 55 55 55 55  DDDDDDDDDDUUUUUU
   00a0: 55 55 66 66 66 66 77 77 77 77 88 88 02 5a 01 00  UUffffwwww...Z..
-  00b0: 00 00 03 00 00 00 00 00 00 00 00 00 99 99 99 99  ................
+  00b0: 00 00 01 00 00 00 00 00 00 00 00 00 99 99 99 99  ................
   00c0: 99 99 99 99 01 32 00 03 44 44 44 44 44 44 44 44  .....2..DDDDDDDD
   00d0: 44 44 44 44 44 44 44 44 55 55 55 55 55 55 55 55  DDDDDDDDUUUUUUUU
   00e0: 66 66 66 66 77 77 77 77 88 88 01 32 00 03 33 33  ffffwwww...2..33
   00f0: 33 33 33 33 33 33 44 44 44 44 44 44 44 44 55 55  333333DDDDDDDDUU
-  0100: 55 55 55 55 55 55                                UUUUUU
+  0100: 55 55 55 55 55 55 03 a4 01 00 00 00 01 00 00 00  UUUUUU..........
+  0110: 00 00 00 00 00 00 77 77 77 77 01 32 00 03 33 33  ......wwww.2..33
+  0120: 33 33 33 33 33 33 44 44 44 44 44 44 44 44 55 55  333333DDDDDDDDUU
+  0130: 55 55 55 55 55 55 66 66 66 66 77 77 77 77 88 88  UUUUUUffffwwww..
+  0140: 88 88 01 32 00 03 33 33 33 33 33 33 33 33 99 99  ...2..33333333..
+  0150: 99 99 99 99 99 99 00 00 00 00 00 00 00 00 00 00  ................
+  0160: 00 00 00 00 00 00 01 32 00 03 33 33 33 33 33 33  .......2..333333
+  0170: 33 33 22 22 22 22 22 22 22 22 01 32 00 03 33 33  33"""""""".2..33
+  0180: 33 33 33 33 33 33 33 33 33 33 33 33 33 33 44 44  33333333333333DD
+  0190: 44 44 44 44 44 44 01 32 00 03 33 33 33 33 33 33  DDDDDD.2..333333
+  01a0: 33 33 55 55 55 55 55 55 55 55 04 a4 01 00 00 00  33UUUUUUUU......
+  01b0: 01 00 00 00 00 00 00 00 00 00 88 88 88 88 01 32  ...............2
+  01c0: 00 03 33 33 33 33 33 33 33 33 44 44 44 44 44 44  ..33333333DDDDDD
+  01d0: 44 44 55 55 55 55 55 55 55 55 66 66 66 66 77 77  DDUUUUUUUUffffww
+  01e0: 77 77 88 88 88 88 01 32 00 03 33 33 33 33 33 33  ww.....2..333333
+  01f0: 33 33 99 99 99 99 99 99 99 99 00 00 00 00 00 00  33..............
+  0200: 00 00 00 00 00 00 00 00 00 00 01 32 00 03 33 33  ...........2..33
+  0210: 33 33 33 33 33 33 22 22 22 22 22 22 22 22 01 32  333333"""""""".2
+  0220: 00 03 33 33 33 33 33 33 33 33 33 33 33 33 33 33  ..33333333333333
+  0230: 33 33 44 44 44 44 44 44 44 44 01 32 00 03 33 33  33DDDDDDDD.2..33
+  0240: 33 33 33 33 33 33 55 55 55 55 55 55 55 55        333333UUUUUUUU
 
diff --git a/fwts-test/pcct-0001/acpidump-0002.log b/fwts-test/pcct-0001/acpidump-0002.log
index d98f96d..2a29dc5 100644
--- a/fwts-test/pcct-0001/acpidump-0002.log
+++ b/fwts-test/pcct-0001/acpidump-0002.log
@@ -24,9 +24,9 @@  FACP @ 0x00000000
   00f0: 00 00 00 00                                      ....
 
 PCCT @ 0x00000000
-  0000: 50 43 43 54 06 01 00 00 01 57 49 4e 54 45 4c 20  PCCT.....WINTEL 
-  0010: 54 45 4d 50 4c 41 54 45 01 00 00 00 49 4e 54 4c  TEMPLATE....INTL
-  0020: 27 05 16 20 01 00 00 00 00 00 00 00 00 00 00 00  '.. ............
+  0000: 50 43 43 54 4e 02 00 00 01 85 49 4e 54 45 4c 20  PCCTN.....INTEL 
+  0010: 54 65 6d 70 6c 61 74 65 01 00 00 00 49 4e 54 4c  Template....INTL
+  0020: 28 07 17 20 00 00 00 00 00 00 00 00 00 00 00 00  (.. ............
   0030: 00 3e 00 00 00 00 00 00 11 11 11 11 11 11 11 11  .>..............
   0040: 22 22 22 22 22 22 22 22 02 32 00 03 33 33 33 33  """""""".2..3333
   0050: 33 33 33 33 44 44 44 44 44 44 44 44 55 55 55 55  3333DDDDDDDDUUUU
@@ -35,10 +35,30 @@  PCCT @ 0x00000000
   0080: 55 55 55 55 55 55 04 32 00 03 44 44 44 44 44 44  UUUUUU.2..DDDDDD
   0090: 44 44 44 44 44 44 44 44 44 44 55 55 55 55 55 55  DDDDDDDDDDUUUUUU
   00a0: 55 55 66 66 66 66 77 77 77 77 88 88 02 5a 01 00  UUffffwwww...Z..
-  00b0: 00 00 03 00 00 00 00 00 00 00 00 00 99 99 99 99  ................
+  00b0: 00 00 01 00 00 00 00 00 00 00 00 00 99 99 99 99  ................
   00c0: 99 99 99 99 03 32 00 03 44 44 44 44 44 44 44 44  .....2..DDDDDDDD
   00d0: 44 44 44 44 44 44 44 44 55 55 55 55 55 55 55 55  DDDDDDDDUUUUUUUU
-  00e0: 66 66 66 66 77 77 77 77 88 88 04 32 00 03 33 33  ffffwwww...2..33
+  00e0: 66 66 66 66 77 77 77 77 88 88 03 32 00 03 33 33  ffffwwww...2..33
   00f0: 33 33 33 33 33 33 44 44 44 44 44 44 44 44 55 55  333333DDDDDDDDUU
-  0100: 55 55 55 55 55 55                                UUUUUU
-                        
+  0100: 55 55 55 55 55 55 03 a4 01 00 00 00 01 00 00 00  UUUUUU..........
+  0110: 00 00 00 00 00 00 77 77 77 77 05 32 00 03 33 33  ......wwww.2..33
+  0120: 33 33 33 33 33 33 44 44 44 44 44 44 44 44 55 55  333333DDDDDDDDUU
+  0130: 55 55 55 55 55 55 66 66 66 66 77 77 77 77 88 88  UUUUUUffffwwww..
+  0140: 88 88 05 32 00 03 33 33 33 33 33 33 33 33 99 99  ...2..33333333..
+  0150: 99 99 99 99 99 99 00 00 00 00 00 00 00 00 00 00  ................
+  0160: 00 00 00 00 00 00 05 32 00 03 33 33 33 33 33 33  .......2..333333
+  0170: 33 33 22 22 22 22 22 22 22 22 05 32 00 03 33 33  33"""""""".2..33
+  0180: 33 33 33 33 33 33 33 33 33 33 33 33 33 33 44 44  33333333333333DD
+  0190: 44 44 44 44 44 44 05 32 00 03 33 33 33 33 33 33  DDDDDD.2..333333
+  01a0: 33 33 55 55 55 55 55 55 55 55 04 a4 01 00 00 00  33UUUUUUUU......
+  01b0: 01 00 00 00 00 00 00 00 00 00 88 88 88 88 05 32  ...............2
+  01c0: 00 03 33 33 33 33 33 33 33 33 44 44 44 44 44 44  ..33333333DDDDDD
+  01d0: 44 44 55 55 55 55 55 55 55 55 66 66 66 66 77 77  DDUUUUUUUUffffww
+  01e0: 77 77 88 88 88 88 05 32 00 03 33 33 33 33 33 33  ww.....2..333333
+  01f0: 33 33 99 99 99 99 99 99 99 99 00 00 00 00 00 00  33..............
+  0200: 00 00 00 00 00 00 00 00 00 00 05 32 00 03 33 33  ...........2..33
+  0210: 33 33 33 33 33 33 22 22 22 22 22 22 22 22 04 32  333333"""""""".2
+  0220: 00 03 33 33 33 33 33 33 33 33 33 33 33 33 33 33  ..33333333333333
+  0230: 33 33 44 44 44 44 44 44 44 44 04 32 00 03 33 33  33DDDDDDDD.2..33
+  0240: 33 33 33 33 33 33 55 55 55 55 55 55 55 55        333333UUUUUUUU
+
diff --git a/fwts-test/pcct-0001/pcct-0001.log b/fwts-test/pcct-0001/pcct-0001.log
index d82a6bd..8703a98 100644
--- a/fwts-test/pcct-0001/pcct-0001.log
+++ b/fwts-test/pcct-0001/pcct-0001.log
@@ -26,8 +26,8 @@  pcct
 pcct              PCC Subspace Structure:
 pcct                Type:                        0x01
 pcct                Length:                      0x3e
-pcct                Doorbell Interrupt:          0x00000001
-pcct                Doorbell Interrupt Flags:    0x01
+pcct                Platform Interrupt:          0x00000001
+pcct                Platform Interrupt Flags:    0x01
 pcct                Reserved:                    0x00
 pcct                Base Address:                0x0000000000000000
 pcct                Length:                      0x5555555555555555
@@ -46,8 +46,8 @@  pcct
 pcct              PCC Subspace Structure:
 pcct                Type:                        0x02
 pcct                Length:                      0x5a
-pcct                Doorbell Interrupt:          0x00000001
-pcct                Doorbell Interrupt Flags:    0x03
+pcct                Platform Interrupt:          0x00000001
+pcct                Platform Interrupt Flags:    0x01
 pcct                Reserved:                    0x00
 pcct                Base Address:                0x0000000000000000
 pcct                Length:                      0x9999999999999999
@@ -62,14 +62,116 @@  pcct                Doorbell Write:              0x5555555555555555
 pcct                Nominal Latency:             0x66666666
 pcct                Max Periodic Access Rate:    0x77777777
 pcct                Min Request Turnaround Time: 0x00008888
-pcct                Doorbell Ack Register:
+pcct                Platform Interrupt Ack Register:
 pcct                  Address Space ID           0x01
 pcct                  Register Bit Width         0x32
 pcct                  Register Bit Offset        0x00
 pcct                  Access Size                0x03
 pcct                  Address                    0x3333333333333333
-pcct                Doorbell Ack Preserve:       0x4444444444444444
-pcct                Doorbell Ack Write:          0x5555555555555555
+pcct                Platform Ack Preserve:       0x4444444444444444
+pcct                Platform Ack Write:          0x5555555555555555
+pcct            
+pcct              PCC Subspace Structure:
+pcct                Type:                        0x03
+pcct                Length:                      0xa4
+pcct                Platform Interrupt:          0x00000001
+pcct                Platform Interrupt Flags:    0x01
+pcct                Reserved:                    0x00
+pcct                Base Address:                0x0000000000000000
+pcct                Length:                      0x77777777
+pcct                Doorbell Register:
+pcct                  Address Space ID           0x01
+pcct                  Register Bit Width         0x32
+pcct                  Register Bit Offset        0x00
+pcct                  Access Size                0x03
+pcct                  Address                    0x3333333333333333
+pcct                Doorbell Preserve:           0x4444444444444444
+pcct                Doorbell Write:              0x5555555555555555
+pcct                Nominal Latency:             0x66666666
+pcct                Max Periodic Access Rate:    0x77777777
+pcct                Min Request Turnaround Time: 0x88888888
+pcct                Command Complete Check Register:
+pcct                  Address Space ID           0x01
+pcct                  Register Bit Width         0x32
+pcct                  Register Bit Offset        0x00
+pcct                  Access Size                0x03
+pcct                  Address                    0x3333333333333333
+pcct                Doorbell Ack Preserve:       0x9999999999999999
+pcct                Doorbell Ack Write:          0x0000000000000000
+pcct                Reserved:                    0x0000000000000000
+pcct                Cmd Complete Check Register:
+pcct                  Address Space ID           0x01
+pcct                  Register Bit Width         0x32
+pcct                  Register Bit Offset        0x00
+pcct                  Access Size                0x03
+pcct                  Address                    0x3333333333333333
+pcct                Cmd Complete Check Mask:     0x2222222222222222
+pcct                Cmd Complete Update Register:
+pcct                  Address Space ID           0x01
+pcct                  Register Bit Width         0x32
+pcct                  Register Bit Offset        0x00
+pcct                  Access Size                0x03
+pcct                  Address                    0x3333333333333333
+pcct                Cmd Complete Update Mask:    0x3333333333333333
+pcct                Cmd Complete Set Mask:       0x3333333333333333
+pcct                Error Status Register:
+pcct                  Address Space ID           0x01
+pcct                  Register Bit Width         0x32
+pcct                  Register Bit Offset        0x00
+pcct                  Access Size                0x03
+pcct                  Address                    0x3333333333333333
+pcct                Error Status Mask:           0x5555555555555555
+pcct            
+pcct              PCC Subspace Structure:
+pcct                Type:                        0x04
+pcct                Length:                      0xa4
+pcct                Platform Interrupt:          0x00000001
+pcct                Platform Interrupt Flags:    0x01
+pcct                Reserved:                    0x00
+pcct                Base Address:                0x0000000000000000
+pcct                Length:                      0x88888888
+pcct                Doorbell Register:
+pcct                  Address Space ID           0x01
+pcct                  Register Bit Width         0x32
+pcct                  Register Bit Offset        0x00
+pcct                  Access Size                0x03
+pcct                  Address                    0x3333333333333333
+pcct                Doorbell Preserve:           0x4444444444444444
+pcct                Doorbell Write:              0x5555555555555555
+pcct                Nominal Latency:             0x66666666
+pcct                Max Periodic Access Rate:    0x77777777
+pcct                Min Request Turnaround Time: 0x88888888
+pcct                Command Complete Check Register:
+pcct                  Address Space ID           0x01
+pcct                  Register Bit Width         0x32
+pcct                  Register Bit Offset        0x00
+pcct                  Access Size                0x03
+pcct                  Address                    0x3333333333333333
+pcct                Doorbell Ack Preserve:       0x9999999999999999
+pcct                Doorbell Ack Write:          0x0000000000000000
+pcct                Reserved:                    0x0000000000000000
+pcct                Cmd Complete Check Register:
+pcct                  Address Space ID           0x01
+pcct                  Register Bit Width         0x32
+pcct                  Register Bit Offset        0x00
+pcct                  Access Size                0x03
+pcct                  Address                    0x3333333333333333
+pcct                Cmd Complete Check Mask:     0x2222222222222222
+pcct                Cmd Complete Update Register:
+pcct                  Address Space ID           0x01
+pcct                  Register Bit Width         0x32
+pcct                  Register Bit Offset        0x00
+pcct                  Access Size                0x03
+pcct                  Address                    0x3333333333333333
+pcct                Cmd Complete Update Mask:    0x3333333333333333
+pcct                Cmd Complete Set Mask:       0x3333333333333333
+pcct                Error Status Register:
+pcct                  Address Space ID           0x01
+pcct                  Register Bit Width         0x32
+pcct                  Register Bit Offset        0x00
+pcct                  Access Size                0x03
+pcct                  Address                    0x3333333333333333
+pcct                Error Status Mask:           0x5555555555555555
 pcct            
 pcct            PASSED: Test 1, No issues found in PCC table.
 pcct            
diff --git a/fwts-test/pcct-0001/pcct-0002.log b/fwts-test/pcct-0001/pcct-0002.log
index 5c80230..c2dd70f 100644
--- a/fwts-test/pcct-0001/pcct-0002.log
+++ b/fwts-test/pcct-0001/pcct-0002.log
@@ -2,7 +2,7 @@  pcct            pcct: PCCT Platform Communications Channel test.
 pcct            ----------------------------------------------------------
 pcct            Test 1 of 1: Validate PCC table.
 pcct            PCC Table:
-pcct              Flags:     0x00000001
+pcct              Flags:     0x00000000
 pcct              Reserved:  0x0000000000000000
 pcct            
 pcct              PCC Subspace Structure:
@@ -24,13 +24,13 @@  pcct                Max Periodic Access Rate:    0x77777777
 pcct                Min Request Turnaround Time: 0x00008888
 pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
 pcct            Subspace Type 0 has space ID = 0x02 which is not System I
-pcct            /O Space or System Memory Space
+pcct            /O or Memory
 pcct            
 pcct              PCC Subspace Structure:
 pcct                Type:                        0x01
 pcct                Length:                      0x3e
-pcct                Doorbell Interrupt:          0x00000001
-pcct                Doorbell Interrupt Flags:    0x01
+pcct                Platform Interrupt:          0x00000001
+pcct                Platform Interrupt Flags:    0x01
 pcct                Reserved:                    0x00
 pcct                Base Address:                0x0000000000000000
 pcct                Length:                      0x5555555555555555
@@ -40,20 +40,20 @@  pcct                  Register Bit Width         0x32
 pcct                  Register Bit Offset        0x00
 pcct                  Access Size                0x03
 pcct                  Address                    0x4444444444444444
+pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
+pcct            Subspace Type 1 has space ID = 4 which is not System I/O,
+pcct            Memory or FFH
 pcct                Doorbell Preserve:           0x4444444444444444
 pcct                Doorbell Write:              0x5555555555555555
 pcct                Nominal Latency:             0x66666666
 pcct                Max Periodic Access Rate:    0x77777777
 pcct                Min Request Turnaround Time: 0x00008888
-pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
-pcct            Subspace Type 1 has space ID = 0x04 which is not System I
-pcct            /O Space or System Memory Space
 pcct            
 pcct              PCC Subspace Structure:
 pcct                Type:                        0x02
 pcct                Length:                      0x5a
-pcct                Doorbell Interrupt:          0x00000001
-pcct                Doorbell Interrupt Flags:    0x03
+pcct                Platform Interrupt:          0x00000001
+pcct                Platform Interrupt Flags:    0x01
 pcct                Reserved:                    0x00
 pcct                Base Address:                0x0000000000000000
 pcct                Length:                      0x9999999999999999
@@ -63,28 +63,163 @@  pcct                  Register Bit Width         0x32
 pcct                  Register Bit Offset        0x00
 pcct                  Access Size                0x03
 pcct                  Address                    0x4444444444444444
+pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
+pcct            Subspace Type 2 has space ID = 3 which is not System I/O,
+pcct            Memory or FFH
 pcct                Doorbell Preserve:           0x4444444444444444
 pcct                Doorbell Write:              0x5555555555555555
 pcct                Nominal Latency:             0x66666666
 pcct                Max Periodic Access Rate:    0x77777777
 pcct                Min Request Turnaround Time: 0x00008888
-pcct                Doorbell Ack Register:
+pcct                Platform Interrupt Ack Register:
+pcct                  Address Space ID           0x03
+pcct                  Register Bit Width         0x32
+pcct                  Register Bit Offset        0x00
+pcct                  Access Size                0x03
+pcct                  Address                    0x3333333333333333
+pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
+pcct            Subspace Type 2 has space ID = 3 which is not System I/O,
+pcct            Memory or FFH
+pcct                Platform Ack Preserve:       0x4444444444444444
+pcct                Platform Ack Write:          0x5555555555555555
+pcct            
+pcct              PCC Subspace Structure:
+pcct                Type:                        0x03
+pcct                Length:                      0xa4
+pcct                Platform Interrupt:          0x00000001
+pcct                Platform Interrupt Flags:    0x01
+pcct                Reserved:                    0x00
+pcct                Base Address:                0x0000000000000000
+pcct                Length:                      0x77777777
+pcct                Doorbell Register:
+pcct                  Address Space ID           0x05
+pcct                  Register Bit Width         0x32
+pcct                  Register Bit Offset        0x00
+pcct                  Access Size                0x03
+pcct                  Address                    0x3333333333333333
+pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
+pcct            Subspace Type 3 has space ID = 5 which is not System I/O,
+pcct            Memory or FFH
+pcct                Doorbell Preserve:           0x4444444444444444
+pcct                Doorbell Write:              0x5555555555555555
+pcct                Nominal Latency:             0x66666666
+pcct                Max Periodic Access Rate:    0x77777777
+pcct                Min Request Turnaround Time: 0x88888888
+pcct                Command Complete Check Register:
+pcct                  Address Space ID           0x05
+pcct                  Register Bit Width         0x32
+pcct                  Register Bit Offset        0x00
+pcct                  Access Size                0x03
+pcct                  Address                    0x3333333333333333
+pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
+pcct            Subspace Type 3 has space ID = 5 which is not System I/O,
+pcct            Memory or FFH
+pcct                Doorbell Ack Preserve:       0x9999999999999999
+pcct                Doorbell Ack Write:          0x0000000000000000
+pcct                Reserved:                    0x0000000000000000
+pcct                Cmd Complete Check Register:
+pcct                  Address Space ID           0x05
+pcct                  Register Bit Width         0x32
+pcct                  Register Bit Offset        0x00
+pcct                  Access Size                0x03
+pcct                  Address                    0x3333333333333333
+pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
+pcct            Subspace Type 3 has space ID = 5 which is not System I/O,
+pcct            Memory or FFH
+pcct                Cmd Complete Check Mask:     0x2222222222222222
+pcct                Cmd Complete Update Register:
+pcct                  Address Space ID           0x05
+pcct                  Register Bit Width         0x32
+pcct                  Register Bit Offset        0x00
+pcct                  Access Size                0x03
+pcct                  Address                    0x3333333333333333
+pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
+pcct            Subspace Type 3 has space ID = 5 which is not System I/O,
+pcct            Memory or FFH
+pcct                Cmd Complete Update Mask:    0x3333333333333333
+pcct                Cmd Complete Set Mask:       0x3333333333333333
+pcct                Error Status Register:
+pcct                  Address Space ID           0x05
+pcct                  Register Bit Width         0x32
+pcct                  Register Bit Offset        0x00
+pcct                  Access Size                0x03
+pcct                  Address                    0x3333333333333333
+pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
+pcct            Subspace Type 3 has space ID = 5 which is not System I/O,
+pcct            Memory or FFH
+pcct                Error Status Mask:           0x5555555555555555
+pcct            
+pcct              PCC Subspace Structure:
+pcct                Type:                        0x04
+pcct                Length:                      0xa4
+pcct            FAILED [HIGH] PCCTBadFlags: Test 1, PCCT Plaform Interrupt
+pcct            in flags must be set when subspace type 4 is present, got
+pcct            0x00000000 instead
+pcct                Platform Interrupt:          0x00000001
+pcct                Platform Interrupt Flags:    0x01
+pcct                Reserved:                    0x00
+pcct                Base Address:                0x0000000000000000
+pcct                Length:                      0x88888888
+pcct                Doorbell Register:
+pcct                  Address Space ID           0x05
+pcct                  Register Bit Width         0x32
+pcct                  Register Bit Offset        0x00
+pcct                  Access Size                0x03
+pcct                  Address                    0x3333333333333333
+pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
+pcct            Subspace Type 4 has space ID = 5 which is not System I/O,
+pcct            Memory or FFH
+pcct                Doorbell Preserve:           0x4444444444444444
+pcct                Doorbell Write:              0x5555555555555555
+pcct                Nominal Latency:             0x66666666
+pcct                Max Periodic Access Rate:    0x77777777
+pcct                Min Request Turnaround Time: 0x88888888
+pcct                Command Complete Check Register:
+pcct                  Address Space ID           0x05
+pcct                  Register Bit Width         0x32
+pcct                  Register Bit Offset        0x00
+pcct                  Access Size                0x03
+pcct                  Address                    0x3333333333333333
+pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
+pcct            Subspace Type 4 has space ID = 5 which is not System I/O,
+pcct            Memory or FFH
+pcct                Doorbell Ack Preserve:       0x9999999999999999
+pcct                Doorbell Ack Write:          0x0000000000000000
+pcct                Reserved:                    0x0000000000000000
+pcct                Cmd Complete Check Register:
+pcct                  Address Space ID           0x05
+pcct                  Register Bit Width         0x32
+pcct                  Register Bit Offset        0x00
+pcct                  Access Size                0x03
+pcct                  Address                    0x3333333333333333
+pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
+pcct            Subspace Type 4 has space ID = 5 which is not System I/O,
+pcct            Memory or FFH
+pcct                Cmd Complete Check Mask:     0x2222222222222222
+pcct                Cmd Complete Update Register:
 pcct                  Address Space ID           0x04
 pcct                  Register Bit Width         0x32
 pcct                  Register Bit Offset        0x00
 pcct                  Access Size                0x03
 pcct                  Address                    0x3333333333333333
-pcct                Doorbell Ack Preserve:       0x4444444444444444
-pcct                Doorbell Ack Write:          0x5555555555555555
 pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
-pcct            Subspace Type 2 has space ID = 0x03 which is not System I
-pcct            /O Space or System Memory Space
+pcct            Subspace Type 4 has space ID = 4 which is not System I/O,
+pcct            Memory or FFH
+pcct                Cmd Complete Update Mask:    0x3333333333333333
+pcct                Cmd Complete Set Mask:       0x3333333333333333
+pcct                Error Status Register:
+pcct                  Address Space ID           0x04
+pcct                  Register Bit Width         0x32
+pcct                  Register Bit Offset        0x00
+pcct                  Access Size                0x03
+pcct                  Address                    0x3333333333333333
 pcct            FAILED [HIGH] PCCTSubspaceInvalidAddrSpaceID: Test 1, PCCT
-pcct            Subspace Type 2 has space ID = 0x03 which is not System I
-pcct            /O Space or System Memory Space
+pcct            Subspace Type 4 has space ID = 4 which is not System I/O,
+pcct            Memory or FFH
+pcct                Error Status Mask:           0x5555555555555555
 pcct            
 pcct            
 pcct            ==========================================================
-pcct            0 passed, 4 failed, 0 warning, 0 aborted, 0 skipped, 0
+pcct            0 passed, 15 failed, 0 warning, 0 aborted, 0 skipped, 0
 pcct            info only.
 pcct            ==========================================================