diff mbox

[U-Boot] ARM: mvebu: set correct mem_size for db-88f6820-amc

Message ID 20170817102703.26385-1-judge.packham@gmail.com
State Accepted
Commit 6ab09b05f3707276ff84f7759f3484b597e80581
Delegated to: Stefan Roese
Headers show

Commit Message

Chris Packham Aug. 17, 2017, 10:27 a.m. UTC
The db-88f6820-amc has four chips with 2Gb density giving a total of 1GB
DRAM. Update the board_topology_map to reflect the correct
configuration.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---
When I setup this board I misinterpreted 2 Gigabits as 2 Gigabytes. It
happened to work so I never noticed it was wrong until I started seeing
some unexpected mirroring of addresses.

 board/Marvell/db-88f6820-amc/db-88f6820-amc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Roese Aug. 17, 2017, 11:46 a.m. UTC | #1
On 17.08.2017 12:27, Chris Packham wrote:
> The db-88f6820-amc has four chips with 2Gb density giving a total of 1GB
> DRAM. Update the board_topology_map to reflect the correct
> configuration.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> When I setup this board I misinterpreted 2 Gigabits as 2 Gigabytes. It
> happened to work so I never noticed it was wrong until I started seeing
> some unexpected mirroring of addresses.
> 
>   board/Marvell/db-88f6820-amc/db-88f6820-amc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/Marvell/db-88f6820-amc/db-88f6820-amc.c b/board/Marvell/db-88f6820-amc/db-88f6820-amc.c
> index 40fa59986573..ac58f9085266 100644
> --- a/board/Marvell/db-88f6820-amc/db-88f6820-amc.c
> +++ b/board/Marvell/db-88f6820-amc/db-88f6820-amc.c
> @@ -66,7 +66,7 @@ static struct hws_topology_map board_topology_map = {
>   	      {0x1, 0, 0, 0} },
>   	    SPEED_BIN_DDR_1866L,	/* speed_bin */
>   	    BUS_WIDTH_8,		/* memory_width */
> -	    MEM_4G,			/* mem_size */
> +	    MEM_2G,			/* mem_size */
>   	    DDR_FREQ_800,		/* frequency */
>   	    0, 0,			/* cas_l cas_wl */
>   	    HWS_TEMP_LOW,		/* temperature */
> 

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan
Stefan Roese Aug. 21, 2017, 9:41 a.m. UTC | #2
On 17.08.2017 13:46, Stefan Roese wrote:
> On 17.08.2017 12:27, Chris Packham wrote:
>> The db-88f6820-amc has four chips with 2Gb density giving a total of 1GB
>> DRAM. Update the board_topology_map to reflect the correct
>> configuration.
>>
>> Signed-off-by: Chris Packham <judge.packham@gmail.com>
>> ---
>> When I setup this board I misinterpreted 2 Gigabits as 2 Gigabytes. It
>> happened to work so I never noticed it was wrong until I started seeing
>> some unexpected mirroring of addresses.
>>
>>   board/Marvell/db-88f6820-amc/db-88f6820-amc.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/board/Marvell/db-88f6820-amc/db-88f6820-amc.c 
>> b/board/Marvell/db-88f6820-amc/db-88f6820-amc.c
>> index 40fa59986573..ac58f9085266 100644
>> --- a/board/Marvell/db-88f6820-amc/db-88f6820-amc.c
>> +++ b/board/Marvell/db-88f6820-amc/db-88f6820-amc.c
>> @@ -66,7 +66,7 @@ static struct hws_topology_map board_topology_map = {
>>             {0x1, 0, 0, 0} },
>>           SPEED_BIN_DDR_1866L,    /* speed_bin */
>>           BUS_WIDTH_8,        /* memory_width */
>> -        MEM_4G,            /* mem_size */
>> +        MEM_2G,            /* mem_size */
>>           DDR_FREQ_800,        /* frequency */
>>           0, 0,            /* cas_l cas_wl */
>>           HWS_TEMP_LOW,        /* temperature */
>>
> 
> Reviewed-by: Stefan Roese <sr@denx.de>

Applied to u-boot-marvell/master.

Thanks,
Stefan
diff mbox

Patch

diff --git a/board/Marvell/db-88f6820-amc/db-88f6820-amc.c b/board/Marvell/db-88f6820-amc/db-88f6820-amc.c
index 40fa59986573..ac58f9085266 100644
--- a/board/Marvell/db-88f6820-amc/db-88f6820-amc.c
+++ b/board/Marvell/db-88f6820-amc/db-88f6820-amc.c
@@ -66,7 +66,7 @@  static struct hws_topology_map board_topology_map = {
 	      {0x1, 0, 0, 0} },
 	    SPEED_BIN_DDR_1866L,	/* speed_bin */
 	    BUS_WIDTH_8,		/* memory_width */
-	    MEM_4G,			/* mem_size */
+	    MEM_2G,			/* mem_size */
 	    DDR_FREQ_800,		/* frequency */
 	    0, 0,			/* cas_l cas_wl */
 	    HWS_TEMP_LOW,		/* temperature */