diff mbox

[v3] Fix Country name for xh_ZA

Message ID 1502959765-7379-1-git-send-email-akhilesh.k@samsung.com
State New
Headers show

Commit Message

Akhilesh Kumar Aug. 17, 2017, 8:49 a.m. UTC
[BZ #21959]
 	locales/xh_ZA: Fix country_name

---
 localedata/locales/xh_ZA |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

Comments

Mike FABIAN Aug. 17, 2017, 9:07 a.m. UTC | #1
Akhilesh Kumar <akhilesh.k@samsung.com> wrote:

> [BZ #21959]
>  	locales/xh_ZA: Fix country_name
>
> ---
>  localedata/locales/xh_ZA |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/localedata/locales/xh_ZA b/localedata/locales/xh_ZA
> index e01a620..8fb69da 100644
> --- a/localedata/locales/xh_ZA
> +++ b/localedata/locales/xh_ZA
> @@ -217,9 +217,8 @@ name_ms     ""
>  END LC_NAME
>  
>  LC_ADDRESS
> -% Country name in Xhosa - "Mzantsi Afrika"
> -country_name "<U004D><U007A><U0061><U006E><U0074><U0073><U0069><U0020>/
> -<U0041><U0066><U0072><U0069><U006B><U0061>"
> +% https://xh.wikipedia.org/wiki/UMzantsi_Afrika
> +country_name "UMzantsi Afrika"
>  %
>  % Abbreviated country postal name - "ZA"
>  country_post "<U005A><U0041>"

committed.
Rafal Luzynski Aug. 17, 2017, 10:02 a.m. UTC | #2
17.08.2017 11:07 Mike FABIAN <mfabian@redhat.com> wrote:
>
>
> Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>
> > [BZ #21959]
> > locales/xh_ZA: Fix country_name
> >
> > ---
> > localedata/locales/xh_ZA | 5 ++---
> > 1 files changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/localedata/locales/xh_ZA b/localedata/locales/xh_ZA
> > index e01a620..8fb69da 100644
> > --- a/localedata/locales/xh_ZA
> > +++ b/localedata/locales/xh_ZA
> > @@ -217,9 +217,8 @@ name_ms ""
> > END LC_NAME
> >
> > LC_ADDRESS
> > -% Country name in Xhosa - "Mzantsi Afrika"
> > -country_name "<U004D><U007A><U0061><U006E><U0074><U0073><U0069><U0020>/
> > -<U0041><U0066><U0072><U0069><U006B><U0061>"
> > +% https://xh.wikipedia.org/wiki/UMzantsi_Afrika
> > +country_name "UMzantsi Afrika"

The same wiki article also contains "uMzantsi Afrika" as its title,
with the lowercase "u" despite it's in the beginning of a sentence.
At the same time, CLDR says "eMzantsi Afrika":

http://st.unicode.org/cldr-apps/v#/xh/T_Africa/

> > %
> > % Abbreviated country postal name - "ZA"
> > country_post "<U005A><U0041>"
>
> committed.

OK, let's leave it as it has been committed.  I'm not telling this
is wrong, I'm telling that with the variety of versions I don't know
which is correct and it may be changed in future, for example if
a native speaker requests.

Regards,

Rafal
Mike FABIAN Aug. 17, 2017, 2:07 p.m. UTC | #3
Rafal Luzynski <digitalfreak@lingonborough.com> wrote:

> 17.08.2017 11:07 Mike FABIAN <mfabian@redhat.com> wrote:
>>
>>
>> Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>>
>> > [BZ #21959]
>> > locales/xh_ZA: Fix country_name
>> >
>> > ---
>> > localedata/locales/xh_ZA | 5 ++---
>> > 1 files changed, 2 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/localedata/locales/xh_ZA b/localedata/locales/xh_ZA
>> > index e01a620..8fb69da 100644
>> > --- a/localedata/locales/xh_ZA
>> > +++ b/localedata/locales/xh_ZA
>> > @@ -217,9 +217,8 @@ name_ms ""
>> > END LC_NAME
>> >
>> > LC_ADDRESS
>> > -% Country name in Xhosa - "Mzantsi Afrika"
>> > -country_name "<U004D><U007A><U0061><U006E><U0074><U0073><U0069><U0020>/
>> > -<U0041><U0066><U0072><U0069><U006B><U0061>"
>> > +% https://xh.wikipedia.org/wiki/UMzantsi_Afrika
>> > +country_name "UMzantsi Afrika"
>
> The same wiki article also contains "uMzantsi Afrika" as its title,
> with the lowercase "u" despite it's in the beginning of a sentence.
> At the same time, CLDR says "eMzantsi Afrika":
>
> http://st.unicode.org/cldr-apps/v#/xh/T_Africa/
>
>> > %
>> > % Abbreviated country postal name - "ZA"
>> > country_post "<U005A><U0041>"
>>
>> committed.
>
> OK, let's leave it as it has been committed.  I'm not telling this
> is wrong, I'm telling that with the variety of versions I don't know
> which is correct and it may be changed in future, for example if
> a native speaker requests.

Yes, it looks a bit difficult.

The CLDR value from the survey tool
http://st.unicode.org/cldr-apps/v#/xh/T_Africa/ is probably also
preliminary because there is no
http://www.unicode.org/repos/cldr/trunk/common/main/xh.xml yet.
Akhilesh Kumar Aug. 18, 2017, 3:47 a.m. UTC | #4
> As a general rule I don't think we should make changes based only on Wikipedia. Please at least check their references, and cite the primary source in the locale file.

I believe  wiki page in locale language is more trusty (specific to locale information like Country name specific to that country, week, months for that locale etc  ) then other sources. 
Like locale page for indian language. 
 



>> The same wiki article also contains "uMzantsi Afrika" as its title,

>> with the lowercase "u" despite it's in the beginning of a sentence.

>> At the same time, CLDR says "eMzantsi Afrika":


>> OK, let's leave it as it has been committed.  I'm not telling this

> is wrong, I'm telling that with the variety of versions I don't know

> which is correct and it may be changed in future, for example if

> a native speaker requests.


> Yes, it looks a bit difficult.


> The CLDR value from the survey tool
> http://st.unicode.org/cldr-apps/v#/xh/T_Africa/ is probably also

> preliminary because there is no
> http://www.unicode.org/repos/cldr/trunk/common/main/xh.xml yet.

Akhilesh
Mike FABIAN Aug. 18, 2017, 4:21 p.m. UTC | #5
Zack Weinberg <zackw@panix.com> wrote:

> On Thu, Aug 17, 2017 at 11:54 PM AKHILESH KUMAR <akhilesh.k@samsung.com>
> wrote:
>
>> > As a general rule I don't think we should make changes based only on
>> Wikipedia. Please at least check their references, and cite the primary
>> source in the locale file.
>>
>> I believe  wiki page in locale language is more trusty (specific to locale
>> information like Country name specific to that country, week, months for
>> that locale etc  ) then other sources.
>> Like locale page for indian language.
>
>
> I don't agree with that. Anyone can change anything on a Wikipedia page,
> and in these less-used-online languages, if something is wrong it's likely
> that no one will notice, perhaps for years. Locale definitions should be
> derived from primary sources, not Wikipedia.

I agree with Zack.
diff mbox

Patch

diff --git a/localedata/locales/xh_ZA b/localedata/locales/xh_ZA
index e01a620..8fb69da 100644
--- a/localedata/locales/xh_ZA
+++ b/localedata/locales/xh_ZA
@@ -217,9 +217,8 @@  name_ms     ""
 END LC_NAME
 
 LC_ADDRESS
-% Country name in Xhosa - "Mzantsi Afrika"
-country_name "<U004D><U007A><U0061><U006E><U0074><U0073><U0069><U0020>/
-<U0041><U0066><U0072><U0069><U006B><U0061>"
+% https://xh.wikipedia.org/wiki/UMzantsi_Afrika
+country_name "UMzantsi Afrika"
 %
 % Abbreviated country postal name - "ZA"
 country_post "<U005A><U0041>"