diff mbox

[U-Boot,v2,1/2] armv8: mmu: remove unused macro definition

Message ID 1502956501-16583-1-git-send-email-andy.yan@rock-chips.com
State Accepted
Commit 4f84cb980fdc25d7735fe114021b4a84ea601b9f
Delegated to: Tom Rini
Headers show

Commit Message

Andy Yan Aug. 17, 2017, 7:55 a.m. UTC
Macro VA_BITS and PTE_BLOCK_BITS are not used
in the code, so remove them.

Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

---

Changes in v2:
- remove CONFIG_SYS_PTL2_BITS from the whitelist

 arch/arm/include/asm/armv8/mmu.h | 9 ---------
 scripts/config_whitelist.txt     | 2 --
 2 files changed, 11 deletions(-)

Comments

Andy Yan Aug. 31, 2017, 11:52 a.m. UTC | #1
ping


On 2017年08月17日 15:55, Andy Yan wrote:
> Macro VA_BITS and PTE_BLOCK_BITS are not used
> in the code, so remove them.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>
> ---
>
> Changes in v2:
> - remove CONFIG_SYS_PTL2_BITS from the whitelist
>
>   arch/arm/include/asm/armv8/mmu.h | 9 ---------
>   scripts/config_whitelist.txt     | 2 --
>   2 files changed, 11 deletions(-)
>
> diff --git a/arch/arm/include/asm/armv8/mmu.h b/arch/arm/include/asm/armv8/mmu.h
> index a349903..7752741 100644
> --- a/arch/arm/include/asm/armv8/mmu.h
> +++ b/arch/arm/include/asm/armv8/mmu.h
> @@ -8,15 +8,6 @@
>   #ifndef _ASM_ARMV8_MMU_H_
>   #define _ASM_ARMV8_MMU_H_
>   
> -/***************************************************************/
> -/*
> - * The following definitions are related each other, shoud be
> - * calculated specifically.
> - */
> -
> -#define VA_BITS			CONFIG_SYS_VA_BITS
> -#define PTE_BLOCK_BITS		CONFIG_SYS_PTL2_BITS
> -
>   /*
>    * block/section address mask and size definitions.
>    */
> diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt
> index db28457..63b8b25 100644
> --- a/scripts/config_whitelist.txt
> +++ b/scripts/config_whitelist.txt
> @@ -4440,7 +4440,6 @@ CONFIG_SYS_PSDPAR
>   CONFIG_SYS_PSSR_VAL
>   CONFIG_SYS_PTCPAR
>   CONFIG_SYS_PTDPAR
> -CONFIG_SYS_PTL2_BITS
>   CONFIG_SYS_PTV
>   CONFIG_SYS_PUAPAR
>   CONFIG_SYS_QE_FMAN_FW_IN_MMC
> @@ -4815,7 +4814,6 @@ CONFIG_SYS_USE_SERIALFLASH
>   CONFIG_SYS_USE_SPIFLASH
>   CONFIG_SYS_USR_EXCEP
>   CONFIG_SYS_U_BOOT_OFFS
> -CONFIG_SYS_VA_BITS
>   CONFIG_SYS_VCXK_ACKNOWLEDGE_DDR
>   CONFIG_SYS_VCXK_ACKNOWLEDGE_PIN
>   CONFIG_SYS_VCXK_ACKNOWLEDGE_PORT
York Sun Aug. 31, 2017, 2:53 p.m. UTC | #2
On 08/17/2017 12:55 AM, Andy Yan wrote:
> Macro VA_BITS and PTE_BLOCK_BITS are not used
> in the code, so remove them.
> 
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> 
> ---
> 
> Changes in v2:
> - remove CONFIG_SYS_PTL2_BITS from the whitelist
> 
>   arch/arm/include/asm/armv8/mmu.h | 9 ---------
>   scripts/config_whitelist.txt     | 2 --
>   2 files changed, 11 deletions(-)
> 

Reviewed-by: York Sun <york.sun@nxp.com>
Tom Rini Sept. 13, 2017, 2:29 a.m. UTC | #3
On Thu, Aug 17, 2017 at 03:55:01PM +0800, Andy Yan wrote:

> Macro VA_BITS and PTE_BLOCK_BITS are not used
> in the code, so remove them.
> 
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: York Sun <york.sun@nxp.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/arch/arm/include/asm/armv8/mmu.h b/arch/arm/include/asm/armv8/mmu.h
index a349903..7752741 100644
--- a/arch/arm/include/asm/armv8/mmu.h
+++ b/arch/arm/include/asm/armv8/mmu.h
@@ -8,15 +8,6 @@ 
 #ifndef _ASM_ARMV8_MMU_H_
 #define _ASM_ARMV8_MMU_H_
 
-/***************************************************************/
-/*
- * The following definitions are related each other, shoud be
- * calculated specifically.
- */
-
-#define VA_BITS			CONFIG_SYS_VA_BITS
-#define PTE_BLOCK_BITS		CONFIG_SYS_PTL2_BITS
-
 /*
  * block/section address mask and size definitions.
  */
diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt
index db28457..63b8b25 100644
--- a/scripts/config_whitelist.txt
+++ b/scripts/config_whitelist.txt
@@ -4440,7 +4440,6 @@  CONFIG_SYS_PSDPAR
 CONFIG_SYS_PSSR_VAL
 CONFIG_SYS_PTCPAR
 CONFIG_SYS_PTDPAR
-CONFIG_SYS_PTL2_BITS
 CONFIG_SYS_PTV
 CONFIG_SYS_PUAPAR
 CONFIG_SYS_QE_FMAN_FW_IN_MMC
@@ -4815,7 +4814,6 @@  CONFIG_SYS_USE_SERIALFLASH
 CONFIG_SYS_USE_SPIFLASH
 CONFIG_SYS_USR_EXCEP
 CONFIG_SYS_U_BOOT_OFFS
-CONFIG_SYS_VA_BITS
 CONFIG_SYS_VCXK_ACKNOWLEDGE_DDR
 CONFIG_SYS_VCXK_ACKNOWLEDGE_PIN
 CONFIG_SYS_VCXK_ACKNOWLEDGE_PORT