diff mbox

[net-next] net: sched: cls_flower: fix ndo_setup_tc type for stats call

Message ID 20170816151518.4554-1-jiri@resnulli.us
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Jiri Pirko Aug. 16, 2017, 3:15 p.m. UTC 
From: Jiri Pirko <jiri@mellanox.com>

I made a stupid mistake using TC_CLSFLOWER_STATS instead of
TC_SETUP_CLSFLOWER. Funny thing is that both are defined as "2" so it
actually did not cause any harm. Anyway, fixing it now.

Fixes: 2572ac53c46f ("net: sched: make type an argument for ndo_setup_tc")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
 net/sched/cls_flower.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller Aug. 16, 2017, 9:30 p.m. UTC | #1 
From: Jiri Pirko <jiri@resnulli.us>
Date: Wed, 16 Aug 2017 17:15:18 +0200

> From: Jiri Pirko <jiri@mellanox.com>
> 
> I made a stupid mistake using TC_CLSFLOWER_STATS instead of
> TC_SETUP_CLSFLOWER. Funny thing is that both are defined as "2" so it
> actually did not cause any harm. Anyway, fixing it now.
> 
> Fixes: 2572ac53c46f ("net: sched: make type an argument for ndo_setup_tc")
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>

Applied, thanks Jiri.
diff mbox

Patch

diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c
index 052e902..bd9dab4 100644
--- a/net/sched/cls_flower.c
+++ b/net/sched/cls_flower.c
@@ -289,7 +289,7 @@  static void fl_hw_update_stats(struct tcf_proto *tp, struct cls_fl_filter *f)
 	cls_flower.cookie = (unsigned long) f;
 	cls_flower.exts = &f->exts;
 
-	dev->netdev_ops->ndo_setup_tc(dev, TC_CLSFLOWER_STATS,
+	dev->netdev_ops->ndo_setup_tc(dev, TC_SETUP_CLSFLOWER,
 				      &cls_flower);
 }