Patchwork [7/8] configure: Fix spice probe

login
register
mail settings
Submitter Gerd Hoffmann
Date Jan. 24, 2011, 4:20 p.m.
Message ID <1295886049-30548-8-git-send-email-kraxel@redhat.com>
Download mbox | patch
Permalink /patch/80205/
State New
Headers show

Comments

Gerd Hoffmann - Jan. 24, 2011, 4:20 p.m.
From: Jiri Denemark <Jiri.Denemark@gmail.com>

Non-existent $pkgconfig instead of $pkg_config was used when configure
probes for spice availability.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 configure |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Paolo Bonzini - Jan. 28, 2011, 1:37 p.m.
On 01/24/2011 05:20 PM, Gerd Hoffmann wrote:
> From: Jiri Denemark<Jiri.Denemark@gmail.com>
>
> Non-existent $pkgconfig instead of $pkg_config was used when configure
> probes for spice availability.
>
> Signed-off-by: Jiri Denemark<jdenemar@redhat.com>
> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
> ---
>   configure |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index 210670c..dc469b2 100755
> --- a/configure
> +++ b/configure
> @@ -2207,9 +2207,9 @@ if test "$spice" != "no" ; then
>   #include<spice.h>
>   int main(void) { spice_server_new(); return 0; }
>   EOF
> -  spice_cflags=$($pkgconfig --cflags spice-protocol spice-server 2>/dev/null)
> -  spice_libs=$($pkgconfig --libs spice-protocol spice-server 2>/dev/null)
> -  if $pkgconfig --atleast-version=0.5.3 spice-server>/dev/null 2>&1&&  \
> +  spice_cflags=$($pkg_config --cflags spice-protocol spice-server 2>/dev/null)
> +  spice_libs=$($pkg_config --libs spice-protocol spice-server 2>/dev/null)
> +  if $pkg_config --atleast-version=0.5.3 spice-server>/dev/null 2>&1&&  \
>        compile_prog "$spice_cflags" "$spice_libs" ; then
>       spice="yes"
>       libs_softmmu="$libs_softmmu $spice_libs"

Don't know about the rest of the series, but this one is definitely 0.14 
material as SPICE doesn't work otherwise.

Paolo

Patch

diff --git a/configure b/configure
index 210670c..dc469b2 100755
--- a/configure
+++ b/configure
@@ -2207,9 +2207,9 @@  if test "$spice" != "no" ; then
 #include <spice.h>
 int main(void) { spice_server_new(); return 0; }
 EOF
-  spice_cflags=$($pkgconfig --cflags spice-protocol spice-server 2>/dev/null)
-  spice_libs=$($pkgconfig --libs spice-protocol spice-server 2>/dev/null)
-  if $pkgconfig --atleast-version=0.5.3 spice-server >/dev/null 2>&1 && \
+  spice_cflags=$($pkg_config --cflags spice-protocol spice-server 2>/dev/null)
+  spice_libs=$($pkg_config --libs spice-protocol spice-server 2>/dev/null)
+  if $pkg_config --atleast-version=0.5.3 spice-server >/dev/null 2>&1 && \
      compile_prog "$spice_cflags" "$spice_libs" ; then
     spice="yes"
     libs_softmmu="$libs_softmmu $spice_libs"