diff mbox

[U-Boot] armv8: mmu: remove unused macro definition

Message ID 1502871418-2137-1-git-send-email-andy.yan@rock-chips.com
State Superseded
Delegated to: Tom Rini
Headers show

Commit Message

Andy Yan Aug. 16, 2017, 8:16 a.m. UTC
Macro VA_BITS and PTE_BLOCK_BITS are not used
in the code, so remove them.

Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---

 arch/arm/include/asm/armv8/mmu.h | 9 ---------
 scripts/config_whitelist.txt     | 1 -
 2 files changed, 10 deletions(-)

Comments

Philipp Tomsich Aug. 16, 2017, 8:20 a.m. UTC | #1
> On 16 Aug 2017, at 10:16, Andy Yan <andy.yan@rock-chips.com> wrote:
> 
> Macro VA_BITS and PTE_BLOCK_BITS are not used
> in the code, so remove them.
> 
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> —

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

See below for a requested change.

> 
> arch/arm/include/asm/armv8/mmu.h | 9 ---------
> scripts/config_whitelist.txt     | 1 -
> 2 files changed, 10 deletions(-)
> 
> diff --git a/arch/arm/include/asm/armv8/mmu.h b/arch/arm/include/asm/armv8/mmu.h
> index a349903..7752741 100644
> --- a/arch/arm/include/asm/armv8/mmu.h
> +++ b/arch/arm/include/asm/armv8/mmu.h
> @@ -8,15 +8,6 @@
> #ifndef _ASM_ARMV8_MMU_H_
> #define _ASM_ARMV8_MMU_H_
> 
> -/***************************************************************/
> -/*
> - * The following definitions are related each other, shoud be
> - * calculated specifically.
> - */
> -
> -#define VA_BITS			CONFIG_SYS_VA_BITS
> -#define PTE_BLOCK_BITS		CONFIG_SYS_PTL2_BITS

You missed removing CONFIG_SYS_PTL2_BITS from the whitelist.

> -
> /*
>  * block/section address mask and size definitions.
>  */
> diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt
> index db28457..5bf5daf 100644
> --- a/scripts/config_whitelist.txt
> +++ b/scripts/config_whitelist.txt
> @@ -4815,7 +4815,6 @@ CONFIG_SYS_USE_SERIALFLASH
> CONFIG_SYS_USE_SPIFLASH
> CONFIG_SYS_USR_EXCEP
> CONFIG_SYS_U_BOOT_OFFS
> -CONFIG_SYS_VA_BITS
> CONFIG_SYS_VCXK_ACKNOWLEDGE_DDR
> CONFIG_SYS_VCXK_ACKNOWLEDGE_PIN
> CONFIG_SYS_VCXK_ACKNOWLEDGE_PORT
> -- 
> 2.7.4
> 
>
diff mbox

Patch

diff --git a/arch/arm/include/asm/armv8/mmu.h b/arch/arm/include/asm/armv8/mmu.h
index a349903..7752741 100644
--- a/arch/arm/include/asm/armv8/mmu.h
+++ b/arch/arm/include/asm/armv8/mmu.h
@@ -8,15 +8,6 @@ 
 #ifndef _ASM_ARMV8_MMU_H_
 #define _ASM_ARMV8_MMU_H_
 
-/***************************************************************/
-/*
- * The following definitions are related each other, shoud be
- * calculated specifically.
- */
-
-#define VA_BITS			CONFIG_SYS_VA_BITS
-#define PTE_BLOCK_BITS		CONFIG_SYS_PTL2_BITS
-
 /*
  * block/section address mask and size definitions.
  */
diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt
index db28457..5bf5daf 100644
--- a/scripts/config_whitelist.txt
+++ b/scripts/config_whitelist.txt
@@ -4815,7 +4815,6 @@  CONFIG_SYS_USE_SERIALFLASH
 CONFIG_SYS_USE_SPIFLASH
 CONFIG_SYS_USR_EXCEP
 CONFIG_SYS_U_BOOT_OFFS
-CONFIG_SYS_VA_BITS
 CONFIG_SYS_VCXK_ACKNOWLEDGE_DDR
 CONFIG_SYS_VCXK_ACKNOWLEDGE_PIN
 CONFIG_SYS_VCXK_ACKNOWLEDGE_PORT