Message ID | 1502859419-33696-9-git-send-email-Zhiqiang.Hou@nxp.com |
---|---|
State | Changes Requested |
Headers | show
Return-Path: <linux-pci-owner@vger.kernel.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=<UNKNOWN>) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xXHZm4JD8z9sRV for <incoming@patchwork.ozlabs.org>; Wed, 16 Aug 2017 15:14:24 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751461AbdHPFOX (ORCPT <rfc822;incoming@patchwork.ozlabs.org>); Wed, 16 Aug 2017 01:14:23 -0400 Received: from mail-sn1nam01on0067.outbound.protection.outlook.com ([104.47.32.67]:39183 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750912AbdHPFOW (ORCPT <rfc822;linux-pci@vger.kernel.org>); Wed, 16 Aug 2017 01:14:22 -0400 Received: from CY4PR03CA0096.namprd03.prod.outlook.com (2603:10b6:910:4d::37) by SN2PR03MB2270.namprd03.prod.outlook.com (2603:10b6:804:d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1341.21; Wed, 16 Aug 2017 05:14:21 +0000 Received: from BL2FFO11FD032.protection.gbl (207.46.163.211) by CY4PR03CA0096.outlook.office365.com (10.171.242.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1341.21 via Frontend Transport; Wed, 16 Aug 2017 05:14:21 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD032.mail.protection.outlook.com (10.173.160.73) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1304.16 via Frontend Transport; Wed, 16 Aug 2017 05:14:20 +0000 Received: from titan.ap.freescale.net ([10.192.208.233]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v7G5DiU7012144; Tue, 15 Aug 2017 22:14:16 -0700 From: Zhiqiang Hou <Zhiqiang.Hou@nxp.com> To: <linux-pci@vger.kernel.org>, <bhelgaas@google.com>, <jingoohan1@gmail.com>, <Joao.Pinto@synopsys.com> CC: <minghuan.lian@nxp.com>, <mingkai.hu@nxp.com>, <roy.zang@nxp.com>, <svarbanov@mm-sol.com>, <niklas.cassel@axis.com>, <jesper.nilsson@axis.com>, Hou Zhiqiang <Zhiqiang.Hou@nxp.com> Subject: [PATCHv3 8/9] PCI: designware: enable write permission before updating DBI RO registers Date: Wed, 16 Aug 2017 12:56:58 +0800 Message-ID: <1502859419-33696-9-git-send-email-Zhiqiang.Hou@nxp.com> X-Mailer: git-send-email 2.1.0.27.g96db324 In-Reply-To: <1502859419-33696-1-git-send-email-Zhiqiang.Hou@nxp.com> References: <1502859419-33696-1-git-send-email-Zhiqiang.Hou@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131473340605393661; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39860400002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(48376002)(106466001)(54906002)(86362001)(50466002)(2906002)(4326008)(8656003)(53936002)(105606002)(626005)(68736007)(498600001)(97736004)(76176999)(50986999)(72206003)(39060400002)(5003940100001)(81156014)(81166006)(8676002)(305945005)(77096006)(356003)(6666003)(5660300001)(2950100002)(7416002)(50226002)(8936002)(36756003)(85426001)(47776003)(189998001)(104016004)(2201001)(2101003); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR03MB2270; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL2FFO11FD032; 1:swInyRRK1m96Vmb2ozaSyzF8lZpxgZT2edWoTrWCpK?= =?us-ascii?Q?vNOQXJdap/lBTbrbk/4/b+LbrA1pM6RFeAV3mhYbmV4uXRrE2UTtaN/d5zA1?= =?us-ascii?Q?Q1/urOJNJA+8I14lCz30Zk4JrKcyBsLJY+YHCs/Q2k/Md+R3t6l50XTlzAVK?= =?us-ascii?Q?qaSOv/bvPZXXWye3Kgr0e09FsNSqKr2zDGSfS2TXFL+IF0HzP1hoql84pl+X?= =?us-ascii?Q?6+t2BpBUoWGgaccfJqcKzDsrcEHiD8QoGh7ni3lylQCUcLgQ44MbNAL+4iL0?= =?us-ascii?Q?yMGrXAtVss86vU2NsfheeyCR0hOlnr3D9txnPxgn1uipEBm2XN0oPgVri4Vm?= =?us-ascii?Q?gGOX4wviX/ihkvyPAHyfXRQiPC7NpWeG/Ne2ZXsnZKpno1aDT9uKmI9fac2T?= =?us-ascii?Q?xDKZocWQqxt09UMLxrqmyTr1ni0Ai/Jxs2maX0M6MGKPI53bHjKRKgam77mA?= =?us-ascii?Q?W7AXsm3B4cs6uqG7biRAZ/GM6Mo05ies8i+SlWxoTI/B2nWwScVElnhab1SM?= =?us-ascii?Q?IRbsV1NfsPoAAmUnI0ZwAVv63RfI7r/fskI+w8I2y9PnsKfSh5kgx6mB0GCc?= =?us-ascii?Q?yNKm4cB7hfcN3b8VlnQKjqDwpTxYxGkPtVSdWo135anxzWhynmSlb6INDtsi?= =?us-ascii?Q?1EbbUOLKyUscxNJjmmUBceLx/otzy7LKGfu2rnObh5pM7+bg/kVZI0iekl6c?= =?us-ascii?Q?mhF34lJePpLRXLKx6B+rZ4GjkGbgai4AKwCx5CTjU7cIfbLUVjX0a2h7RFX8?= =?us-ascii?Q?/7+d5p7DnJnlMGUt802jAbHZRUbOQLogb6fA7WWwCcJHxzw1mV+xqlO1zVRk?= =?us-ascii?Q?DQNhju4MtxAO71kbxRCE0/JuRz/jo/f2P1azHu797d9DuEjcC+jXWNIRofqd?= =?us-ascii?Q?o/LFYJdPPebRoWWS4j71yINgvgryUE3Nsn32G7iEFaik9BBAXV1Eh6ycF/IJ?= =?us-ascii?Q?EJEMNpgQ0wC52JpzfHznrbm1y9gF5CizNkfRd6dQ=3D=3D?= MIME-Version: 1.0 Content-Type: text/plain X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d521048c-74c6-4cf0-dff5-08d4e465a69b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603031)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:SN2PR03MB2270; X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2270; 3:0hmIaepgGFztGFOSNhK6mORKl057BPrEJltcb7xljSC5hpMl7z44LEMnHwLU/BRqVE6TRGEIAISFitsCNkwCvwM8Kp9JyvqNw1c/DsayUUeJUzU5KFcMaADhi115Q4Id8TfkP0Wum9qsa+8Gq0g+Pwvv4FMW4Nzmf/ap9vcNxobVBRTfmVvDw7BNPhJCV/NNVXsyGQ0bCap+ZSNrlnZkSgesi3+g15nYs4jVBiPjJVC/mXmclSxzdTrvXCDKWvsOag1+GUH0nnwIlS2U5hNuCnWRdmjf3PvMLw4mIH0PEf/gLxFLNy6qm5gSnF+q97FexOIfCExy/rmgyByVz50pbG/v6KEB9PY1+ZUT/OPwvAw=; 25:6iIxOQpCfwxtLnXbnGdNwJyEDFR75ThccMt25bDWE5K+3e8He8uun5d9nU8SDiHn/h2xVh4yvH/SvOTTBlAUecRKV93+9CubaoJFCCvdtHFTsIMfI1OyHki//9Q3CrcYMeBWsex8NMmUlNTu+zlnCcx7nDLz8smKYjLM1U7c5sRRxeesZISI+ELCk9o56GnahTmQcs6trh5L0QCklAl+FzU/7L7Fh4yadsqYafxIHW3SRACMoz4WpftVhtGl5gz0zVShi+W2aftxtDVnJLqStOr+y4Cn9TBAJRAv8W/HSrV/OGWltVatEIhdugWZ+pn20K3Ag7r2ByDV1aDVGeYSIw== X-MS-TrafficTypeDiagnostic: SN2PR03MB2270: X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2270; 31:MgWhBNId2s6+DBc8uW8ZXHbhKT2mJ6z0iQq+2wLcrRSncIKShkRPvtX9jogBvGfockms8JR+94tA5IRIZdmLG9Z2wWD2lwRrYcjPaOhyTLWp18EkmNJdM3tkyGkhBUMWR1POKfgfQ4YMheKQlCcyC0afpy7egRZ+zsl92da98yNDxJmTjThM8SMaRnWc/HzleEaSxZZcT80BO9mIIn7S0ZG0SKaU+CZrri+lnpdcTho=; 4:sbeGCBRk+RfiUaWx7vZY/WODukCwLNnkyn2hblL+BM5s7+ufDwphtoJJqzvDP6qrg/Ak1/GCUqaqU65cF1McmbsEekwY4JQmt4yXQtI8stGUnKUu5TJ/GcugAqYw8AFDuL1opvkeEwdd7jlySIuVa2xDVipFSYS0u/HJi6MQUod5gK5O5scdolk0+x0i2GQkzXHxG3Bj9NoV059TyOUEOJnR4/vnBp8BfrhSmBn8WDR3o7N2mLp4H5bnDZ9Ho+1oPzrWBR8nbnK/qCFdWOeRsX6+I1D1YJ8U12mPHMS7xfg= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: <SN2PR03MB227045EDE483B6B4ECD0C86684820@SN2PR03MB2270.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(601004)(2401047)(5005006)(13016025)(8121501046)(13018025)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6055026)(6096035)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123559100)(20161123561025)(20161123563025)(20161123556025)(20161123565025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN2PR03MB2270; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN2PR03MB2270; X-Forefront-PRVS: 0401647B7F X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR03MB2270; 23:MIlGe0fNULsBn1KoobtTSLRrEvEiG3pGlbQRQ6sI9?= =?us-ascii?Q?JhnGILVeZBbEl7DzYIcY5n+iWUGITebJ0WJgJTJW32lCU7TEyFvCSgi7zJ4j?= =?us-ascii?Q?VDJGrU1m2DZcWJVyZffREy36dgb9I1wjLj253upncDl7BIV49mz4oz0hW5fh?= =?us-ascii?Q?3LMNNWkgWZWxKqLmWpM8cj8NkYaHug/2xKX7MV4L1PIF8T+GTJzwkWEYdAPy?= =?us-ascii?Q?0BlXETpRtz3AuYfUggDTkd6rRgk3/7frWTCNzPkOy0s9dzktYTLXq6LWhpum?= =?us-ascii?Q?qmsuEH9VeWU6KT90rk60OQTcuesluDdIc3eku547B3peAAFKw/0Oh4ERhZlJ?= =?us-ascii?Q?zyf9F257Wp9mwNMyqHs6LbcZZGR0X/CJHwWz4R58YqcXsqEDBlWldmbJtK4c?= =?us-ascii?Q?hZZj8kYMR9fvS1kou+SbRHQGYrvULHqW9c5Ue9x8nOP5JYa95AuM1+6g9yBS?= =?us-ascii?Q?AUCuxCM7ooZAEbiukif6T4Ss9+JOLL3XnPW79Id6xth07Mtvem234HZnT+ew?= =?us-ascii?Q?5fSO2mW3Ibv9WvGSySIkOfWjzJ4Tdkt/htlA7H9hBwqTloXkUAhw3yIDFrLo?= =?us-ascii?Q?QSUWwN9IfWMNoUxMz5N9ryb+WiBxxrwhJ6O4LZnaq2ShC4qHS31qiYXYuYPG?= =?us-ascii?Q?cf6DHvLRjsMw/CMFpvyUQyxhhgQSNsWz2oHo003fHcdVIJSk5CUyZ5B5LSNx?= =?us-ascii?Q?3t+16pxY+1931SWNMICE/H2hffz/wfQbz3Ko+cYh0slL1zwYWK5x+u6Znbf+?= =?us-ascii?Q?QkUbVCpZvdbUpauarVxaG5JAaerRWDcSe9Ta25TfvQCnn/hmgXEPxxIMKh0P?= =?us-ascii?Q?AK/Y8Ivk+VGF9teXJqQDO5nvDpYCQLfacmOnnDUggrxmJRnVGrW2eqBq9lll?= =?us-ascii?Q?fa8UOpVDvBnUypkoTcTt5l1rLT4R+HcQV0kyr9mmbMuBTmvOGtu0Y8il4qMT?= =?us-ascii?Q?0QBbq7IhVzOSxrN7tbMAJcj4Q6VSGsMvW6YxgpFFXZe+mmE5D8VsNSDzt6dd?= =?us-ascii?Q?97FHWaJrcxOmugirLdrvL8rcwjn0v+3/E9a8olHKH8ut0nWw/GRjPIZdSHEw?= =?us-ascii?Q?RR5H3O7TSsQkmGxIVqDK23O9jWZHQS7+iOOCdq4xDzTYgGdVENyO3EcoUXAO?= =?us-ascii?Q?4xpL7oWCNJnv52aCTsepHLpLMFGVdxT+pzN86U98b30mi2f2H6iuA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2270; 6:7tBhfvGgyKcNixO+XM8Xtclm7VE18gFcB19uZk0YJXXMRhyGXRajazOXxcdmsN8ge8qFbj9eZ3ZZXE/a73WIa6a4qX7kZSgaGrRUn+lH8LSYxTjEWNK6N3SjoD5ofQwSUxgZQhT+RT7TbwgvQRaXS9fF3M/NSn5AAQx0kzpfyoBb/BbiA7azjy5OTBTKPv61thPif+zKucZHujGaq2F1LwUSUFo03572sglRasovgGTVaGicW94PWJ7WRyVtQ+pZhRuMLFGK6wQq5UYrJkSGTnsrk+s0jzi/7zjlWnonEQ587JhO+vecLibQle17dEkzw16mAEPT562DHMedWdx8NA==; 5:0zP8cC223HbrnybM4WhhdUOixmr5NAornrF3KzBCFUvcYoegX6urWIuVU3DWLHPDDbqEy2KjaMAoDhuKUGw6VC90zFdrA7xQw961h4kQygF/mSZEWaBCgqCj628vdv0gSjZakQTic0AynEcwvg07lg==; 24:Gf1CGv0plI+Nx8La1ZtINFnDweXx3VlmW6WNoi2vtEZiXG223SJ92wZaG2HoH0EV4N2rTSA+tE4mYeUx+5J52ztdimaUhtOH5Jt3DbKe4+k=; 7:sFsKKk8xfYz2CKUZ8TNfAMgyz8n38sOLO44luymja6wwhaJZ86FK5eMzCzIIYcy3K44eL2jdHJ5i6xyxDth2PY+JRD59ymC4I5+LJ/6GfuO3XW+zy5HJdzPOM1zZqb5Fsbmu37GC4mUDdNW7N71ukt6rjITod57BzwTB7ZJJNWSf0xaqEeCwVGmNJJspNRD0mL7v8KXktkaxJueVv7KIkJxEMM1ZGJXLV+K9u0glTyY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2017 05:14:20.2429 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2270 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: <linux-pci.vger.kernel.org> X-Mailing-List: linux-pci@vger.kernel.org |
diff --git a/drivers/pci/dwc/pcie-designware-host.c b/drivers/pci/dwc/pcie-designware-host.c index 1576211..582f5cc 100644 --- a/drivers/pci/dwc/pcie-designware-host.c +++ b/drivers/pci/dwc/pcie-designware-host.c @@ -597,10 +597,12 @@ void dw_pcie_setup_rc(struct pcie_port *pp) dw_pcie_writel_dbi(pci, PCI_BASE_ADDRESS_1, 0x00000000); /* setup interrupt pins */ + dw_pcie_dbi_ro_wr_en(pci); val = dw_pcie_readl_dbi(pci, PCI_INTERRUPT_LINE); val &= 0xffff00ff; val |= 0x00000100; dw_pcie_writel_dbi(pci, PCI_INTERRUPT_LINE, val); + dw_pcie_dbi_ro_wr_dis(pci); /* setup bus numbers */ val = dw_pcie_readl_dbi(pci, PCI_PRIMARY_BUS); @@ -637,8 +639,12 @@ void dw_pcie_setup_rc(struct pcie_port *pp) dw_pcie_wr_own_conf(pp, PCI_BASE_ADDRESS_0, 4, 0); + /* Enable write permission for the DBI read-only register */ + dw_pcie_dbi_ro_wr_en(pci); /* program correct class for RC */ dw_pcie_wr_own_conf(pp, PCI_CLASS_DEVICE, 2, PCI_CLASS_BRIDGE_PCI); + /* Better disable write permission right after the update */ + dw_pcie_dbi_ro_wr_dis(pci); dw_pcie_rd_own_conf(pp, PCIE_LINK_WIDTH_SPEED_CONTROL, 4, &val); val |= PORT_LOGIC_SPEED_CHANGE;