diff mbox

README: Fix Ubuntu build instructions

Message ID 20170816013700.13507-1-andrew.donnellan@au1.ibm.com
State Superseded
Headers show

Commit Message

Andrew Donnellan Aug. 16, 2017, 1:37 a.m. UTC
Fix the Ubuntu build instructions to install a BE compiler rather than LE.

Fixes: 8fbf67e5b1bd ("README: Update build instructions")
Reported-by: Mark Linimon <linimon@freebsd.org>
Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jeremy Kerr Aug. 16, 2017, 4 a.m. UTC | #1
Hi Andrew,

> Fix the Ubuntu build instructions to install a BE compiler rather than LE.

The both of those should be able to do BE; and having the LE compiler
installed will probably be better suited to the rest of the stack.

What's the motivation for this change? Just the CROSS= argument on the
line below?

Cheers,


Jeremy
Andrew Donnellan Aug. 16, 2017, 4:34 a.m. UTC | #2
On 16/08/17 14:00, Jeremy Kerr wrote:
> Hi Andrew,
> 
>> Fix the Ubuntu build instructions to install a BE compiler rather than LE.
> 
> The both of those should be able to do BE; and having the LE compiler
> installed will probably be better suited to the rest of the stack.
> 
> What's the motivation for this change? Just the CROSS= argument on the
> line below?

The motivation is indeed that right now that CROSS= argument specifies a 
compiler prefix that doesn't exist.

I've just tested in an Ubuntu Docker container and it does seem that the 
LE compiler can do BE fine as long as that CROSS= argument is changed, 
though if we want to do that I should probably add a note clarifying 
that yes, skiboot is still BE.

(It also turns out that we need to add xz-utils to the package list... 
anyone know what the xz package name is on Fedora?)
diff mbox

Patch

diff --git a/README.md b/README.md
index 7042b8e4..0cef3ea6 100644
--- a/README.md
+++ b/README.md
@@ -52,7 +52,7 @@  package management tools.
 
 To build on Ubuntu:
 ```
-apt-get install gcc-powerpc64le-linux-gnu gcc valgrind \
+apt-get install gcc-powerpc64-linux-gnu gcc valgrind \
 	expect libssl-dev device-tree-compiler
 CROSS=powerpc64-linux-gnu- make -j`nproc`
 ```