From patchwork Mon Jan 24 15:05:02 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Janne Blomqvist X-Patchwork-Id: 80176 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 2DA1AB711E for ; Tue, 25 Jan 2011 02:05:17 +1100 (EST) Received: (qmail 16168 invoked by alias); 24 Jan 2011 15:05:11 -0000 Received: (qmail 16148 invoked by uid 22791); 24 Jan 2011 15:05:10 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, TW_BG, TW_CP, TW_PW, TW_TP, TW_WU X-Spam-Check-By: sourceware.org Received: from mail-iy0-f175.google.com (HELO mail-iy0-f175.google.com) (209.85.210.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Jan 2011 15:05:04 +0000 Received: by iyj18 with SMTP id 18so4303580iyj.20 for ; Mon, 24 Jan 2011 07:05:02 -0800 (PST) MIME-Version: 1.0 Received: by 10.231.10.197 with SMTP id q5mr4861659ibq.197.1295881502140; Mon, 24 Jan 2011 07:05:02 -0800 (PST) Received: by 10.231.160.68 with HTTP; Mon, 24 Jan 2011 07:05:02 -0800 (PST) Date: Mon, 24 Jan 2011 17:05:02 +0200 Message-ID: Subject: [Patch, libfortran] PR47375 GETLOG thread safety From: Janne Blomqvist To: Fortran List , GCC Patches Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hello, the attached patch makes the GETLOG intrinsic thread safe by using the POSIX getpwuid_r() function, if available. Regtested on x86_64-unknown-linux-gnu, Ok for trunk? diff --git a/libgfortran/configure.ac b/libgfortran/configure.ac index 4f137e4..9b91f9a 100644 --- a/libgfortran/configure.ac +++ b/libgfortran/configure.ac @@ -249,7 +249,7 @@ AC_CHECK_FUNCS(chdir strerror getlogin gethostname kill link symlink perror) AC_CHECK_FUNCS(sleep time ttyname signal alarm ctime clock access fork execl) AC_CHECK_FUNCS(wait setmode execvp pipe dup2 close fdopen strcasestr getrlimit) AC_CHECK_FUNCS(gettimeofday stat fstat lstat getpwuid vsnprintf dup getcwd) -AC_CHECK_FUNCS(localtime_r gmtime_r strerror_r) +AC_CHECK_FUNCS(localtime_r gmtime_r strerror_r getpwuid_r) # Check for glibc backtrace functions AC_CHECK_FUNCS(backtrace backtrace_symbols) diff --git a/libgfortran/intrinsics/getlog.c b/libgfortran/intrinsics/getlog.c index e75aa1c..baacdf0 100644 --- a/libgfortran/intrinsics/getlog.c +++ b/libgfortran/intrinsics/getlog.c @@ -1,8 +1,8 @@ /* Implementation of the GETLOG g77 intrinsic. - Copyright (C) 2005, 2007, 2009 Free Software Foundation, Inc. + Copyright (C) 2005, 2007, 2009, 2011 Free Software Foundation, Inc. Contributed by François-Xavier Coudert -This file is part of the GNU Fortran 95 runtime library (libgfortran). +This file is part of the GNU Fortran runtime library (libgfortran). Libgfortran is free software; you can redistribute it and/or modify it under the terms of the GNU General Public @@ -75,7 +75,22 @@ PREFIX(getlog) (char * login, gfc_charlen_type login_len) memset (login, ' ', login_len); /* Blank the string. */ -#if defined(HAVE_GETPWUID) && defined(HAVE_GETEUID) +#if defined(HAVE_GETPWUID_R) && defined(HAVE_GETEUID) + struct passwd pwd; + struct passwd *result; + char *buf; + int err; + /* To be pedantic, buflen should be determined by + sysconf(_SC_GETPW_R_SIZE_MAX), which is 1024 on some tested + targets; we do something simple in case the target doesn't + support sysconf. */ + static const size_t buflen = 1024; + buf = get_mem (buflen); + err = getpwuid_r (geteuid (), &pwd, buf, buflen, &result); + if (err != 0 || result == NULL) + goto cleanup; + p = pwd.pw_name; +#elif defined(HAVE_GETPWUID) && defined(HAVE_GETEUID) { struct passwd *pw = getpwuid (geteuid ()); if (pw) @@ -83,20 +98,22 @@ PREFIX(getlog) (char * login, gfc_charlen_type login_len) else return; } -#else -# ifdef HAVE_GETLOGIN +#elif HAVE_GETLOGIN p = getlogin(); # else return; -# endif #endif if (p == NULL) - return; + goto cleanup; p_len = strlen (p); if (login_len < p_len) - memcpy (login, p, login_len); - else - memcpy (login, p, p_len); + p_len = login_len; + memcpy (login, p, p_len); + + cleanup: +#ifdef HAVE_GETPWUID_R + free (buf); +#endif }