From patchwork Mon Jan 24 10:00:47 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Isaku Yamahata X-Patchwork-Id: 80140 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 51F86B7101 for ; Mon, 24 Jan 2011 21:20:41 +1100 (EST) Received: from localhost ([127.0.0.1]:36896 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PhJXK-0002pI-2T for incoming@patchwork.ozlabs.org; Mon, 24 Jan 2011 05:20:38 -0500 Received: from [140.186.70.92] (port=45018 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PhJEC-0004hB-MG for qemu-devel@nongnu.org; Mon, 24 Jan 2011 05:00:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PhJEB-000817-Fw for qemu-devel@nongnu.org; Mon, 24 Jan 2011 05:00:52 -0500 Received: from mail.valinux.co.jp ([210.128.90.3]:35242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PhJEB-00080j-6V for qemu-devel@nongnu.org; Mon, 24 Jan 2011 05:00:51 -0500 Received: from ps.local.valinux.co.jp (vagw.valinux.co.jp [210.128.90.14]) by mail.valinux.co.jp (Postfix) with SMTP id 3863C8746B; Mon, 24 Jan 2011 19:00:48 +0900 (JST) Received: (nullmailer pid 12455 invoked by uid 1000); Mon, 24 Jan 2011 10:00:48 -0000 From: Isaku Yamahata To: qemu-devel@nongnu.org Date: Mon, 24 Jan 2011 19:00:47 +0900 Message-Id: X-Mailer: git-send-email 1.7.1.1 X-Virus-Scanned: clamav-milter 0.95.2 at va-mail.local.valinux.co.jp X-Virus-Status: Clean X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: yamahata@valinux.co.jp, mst@redhat.com Subject: [Qemu-devel] [PATCH] pci: memory leak of PCIDevice::rom_file X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org PCIDevice::rom_file is leaked. PCIDevice::rom_file is allocated in pci_qdev_init(), but not freed anywhere. free it in qemu_unregister_device(). Signed-off-by: Isaku Yamahata --- hw/pci.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index b8f5385..044c4bd 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -833,6 +833,7 @@ static int pci_unregister_device(DeviceState *dev) pci_unregister_io_regions(pci_dev); pci_del_option_rom(pci_dev); + qemu_free(pci_dev->romfile); do_pci_unregister_device(pci_dev); return 0; }