| Message ID | 1502697941-15792-1-git-send-email-alex.hung@canonical.com |
|---|---|
| State | Superseded |
| Headers | show |
On 14/08/17 09:05, Alex Hung wrote: > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/dmi/dmicheck/dmicheck.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c > index eca4971..2c02454 100644 > --- a/src/dmi/dmicheck/dmicheck.c > +++ b/src/dmi/dmicheck/dmicheck.c > @@ -818,7 +818,7 @@ static void dmi_reserved_bits_check(fwts_framework *fw, > uint8_t i; > > for (i = min; i <= max; i++) { > - mask |= (1 << i); > + mask |= ((uint64_t)1 << i); Would 1ULL be better? > } > > switch (size) { >
On Mon, Aug 14, 2017 at 1:08 AM, Colin Ian King <colin.king@canonical.com> wrote: > On 14/08/17 09:05, Alex Hung wrote: >> Signed-off-by: Alex Hung <alex.hung@canonical.com> >> --- >> src/dmi/dmicheck/dmicheck.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c >> index eca4971..2c02454 100644 >> --- a/src/dmi/dmicheck/dmicheck.c >> +++ b/src/dmi/dmicheck/dmicheck.c >> @@ -818,7 +818,7 @@ static void dmi_reserved_bits_check(fwts_framework *fw, >> uint8_t i; >> >> for (i = min; i <= max; i++) { >> - mask |= (1 << i); >> + mask |= ((uint64_t)1 << i); > > Would 1ULL be better? Certainly. Let me do a V2. > >> } >> >> switch (size) { >> >
On 08/14/2017 04:05 PM, Alex Hung wrote: > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/dmi/dmicheck/dmicheck.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c > index eca4971..2c02454 100644 > --- a/src/dmi/dmicheck/dmicheck.c > +++ b/src/dmi/dmicheck/dmicheck.c > @@ -818,7 +818,7 @@ static void dmi_reserved_bits_check(fwts_framework *fw, > uint8_t i; > > for (i = min; i <= max; i++) { > - mask |= (1 << i); > + mask |= ((uint64_t)1 << i); > } > > switch (size) { > Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c index eca4971..2c02454 100644 --- a/src/dmi/dmicheck/dmicheck.c +++ b/src/dmi/dmicheck/dmicheck.c @@ -818,7 +818,7 @@ static void dmi_reserved_bits_check(fwts_framework *fw, uint8_t i; for (i = min; i <= max; i++) { - mask |= (1 << i); + mask |= ((uint64_t)1 << i); } switch (size) {
Signed-off-by: Alex Hung <alex.hung@canonical.com> --- src/dmi/dmicheck/dmicheck.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)