| Message ID | 1502640069-20437-1-git-send-email-sergio.prado@e-labworks.com |
|---|---|
| State | Changes Requested |
| Headers | show |
Hi Sergio, On 13-08-17 18:01, Sergio Prado wrote: [snip] > -BR2_TARGET_UBOOT_FORMAT_CUSTOM=y > -BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.imx" > +BR2_TARGET_UBOOT_FORMAT_IMG=y Did the image really change from u-boot.imx to u-boot.img? Or was there a mistake here and didn't you test properly? BTW, I tried to get this information by looking at the readme.txt, which refers to the website [1], but after looking at all this I still have no idea how to flash the U-Boot image generated by Buildroot... Regards, Arnout [1] http://developer.toradex.com/knowledge-base/flashing-linux-on-imx6-modules > +BR2_TARGET_UBOOT_SPL=y > +BR2_TARGET_UBOOT_SPL_NAME="SPL" > BR2_PACKAGE_HOST_GENIMAGE=y >
Hello Arnout, 2017-08-15 13:01 GMT-03:00 Arnout Vandecappelle <arnout@mind.be>: > > Hi Sergio, > > On 13-08-17 18:01, Sergio Prado wrote: > [snip] > > -BR2_TARGET_UBOOT_FORMAT_CUSTOM=y > > -BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.imx" > > +BR2_TARGET_UBOOT_FORMAT_IMG=y > > Did the image really change from u-boot.imx to u-boot.img? Or was there a > mistake here and didn't you test properly? Yes, It has changed. Since Toradex V2.7 SDK, they changed u-boot image from u-boot.imx to SPL + u-boot.img, as you can see from the link below. http://developer.toradex.com/knowledge-base/build-u-boot-and-linux-kernel-from-source-code#imx-6-based-modules-apaliscolibri-imx6 > BTW, I tried to get this information by looking at the readme.txt, which refers > to the website [1], but after looking at all this I still have no idea how to > flash the U-Boot image generated by Buildroot... There is a undocumented step. In the "Preparation" step in the link below, after downloading the Toradex BSP binary image, we should update it with the images generated by Buildroot (SPL, u-boot.img, zImage, rootfs). Do you think documenting that in the readme.txt file is enough? It is really a mess the way they implemented the process to update eMMC. http://developer.toradex.com/knowledge-base/flashing-linux-on-imx6-modules Best regards, Sergio Prado
On 16-08-17 01:19, Sergio Prado wrote: > Hello Arnout, > > 2017-08-15 13:01 GMT-03:00 Arnout Vandecappelle <arnout@mind.be > <mailto:arnout@mind.be>>: >> >> Hi Sergio, >> >> On 13-08-17 18:01, Sergio Prado wrote: >> [snip] >> > -BR2_TARGET_UBOOT_FORMAT_CUSTOM=y >> > -BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.imx" >> > +BR2_TARGET_UBOOT_FORMAT_IMG=y >> >> Did the image really change from u-boot.imx to u-boot.img? Or was there a >> mistake here and didn't you test properly? > > Yes, It has changed. Since Toradex V2.7 SDK, they changed u-boot image from > u-boot.imx to SPL + u-boot.img, as you can see from the link below. > > http://developer.toradex.com/knowledge-base/build-u-boot-and-linux-kernel-from-source-code#imx-6-based-modules-apaliscolibri-imx6 OK, I'll add that info to the commit message when applying. Or if you could resubmit with an updated commit message, that would be great. >> BTW, I tried to get this information by looking at the readme.txt, which refers >> to the website [1], but after looking at all this I still have no idea how to >> flash the U-Boot image generated by Buildroot... > > There is a undocumented step. In the "Preparation" step in the link below, after > downloading the Toradex BSP binary image, we should update it with the images > generated by Buildroot (SPL, u-boot.img, zImage, rootfs). Do you think > documenting that in the readme.txt file is enough? It is really a mess the way > they implemented the process to update eMMC. Improving the readme.txt to directly explain how to update U-Boot would indeed be great. It's best to keep both the "upstream" reference (which will not be Buildroot-specific), and a short step-by-step explanation of how to do it with the Buildroot output. Note that an update of the readme.txt should of course be a separate patch from the U-Boot + kernel bump. Regards, Arnout > > http://developer.toradex.com/knowledge-base/flashing-linux-on-imx6-modules > > Best regards, > > Sergio Prado
Hi Arnout, > >> Did the image really change from u-boot.imx to u-boot.img? Or was there a > >> mistake here and didn't you test properly? > > > > Yes, It has changed. Since Toradex V2.7 SDK, they changed u-boot image from > > u-boot.imx to SPL + u-boot.img, as you can see from the link below. > > > > http://developer.toradex.com/knowledge-base/build-u-boot-and-linux-kernel-from-source-code#imx-6-based-modules-apaliscolibri-imx6 > > OK, I'll add that info to the commit message when applying. Or if you could > resubmit with an updated commit message, that would be great. Sure, I'll update the commit message and send V2. > >> BTW, I tried to get this information by looking at the readme.txt, which refers > >> to the website [1], but after looking at all this I still have no idea how to > >> flash the U-Boot image generated by Buildroot... > > > > There is a undocumented step. In the "Preparation" step in the link below, after > > downloading the Toradex BSP binary image, we should update it with the images > > generated by Buildroot (SPL, u-boot.img, zImage, rootfs). Do you think > > documenting that in the readme.txt file is enough? It is really a mess the way > > they implemented the process to update eMMC. > > Improving the readme.txt to directly explain how to update U-Boot would indeed > be great. It's best to keep both the "upstream" reference (which will not be > Buildroot-specific), and a short step-by-step explanation of how to do it with > the Buildroot output. > > Note that an update of the readme.txt should of course be a separate patch from > the U-Boot + kernel bump. OK. I'll prepare a patch to improve the documentation for this board. Best regards, Sergio Prado
diff --git a/configs/toradex_apalis_imx6_defconfig b/configs/toradex_apalis_imx6_defconfig index 74d1fb3b9c46..607faaeb8ff6 100644 --- a/configs/toradex_apalis_imx6_defconfig +++ b/configs/toradex_apalis_imx6_defconfig @@ -1,12 +1,12 @@ BR2_arm=y BR2_cortex_a9=y -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_14=y +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_1=y BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0" BR2_ROOTFS_POST_IMAGE_SCRIPT="board/toradex/apalis-imx6/post-image.sh" BR2_LINUX_KERNEL=y BR2_LINUX_KERNEL_CUSTOM_GIT=y BR2_LINUX_KERNEL_CUSTOM_REPO_URL="git://git.toradex.com/linux-toradex.git" -BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="8f237ebe42f2cb911245369276a6b3043c2815f2" +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="3f68dc7c600c0354f5df7f06b931661319addafb" BR2_LINUX_KERNEL_DEFCONFIG="apalis_imx6" BR2_LINUX_KERNEL_DTS_SUPPORT=y BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6q-apalis-eval imx6q-apalis-ixora imx6q-apalis_v1_0-eval imx6q-apalis_v1_0-ixora" @@ -17,8 +17,9 @@ BR2_TARGET_UBOOT=y BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y BR2_TARGET_UBOOT_CUSTOM_GIT=y BR2_TARGET_UBOOT_CUSTOM_REPO_URL="git://git.toradex.com/u-boot-toradex.git" -BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="1ef4a29e8cea0239411dde64f9617ad76248fd02" +BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="f0e414972b5b225e33ebe75574562266116746f9" BR2_TARGET_UBOOT_BOARD_DEFCONFIG="apalis_imx6" -BR2_TARGET_UBOOT_FORMAT_CUSTOM=y -BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.imx" +BR2_TARGET_UBOOT_FORMAT_IMG=y +BR2_TARGET_UBOOT_SPL=y +BR2_TARGET_UBOOT_SPL_NAME="SPL" BR2_PACKAGE_HOST_GENIMAGE=y
Also fix U-Boot build error with GCC6. Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com> --- configs/toradex_apalis_imx6_defconfig | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)