| Message ID | 20170812160946.2278-1-jgross@suse.com |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
Hi Juergen, On Sat, 12 Aug 2017 18:09:46 +0200 Juergen Gross <jgross@suse.com> wrote: > Using direct assignment for a cpumask is wrong, cpumask_copy() should > be used instead. Perhaps a Fixes: tag might be helpful here, such as: Fixes: 96db776a3682 ("i40e/i40evf: fix interrupt affinity bug") as I reported in my other (late) patch: http://marc.info/?l=linux-netdev&m=150279303222066&w=2 > Cc: stable@vger.kernel.org and maybe also an indication about which versions this applies to, such as Cc: stable@vger.kernel.org # 4.10+ In general, feel free to copy from my commit message. These comments also apply to: [PATCH] net/i40evf: use cpumask_copy() for assigning cpumask Thanks, -- Stefano
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index 2db93d3f6d23..c0e42d162c7c 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -3495,7 +3495,7 @@ static void i40e_irq_affinity_notify(struct irq_affinity_notify *notify, struct i40e_q_vector *q_vector = container_of(notify, struct i40e_q_vector, affinity_notify); - q_vector->affinity_mask = *mask; + cpumask_copy(&q_vector->affinity_mask, mask); } /**
Using direct assignment for a cpumask is wrong, cpumask_copy() should be used instead. Cc: stable@vger.kernel.org Signed-off-by: Juergen Gross <jgross@suse.com> --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)