Remove internal_function attribute from string-to-float functions

Message ID 20170812120520.43C334027587E@oldenburg.str.redhat.com
State New
Headers show

Commit Message

Florian Weimer Aug. 12, 2017, 12:05 p.m.
These are called across DSO boundaries and should therefore use
the standard calling convention.

2017-08-12  Florian Weimer  <fweimer@redhat.com>

	* include/stdlib.h: (__strtof_nan, __strtod_nan, __strtold_nan)
	(__wcstof_nan, __wcstod_nan, __wcstold_nan): Remove
	internal_function.
	* stdlib/sttod_nan_main.c (STRTOD_NAN): Likewise.

Comments

H.J. Lu Aug. 13, 2017, 6:07 p.m. | #1
On Sat, Aug 12, 2017 at 02:05:20PM +0200, Florian Weimer wrote:
> These are called across DSO boundaries and should therefore use
> the standard calling convention.
> 
> 2017-08-12  Florian Weimer  <fweimer@redhat.com>
> 
> 	* include/stdlib.h: (__strtof_nan, __strtod_nan, __strtold_nan)
> 	(__wcstof_nan, __wcstod_nan, __wcstold_nan): Remove
> 	internal_function.
> 	* stdlib/sttod_nan_main.c (STRTOD_NAN): Likewise.

LGTM.

Thanks.

H.J.

Patch

diff --git a/include/stdlib.h b/include/stdlib.h
index 6fd868828b..c4a6e6f737 100644
--- a/include/stdlib.h
+++ b/include/stdlib.h
@@ -201,16 +201,12 @@  libc_hidden_proto (strtoll)
 libc_hidden_proto (strtoul)
 libc_hidden_proto (strtoull)
 
-extern float __strtof_nan (const char *, char **, char) internal_function;
-extern double __strtod_nan (const char *, char **, char) internal_function;
-extern long double __strtold_nan (const char *, char **, char)
-     internal_function;
-extern float __wcstof_nan (const wchar_t *, wchar_t **, wchar_t)
-     internal_function;
-extern double __wcstod_nan (const wchar_t *, wchar_t **, wchar_t)
-     internal_function;
-extern long double __wcstold_nan (const wchar_t *, wchar_t **, wchar_t)
-     internal_function;
+extern float __strtof_nan (const char *, char **, char);
+extern double __strtod_nan (const char *, char **, char);
+extern long double __strtold_nan (const char *, char **, char);
+extern float __wcstof_nan (const wchar_t *, wchar_t **, wchar_t);
+extern double __wcstod_nan (const wchar_t *, wchar_t **, wchar_t);
+extern long double __wcstold_nan (const wchar_t *, wchar_t **, wchar_t);
 
 libc_hidden_proto (__strtof_nan)
 libc_hidden_proto (__strtod_nan)
@@ -228,10 +224,8 @@  extern __typeof (strtof128_l) __strtof128_l;
 libc_hidden_proto (__strtof128_l)
 libc_hidden_proto (strtof128)
 
-extern _Float128 __strtof128_nan (const char *, char **, char)
-     internal_function;
-extern _Float128 __wcstof128_nan (const wchar_t *, wchar_t **, wchar_t)
-     internal_function;
+extern _Float128 __strtof128_nan (const char *, char **, char);
+extern _Float128 __wcstof128_nan (const wchar_t *, wchar_t **, wchar_t);
 
 libc_hidden_proto (__strtof128_nan)
 libc_hidden_proto (__wcstof128_nan)
diff --git a/stdlib/strtod_nan_main.c b/stdlib/strtod_nan_main.c
index 96b788cb1e..9f7dd14ad2 100644
--- a/stdlib/strtod_nan_main.c
+++ b/stdlib/strtod_nan_main.c
@@ -29,7 +29,6 @@ 
    return a default NAN.  If ENDPTR is not NULL, set *ENDPTR to point
    to the character after the initial n-char-sequence.  */
 
-internal_function
 FLOAT
 STRTOD_NAN (const STRING_TYPE *str, STRING_TYPE **endptr, STRING_TYPE endc)
 {