From patchwork Sat Aug 12 12:04:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phil Sutter X-Patchwork-Id: 800860 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xV0vd1ctNz9t3F for ; Sat, 12 Aug 2017 22:06:05 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752518AbdHLMGC (ORCPT ); Sat, 12 Aug 2017 08:06:02 -0400 Received: from orbyte.nwl.cc ([151.80.46.58]:35395 "EHLO mail.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752026AbdHLMGB (ORCPT ); Sat, 12 Aug 2017 08:06:01 -0400 Received: from mail.nwl.cc (orbyte.nwl.cc [127.0.0.1]) by mail.nwl.cc (Postfix) with ESMTP id 18E6868252; Sat, 12 Aug 2017 14:06:00 +0200 (CEST) Received: from xsao (localhost [IPv6:::1]) by mail.nwl.cc (Postfix) with ESMTP id DEE6F681D7; Sat, 12 Aug 2017 14:05:59 +0200 (CEST) From: Phil Sutter To: Stephen Hemminger Cc: netdev@vger.kernel.org Subject: [iproute PATCH 27/51] nstat: Fix for potential NULL pointer dereference Date: Sat, 12 Aug 2017 14:04:46 +0200 Message-Id: <20170812120510.28750-28-phil@nwl.cc> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20170812120510.28750-1-phil@nwl.cc> References: <20170812120510.28750-1-phil@nwl.cc> X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org If the string at 'p' contains neither space not newline, 'p' will become NULL. Make sure this isn't the case before dereferencing it. Signed-off-by: Phil Sutter --- misc/nstat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/nstat.c b/misc/nstat.c index a4dd405d43a93..23e1569d7872b 100644 --- a/misc/nstat.c +++ b/misc/nstat.c @@ -198,7 +198,7 @@ static void load_ugly_table(FILE *fp) off = p - buf; p += 2; - while (*p) { + while (p && *p) { char *next; if ((next = strchr(p, ' ')) != NULL)