__netlink_assert_response: Remove internal_function attribute

Submitted by Florian Weimer on Aug. 12, 2017, 12:05 p.m.

Details

Message ID 20170812120517.CF02F4027587E@oldenburg.str.redhat.com
State New
Headers show

Commit Message

Florian Weimer Aug. 12, 2017, 12:05 p.m.
This function is called from nscd and should not use a non-standard
calling convention.

2017-08-12  Florian Weimer  <fweimer@redhat.com>

	* sysdeps/unix/sysv/linux/netlinkaccess.h
	(__netlink_assert_response): Remove internal_function.
	* sysdeps/unix/sysv/linux/netlink_assert_response.c
	(__netlink_assert_response): Likewise.

Comments

H.J. Lu Aug. 13, 2017, 6:06 p.m.
On Sat, Aug 12, 2017 at 02:05:17PM +0200, Florian Weimer wrote:
> This function is called from nscd and should not use a non-standard
> calling convention.
> 
> 2017-08-12  Florian Weimer  <fweimer@redhat.com>
> 
> 	* sysdeps/unix/sysv/linux/netlinkaccess.h
> 	(__netlink_assert_response): Remove internal_function.
> 	* sysdeps/unix/sysv/linux/netlink_assert_response.c
> 	(__netlink_assert_response): Likewise.

LGTM.

Thanks.

H.J.

Patch hide | download patch | download mbox

diff --git a/sysdeps/unix/sysv/linux/netlink_assert_response.c b/sysdeps/unix/sysv/linux/netlink_assert_response.c
index d60eb1515e..39eacb1441 100644
--- a/sysdeps/unix/sysv/linux/netlink_assert_response.c
+++ b/sysdeps/unix/sysv/linux/netlink_assert_response.c
@@ -39,7 +39,6 @@  get_address_family (int fd)
 }
 
 void
-internal_function
 __netlink_assert_response (int fd, ssize_t result)
 {
   if (result < 0)
diff --git a/sysdeps/unix/sysv/linux/netlinkaccess.h b/sysdeps/unix/sysv/linux/netlinkaccess.h
index 6cffb65b14..66bbbe6158 100644
--- a/sysdeps/unix/sysv/linux/netlinkaccess.h
+++ b/sysdeps/unix/sysv/linux/netlinkaccess.h
@@ -51,8 +51,7 @@  extern int __netlink_request (struct netlink_handle *h, int type);
 
 /* Terminate the process if RESULT is an invalid recvmsg result for
    the netlink socket FD.  */
-void __netlink_assert_response (int fd, ssize_t result)
-  internal_function;
+void __netlink_assert_response (int fd, ssize_t result);
 libc_hidden_proto (__netlink_assert_response)
 
 #endif /* netlinkaccess.h */