__libc_rpc_getport: Remove internal_function attribute

Message ID 20170812120516.A745A4027587E@oldenburg.str.redhat.com
State New
Headers show

Commit Message

Florian Weimer Aug. 12, 2017, 12:05 p.m.
This function has a hidden alias and is therefore expected to be
called across DSO boundaries.

2017-08-12  Florian Weimer  <fweimer@redhat.com>

	* include/rpc/pmap_clnt.h (__libc_rpc_getport): Remove
	internal_function.
	* sunrpoc/pm_getport.c (__libc_rpc_getport): Likewise.

Comments

H.J. Lu Aug. 13, 2017, 6:05 p.m. | #1
On Sat, Aug 12, 2017 at 02:05:16PM +0200, Florian Weimer wrote:
> This function has a hidden alias and is therefore expected to be
> called across DSO boundaries.
> 
> 2017-08-12  Florian Weimer  <fweimer@redhat.com>
> 
> 	* include/rpc/pmap_clnt.h (__libc_rpc_getport): Remove
> 	internal_function.
> 	* sunrpoc/pm_getport.c (__libc_rpc_getport): Likewise.
> 

LGTM.

Thanks.

H.J.

Patch

diff --git a/include/rpc/pmap_clnt.h b/include/rpc/pmap_clnt.h
index ec907c28cc..7928f0b368 100644
--- a/include/rpc/pmap_clnt.h
+++ b/include/rpc/pmap_clnt.h
@@ -12,8 +12,7 @@  extern int __get_socket (struct sockaddr_in *saddr)
      attribute_hidden internal_function;
 extern u_short __libc_rpc_getport (struct sockaddr_in *address, u_long program,
 				   u_long version, u_int protocol,
-				   time_t timeout_sec, time_t tottimeout_sec)
-     internal_function;
+				   time_t timeout_sec, time_t tottimeout_sec);
 libc_hidden_proto (__libc_rpc_getport)
 
 libc_hidden_proto (clnt_broadcast)
diff --git a/sunrpc/pm_getport.c b/sunrpc/pm_getport.c
index 54d2e439d2..a9992a38ea 100644
--- a/sunrpc/pm_getport.c
+++ b/sunrpc/pm_getport.c
@@ -82,7 +82,6 @@  __get_socket (struct sockaddr_in *saddr)
  * Returns 0 if no map exists.
  */
 u_short
-internal_function
 __libc_rpc_getport (struct sockaddr_in *address, u_long program,
 		    u_long version, u_int protocol, time_t timeout_sec,
 		    time_t tottimeout_sec)